jackjlli commented on PR #12764: URL: https://github.com/apache/pinot/pull/12764#issuecomment-2032666868
Not just the test code which will invoke the real logic, in fact a lot of companies will invoke the handleRequest() method with their own ways. > I have handled this at [test side code](https://github.com/apache/pinot/pull/12417/files#diff-ef432222ed63283ab900bf309612a3c4b6d2a0d1e15abc76fad46a19b2b1750cR168) itself earlier during introduction of the util. And I just tested the code before the [PR](https://github.com/apache/pinot/pull/12417) mentioned above, previously the test did work with a null httpHeaders. But after the code change in that PR it starts to fail with a null httpHeaders. Could you add a unit test for this to make sure the original behavior won't break? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
