Re: [PR] jsonExtractIndex support array of default values [pinot]

2024-03-28 Thread via GitHub
codecov-commenter commented on PR #12748: URL: https://github.com/apache/pinot/pull/12748#issuecomment-2026757577 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12748?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] jsonExtractIndex support array of default values [pinot]

2024-03-28 Thread via GitHub
saurabhd336 opened a new pull request, #12748: URL: https://github.com/apache/pinot/pull/12748 https://github.com/apache/pinot/pull/12532 added support for extracting multi value json fields using `jsonExtractIndex`. The default value was always an empty array `[]`. This PR enhances the fun

(pinot) branch emit-table-size-metrics updated (3183940a20 -> ffd1404b8e)

2024-03-28 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch emit-table-size-metrics in repository https://gitbox.apache.org/repos/asf/pinot.git discard 3183940a20 Emit table size related metrics only in lead controller add ffd1404b8e Emit table size r

(pinot) branch emit-table-size-metrics created (now 3183940a20)

2024-03-28 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch emit-table-size-metrics in repository https://gitbox.apache.org/repos/asf/pinot.git at 3183940a20 Emit table size related metrics only in lead controller This branch includes the following n

(pinot) 01/01: Emit table size related metrics only in lead controller

2024-03-28 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch emit-table-size-metrics in repository https://gitbox.apache.org/repos/asf/pinot.git commit 3183940a2078e6de58642f2a2b9cd463f3d19f57 Author: jlli_LinkedIn AuthorDate: Thu Mar 28 20:42:23 2024 -0700

Re: [I] NPE when broker header is null [pinot]

2024-03-28 Thread via GitHub
jackjlli commented on issue #12745: URL: https://github.com/apache/pinot/issues/12745#issuecomment-2026438959 Thanks @jtao15 for reporting! Would @shounakmk219 take this up? Also, does it make more sense to unify the way of passing parameters for queries? There are already quite a few ways

Re: [I] NPE when broker header is null [pinot]

2024-03-28 Thread via GitHub
jtao15 commented on issue #12745: URL: https://github.com/apache/pinot/issues/12745#issuecomment-2026428706 cc @vvivekiyer @Jackie-Jiang @jackjlli @siddharthteotia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-03-28 Thread via GitHub
codecov-commenter commented on PR #12744: URL: https://github.com/apache/pinot/pull/12744#issuecomment-2026286837 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12744?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-03-28 Thread via GitHub
itschrispeck opened a new pull request, #12744: URL: https://github.com/apache/pinot/pull/12744 **Problem:** We typically see long (7-10min) segment build times when using Lucene index with 1-1.5GB segment sizes. 70-80% of this time is spent building the Lucene text index. **Back

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

2024-03-28 Thread via GitHub
chenboat commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1543765265 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +75,26 @@ public static Object hashPrimaryKey(PrimaryKey primaryK

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

2024-03-28 Thread via GitHub
chenboat commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1543747564 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,33 @@ public static byte[] hashMD5(byte[] bytes) { retur

Re: [PR] fix for #12735. moving dependency version declarations to maven properties [pinot]

2024-03-28 Thread via GitHub
Jackie-Jiang commented on code in PR #12736: URL: https://github.com/apache/pinot/pull/12736#discussion_r1543611968 ## pinot-plugins/pinot-file-system/pinot-s3/pom.xml: ## @@ -35,10 +35,10 @@ https://pinot.apache.org ${basedir}/../../.. -4.5.14 Review Comment:

Re: [PR] Upgrade quartz to 2.4.0-rc2 to fix CVE-2023-39017 [pinot]

2024-03-28 Thread via GitHub
Jackie-Jiang commented on PR #12743: URL: https://github.com/apache/pinot/pull/12743#issuecomment-2025906048 Do we want to use an rc release as dependency? From the [discussion](https://github.com/quartz-scheduler/quartz/issues/943#issuecomment-1968623291) seems the problem is not fixed in

Re: [PR] Upgrade quartz to 2.4.0-rc2 to fix CVE-2023-39017 [pinot]

2024-03-28 Thread via GitHub
codecov-commenter commented on PR #12743: URL: https://github.com/apache/pinot/pull/12743#issuecomment-2025904029 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12743?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upgrade quartz to 2.4.0-rc2 to fix CVE-2023-39017 [pinot]

2024-03-28 Thread via GitHub
xiangfu0 commented on PR #12743: URL: https://github.com/apache/pinot/pull/12743#issuecomment-2025822130 Ref: https://github.com/quartz-scheduler/quartz/issues/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
shounakmk219 commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1543369785 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml: ## @@ -209,41 +235,46 @@ rules: ## In case a metric does not fit the catch-all patte

Re: [PR] Add GZIP Compression Codec (#11434) [pinot]

2024-03-28 Thread via GitHub
Jackie-Jiang commented on code in PR #12668: URL: https://github.com/apache/pinot/pull/12668#discussion_r1543370962 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/compression/GzipDecompressor.java: ## @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache Softw

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
shounakmk219 commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1543366902 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java: ## @@ -241,7 +242,7 @@ public void cleanupSegmentCountGauge(final String reso

(pinot) branch master updated: Add GZIP Compression Codec (#11434) (#12668)

2024-03-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 470f8ba2e0 Add GZIP Compression Codec (#11434) (#

Re: [PR] Add GZIP Compression Codec (#11434) [pinot]

2024-03-28 Thread via GitHub
Jackie-Jiang merged PR #12668: URL: https://github.com/apache/pinot/pull/12668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Replace custom fmpp plugin with fmpp-maven-plugin (#12737)

2024-03-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new bb2eb49475 Replace custom fmpp plugin with fmpp-m

Re: [PR] Replace custom fmpp plugin with fmpp-maven-plugin [pinot]

2024-03-28 Thread via GitHub
Jackie-Jiang merged PR #12737: URL: https://github.com/apache/pinot/pull/12737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-assembly-plugin-3.7.1 deleted (was 10bdee5b74)

2024-03-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-assembly-plugin-3.7.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 10bdee5b74 Bump org.apache.maven.plugins:maven-assembly

(pinot) branch master updated: Bump org.apache.maven.plugins:maven-assembly-plugin from 3.6.0 to 3.7.1 (#12741)

2024-03-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 03e945bf20 Bump org.apache.maven.plugins:maven-as

Re: [PR] Bump org.apache.maven.plugins:maven-assembly-plugin from 3.6.0 to 3.7.1 [pinot]

2024-03-28 Thread via GitHub
Jackie-Jiang merged PR #12741: URL: https://github.com/apache/pinot/pull/12741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.34.0 deleted (was 53dcab0437)

2024-03-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.34.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 53dcab0437 Bump com.google.cloud:libraries-bom from 26.32.0 to 26.34.

(pinot) branch master updated: Bump com.google.cloud:libraries-bom from 26.32.0 to 26.34.0 (#12740)

2024-03-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new da24616750 Bump com.google.cloud:libraries-bom fr

Re: [PR] Bump com.google.cloud:libraries-bom from 26.32.0 to 26.34.0 [pinot]

2024-03-28 Thread via GitHub
Jackie-Jiang merged PR #12740: URL: https://github.com/apache/pinot/pull/12740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
shounakmk219 commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1543355213 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -796,6 +809,7 @@ private void removeGaugeFromMetricRegistry(String metri

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
shounakmk219 commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1543350090 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml: ## @@ -159,42 +175,47 @@ rules: ## In case a metric does not fit the catch-all patterns,

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
shounakmk219 commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1543349757 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/minion.yml: ## @@ -36,18 +38,20 @@ rules: # This is a catch-all pattern for pinot table metrics wi

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
shounakmk219 commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1543349277 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml: ## @@ -159,41 +183,46 @@ rules: ## In case a metric does not fit the catch-all patterns,

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
zhtaoxiang commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1543315070 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -796,6 +809,7 @@ private void removeGaugeFromMetricRegistry(String metricN

Re: [I] Proposal to Harmonize Pinot Dependency Management [pinot]

2024-03-28 Thread via GitHub
timveil commented on issue #12676: URL: https://github.com/apache/pinot/issues/12676#issuecomment-2025495263 > @timveil - thanks for expressing interest. Just to confirm - are you open to working on action items coming out of this ? yes. i have a strong interest in improving dependen

[PR] Bump com.google.cloud:libraries-bom from 26.32.0 to 26.34.0 [pinot]

2024-03-28 Thread via GitHub
dependabot[bot] opened a new pull request, #12740: URL: https://github.com/apache/pinot/pull/12740 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.32.0 to 26.34.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bom/

[PR] Bump org.apache.maven.plugins:maven-assembly-plugin from 3.6.0 to 3.7.1 [pinot]

2024-03-28 Thread via GitHub
dependabot[bot] opened a new pull request, #12741: URL: https://github.com/apache/pinot/pull/12741 Bumps [org.apache.maven.plugins:maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) from 3.6.0 to 3.7.1. Release notes Sourced from https://github.com/apache/mave

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-assembly-plugin-3.7.1 created (now 10bdee5b74)

2024-03-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-assembly-plugin-3.7.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 10bdee5b74 Bump org.apache.maven.plugins:maven-asse

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.34.0 created (now 53dcab0437)

2024-03-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.34.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 53dcab0437 Bump com.google.cloud:libraries-bom from 26.32.0 to 26

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-28 Thread via GitHub
codecov-commenter commented on PR #12739: URL: https://github.com/apache/pinot/pull/12739#issuecomment-2024563481 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12739?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u