Jackie-Jiang commented on code in PR #12736: URL: https://github.com/apache/pinot/pull/12736#discussion_r1543611968
########## pinot-plugins/pinot-file-system/pinot-s3/pom.xml: ########## @@ -35,10 +35,10 @@ <url>https://pinot.apache.org</url> <properties> <pinot.root>${basedir}/../../..</pinot.root> - <http.client.version>4.5.14</http.client.version> Review Comment: Since the dependency is already declared in the root pom, we shouldn't need to override it again. Ideally we shouldn't add extra exclusions to the dependency in the child pom as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
