Re: [I] CVEs detected in dependencies of pinot-java-client and pinot-common [pinot]

2024-02-03 Thread via GitHub
snleee commented on issue #12341: URL: https://github.com/apache/pinot/issues/12341#issuecomment-1925506633 @robertzych Would you help on filing pr for the above changes? By the way, I think that we should bump up one library per PR to make the rollback process easy if any issue happens due

(pinot) branch master updated: Skip instead of throwing error on 'getValidDocIdMetadata' (#12360)

2024-02-03 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0a03c542ec Skip instead of throwing error on 'getV

Re: [PR] Skip instead of throwing error on 'getValidDocIdMetadata' [pinot]

2024-02-03 Thread via GitHub
snleee merged PR #12360: URL: https://github.com/apache/pinot/pull/12360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] [Multi-stage] Ser/de stage plan in parallel [pinot]

2024-02-03 Thread via GitHub
codecov-commenter commented on PR #12363: URL: https://github.com/apache/pinot/pull/12363#issuecomment-1925498994 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] [Multi-stage] Ser/de stage plan in parallel [pinot]

2024-02-03 Thread via GitHub
walterddr commented on code in PR #12363: URL: https://github.com/apache/pinot/pull/12363#discussion_r1477143458 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java: ## @@ -97,42 +97,60 @@ public void shutdown() { @Override public

[PR] [Multi-stage] Ser/de stage plan in parallel [pinot]

2024-02-03 Thread via GitHub
Jackie-Jiang opened a new pull request, #12363: URL: https://github.com/apache/pinot/pull/12363 Making stage plan serialization (on broker) and deserialization (on server) execute in parallel -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[I] Docs: Bugs in Kubernetes Quick Start [pinot]

2024-02-03 Thread via GitHub
dttung2905 opened a new issue, #12362: URL: https://github.com/apache/pinot/issues/12362 Hi team, I was following the kuberentes [quickstart docs](https://docs.pinot.apache.org/basics/getting-started/kubernetes-quickstart) and found out a few "Inconsistency" - we don't pin the helm c

Re: [PR] Add Helper Functions in StarTreeBuilderUtils and StarTreeV2BuilderConfig [pinot]

2024-02-03 Thread via GitHub
codecov-commenter commented on PR #12361: URL: https://github.com/apache/pinot/pull/12361#issuecomment-1925460370 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12361?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Add Helper Functions in StarTreeBuilderUtils and StarTreeV2BuilderConfig [pinot]

2024-02-03 Thread via GitHub
aishikbh opened a new pull request, #12361: URL: https://github.com/apache/pinot/pull/12361 Added the following helper functions: - generateBuilderConfigs : Generates builder configs from JsonNode segment metadata - generateDefaultConfig: Generates default config from JsonNode comn

Re: [PR] Skip instead of throwing error on 'getValidDocIdMetadata' [pinot]

2024-02-03 Thread via GitHub
snleee commented on code in PR #12360: URL: https://github.com/apache/pinot/pull/12360#discussion_r1477122176 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java: ## @@ -610,7 +614,7 @@ public String getValidDocIdMetadata( public String get

Re: [PR] Skip instead of throwing error on 'getValidDocIdMetadata' [pinot]

2024-02-03 Thread via GitHub
snleee commented on code in PR #12360: URL: https://github.com/apache/pinot/pull/12360#discussion_r1477122121 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -961,7 +961,7 @@ public String getTableAggregateValidDo

(pinot) branch master updated: [Multi-stage] Optimize query dispatch (#12358)

2024-02-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c9a82c40a2 [Multi-stage] Optimize query dispatch

Re: [PR] [Multi-stage] Optimize query dispatch [pinot]

2024-02-03 Thread via GitHub
Jackie-Jiang merged PR #12358: URL: https://github.com/apache/pinot/pull/12358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [Multi-stage] Optimize query dispatch [pinot]

2024-02-03 Thread via GitHub
Jackie-Jiang commented on code in PR #12358: URL: https://github.com/apache/pinot/pull/12358#discussion_r1477120044 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -107,50 +110,76 @@ public ResultTable submitAndReduce(Requ

Re: [PR] Skip instead of throwing error on 'getValidDocIdMetadata' [pinot]

2024-02-03 Thread via GitHub
Jackie-Jiang commented on code in PR #12360: URL: https://github.com/apache/pinot/pull/12360#discussion_r1477116983 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -961,7 +961,7 @@ public String getTableAggregateV

Re: [I] [multistage] attach default limit 10 to queries that doesn't have a limit [pinot]

2024-02-03 Thread via GitHub
walterddr commented on issue #12304: URL: https://github.com/apache/pinot/issues/12304#issuecomment-1925435872 this will work only in happy-path. it is not guarantee that the validated top is a always SqlSelect for normal queries. but it is a good starting point. ( for example it could be a

Re: [PR] Skip instead of throwing error on 'getValidDocIdMetadata' [pinot]

2024-02-03 Thread via GitHub
codecov-commenter commented on PR #12360: URL: https://github.com/apache/pinot/pull/12360#issuecomment-1925428907 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12360?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Skip instead of throwing error on 'getValidDocIdMetadata' [pinot]

2024-02-03 Thread via GitHub
snleee opened a new pull request, #12360: URL: https://github.com/apache/pinot/pull/12360 - Current server side API throws the error if the snapshot file is not availble. In this case, we should skip instead of throwing the error. - Improve the API doc for validDocIds related APIs -- T

Re: [PR] [Multi-stage] Optimize query dispatch [pinot]

2024-02-03 Thread via GitHub
walterddr commented on code in PR #12358: URL: https://github.com/apache/pinot/pull/12358#discussion_r1477085074 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -107,50 +110,76 @@ public ResultTable submitAndReduce(Request

[I] VECTOR_SIMILARITY second operand must be a float array [pinot]

2024-02-03 Thread via GitHub
hdulay opened a new issue, #12359: URL: https://github.com/apache/pinot/issues/12359 I'm testing the Vector Similarity function using this statement but getting the corresponding error: `For VECTOR_SIMILARITY predicate, the second operand must be a float array literal` ```sql sele