robertzych commented on PR #12329:
URL: https://github.com/apache/pinot/pull/12329#issuecomment-1913468224
@snleee One of the tests in UpsertCompactionMinionClusterIntegrationTest
should have been failing without this fix. The changes in the draft PR require
this fix.
--
This is an autom
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ed6761a982 Fix "rewind()" for CompactedPinotSegmen
snleee merged PR #12329:
URL: https://github.com/apache/pinot/pull/12329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
snleee commented on PR #12329:
URL: https://github.com/apache/pinot/pull/12329#issuecomment-1913456635
@robertzych Can you elaborate on the false positives? I do have a plan to
merge `UpsertCompactionMinionClusterIntegrationTest` into
`UpsertTableIntegrationTest`. I will address your commen
robertzych commented on PR #12329:
URL: https://github.com/apache/pinot/pull/12329#issuecomment-1913386235
@snleee Should we also fix `UpsertCompactionMinionClusterIntegrationTest`
since it appears to be returning false positives?
--
This is an automated message from the Apache Git Servic
snleee commented on code in PR #12329:
URL: https://github.com/apache/pinot/pull/12329#discussion_r1468657600
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReaderTest.java:
##
@@ -0,0 +1,133 @@
+/**
+ * Licensed to
ege-st commented on code in PR #12329:
URL: https://github.com/apache/pinot/pull/12329#discussion_r1468637152
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReader.java:
##
@@ -35,15 +35,17 @@
*/
public class Com
codecov-commenter commented on PR #12329:
URL: https://github.com/apache/pinot/pull/12329#issuecomment-1913328667
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 23dbb08e8d Make server resource classes conf
KKcorps merged PR #12324:
URL: https://github.com/apache/pinot/pull/12324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
snleee opened a new pull request, #12329:
URL: https://github.com/apache/pinot/pull/12329
- The original implementation for CompactedPinotSegmentRecordReader had an
issue with rewind() because we did not re-initialize the validDocId iterator.
This PR fixes the issue.
- Added the unit tes
kishoreg commented on issue #12328:
URL: https://github.com/apache/pinot/issues/12328#issuecomment-1913189781
Instead of adjusting the query based on index, we should make the planner
smarter to fall back to scan if the index is not yet created.
We do this for other indexes
--
This
vmarchaud commented on issue #12315:
URL: https://github.com/apache/pinot/issues/12315#issuecomment-1913108841
I've been using pinot for few years in prod right now to store customers
data and this issue got us looking into alternative dbs for performing
aggregations and saving results into
13 matches
Mail list logo
