snleee commented on code in PR #12329: URL: https://github.com/apache/pinot/pull/12329#discussion_r1468657600
########## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReaderTest.java: ########## @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.readers; + +import com.google.common.io.Files; +import java.io.File; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.TimeUnit; +import org.apache.commons.io.FileUtils; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.data.TimeGranularitySpec; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.apache.pinot.spi.data.readers.RecordReader; +import org.apache.pinot.spi.utils.builder.TableConfigBuilder; +import org.roaringbitmap.RoaringBitmap; +import org.testng.Assert; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + + +public class CompactedPinotSegmentRecordReaderTest { + private static final int NUM_ROWS = 10000; + private static final String D_SV_1 = "d_sv_1"; + private static final String D_MV_1 = "d_mv_1"; + private static final String M1 = "m1"; + private static final String M2 = "m2"; + private static final String TIME = "t"; + + private String _segmentOutputDir; + private File _segmentIndexDir; + private List<GenericRow> _rows; + private RecordReader _recordReader; + + @BeforeClass + public void setup() + throws Exception { + Schema schema = createPinotSchema(); + TableConfig tableConfig = createTableConfig(); + String segmentName = "compactedPinotSegmentRecordReaderTest"; + _segmentOutputDir = Files.createTempDir().toString(); + _rows = PinotSegmentUtil.createTestData(schema, NUM_ROWS); + _recordReader = new GenericRowRecordReader(_rows); + _segmentIndexDir = + PinotSegmentUtil.createSegment(tableConfig, schema, segmentName, _segmentOutputDir, _recordReader); + } + + private Schema createPinotSchema() { + return new Schema.SchemaBuilder().setSchemaName("schema").addSingleValueDimension(D_SV_1, FieldSpec.DataType.STRING) + .addMultiValueDimension(D_MV_1, FieldSpec.DataType.STRING).addMetric(M1, FieldSpec.DataType.INT) + .addMetric(M2, FieldSpec.DataType.FLOAT) + .addTime(new TimeGranularitySpec(FieldSpec.DataType.LONG, TimeUnit.HOURS, TIME), null).build(); + } + + private TableConfig createTableConfig() { + return new TableConfigBuilder(TableType.OFFLINE).setTableName("test").setTimeColumnName(TIME).build(); + } + + @Test + public void testCompactedPinotSegmentRecordReader() + throws Exception { + + RoaringBitmap validDocIds = new RoaringBitmap(); + for (int i = 0; i < NUM_ROWS; i += 2) { + validDocIds.add(i); + } + List<GenericRow> outputRows = new ArrayList<>(); + List<GenericRow> rewindedOutputRows = new ArrayList<>(); Review Comment: good catch :) updated the variable name. ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReader.java: ########## @@ -35,15 +35,17 @@ */ public class CompactedPinotSegmentRecordReader implements RecordReader { private final PinotSegmentRecordReader _pinotSegmentRecordReader; - private final PeekableIntIterator _validDocIdsIterator; + private PeekableIntIterator _validDocIdsIterator; // Reusable generic row to store the next row to return - GenericRow _nextRow = new GenericRow(); + private GenericRow _nextRow = new GenericRow(); // Flag to mark whether we need to fetch another row - boolean _nextRowReturned = true; + private boolean _nextRowReturned = true; + private RoaringBitmap _validDocIdsBitmap; Review Comment: changed to `final` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
