Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1460177601 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageReplicaGroupSelector.java: ## @@ -86,7 +87,16 @@ Pair, Map> select(List se

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1460173782 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java: ## @@ -50,8 +51,9 @@ public class BalancedInstanceSel

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1460168404 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java: ## @@ -89,7 +91,13 @@ Pair, Map> select(List segments

Re: [PR] skip invalid json string rather than throwing error during json indexing [pinot]

wirybeaver commented on code in PR #12238: URL: https://github.com/apache/pinot/pull/12238#discussion_r1460134339 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java: ## @@ -719,4 +719,18 @@ private static void addFieldToPinotSchema(Schema pinotSchema, DataType

Re: [PR] skip invalid json string rather than throwing error during json indexing [pinot]

wirybeaver commented on code in PR #12238: URL: https://github.com/apache/pinot/pull/12238#discussion_r1460136520 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java: ## @@ -371,6 +372,40 @@ public void testGetValuesForKeyAndDocs(

Re: [PR] skip invalid json string rather than throwing error during json indexing [pinot]

wirybeaver commented on code in PR #12238: URL: https://github.com/apache/pinot/pull/12238#discussion_r1460134339 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java: ## @@ -719,4 +719,18 @@ private static void addFieldToPinotSchema(Schema pinotSchema, DataType

[PR] Add first implementation of clpMatch that doesn't explicitly use indexes. [pinot]

kirkrodrigues opened a new pull request, #12291: URL: https://github.com/apache/pinot/pull/12291 tags: feature, backward-incompat, release-notes This adds query rewriting logic to transform a "virtual" UDF, `clpMatch`, into a boolean expression on the columns of a CLP-encoded field.

Re: [PR] fix a deadlock due to getting segmentlock before snapshot lock when replacing segment [pinot]

Jackie-Jiang commented on PR #12241: URL: https://github.com/apache/pinot/pull/12241#issuecomment-1901284069 We might need to revisit this fix. Using a separate lock cannot protect the replaced segment being removed at the same time -- This is an automated message from the Apache Git Serv

Re: [PR] Shared aggregations in StarTree [pinot]

davecromberge commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1459939202 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/store/StarTreeLoaderUtils.java: ## @@ -100,7 +100,16 @@ public StarTreeV2Metadata

Re: [PR] Sticky query routing via query options [pinot]

Jackie-Jiang commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1459888168 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageReplicaGroupSelector.java: ## @@ -86,7 +87,16 @@ Pair, Map> select(List s

Re: [PR] Sticky query routing via query options [pinot]

Jackie-Jiang commented on PR #12276: URL: https://github.com/apache/pinot/pull/12276#issuecomment-1901204217 Please take a look at the failed test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Sticky query routing via query options [pinot]

Jackie-Jiang commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1459885235 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java: ## @@ -89,7 +91,13 @@ Pair, Map> select(List segment

Re: [PR] Sticky query routing via query options [pinot]

Jackie-Jiang commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1459880956 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java: ## @@ -50,8 +51,9 @@ public class BalancedInstanceSe

Re: [PR] [feature] allow dim table config to detect/disallow duplicate PK [pinot]

codecov-commenter commented on PR #12290: URL: https://github.com/apache/pinot/pull/12290#issuecomment-1901075579 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12290?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] Multistage query failure when select a CASE/IN expression [pinot]

walterddr commented on issue #12285: URL: https://github.com/apache/pinot/issues/12285#issuecomment-1901012356 Sweet thank you for reproducing this issue. will take a look!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [feature] allow dim table config to detect/disallow duplicate PK [pinot]

walterddr opened a new pull request, #12290: URL: https://github.com/apache/pinot/pull/12290 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

(pinot) branch master updated: Modify distribution pom to include services (#12289)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7b2a82dd27 Modify distribution pom to include se

Re: [PR] Modify distribution pom to include services [pinot]

xiangfu0 merged PR #12289: URL: https://github.com/apache/pinot/pull/12289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [I] Got empty result from a Multi-valued column when using Lookup join between a fact table and dimension table [pinot]

walterddr commented on issue #12272: URL: https://github.com/apache/pinot/issues/12272#issuecomment-1900915759 confirm this is fixed in latest master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] Got empty result from a Multi-valued column when using Lookup join between a fact table and dimension table [pinot]

walterddr closed issue #12272: Got empty result from a Multi-valued column when using Lookup join between a fact table and dimension table URL: https://github.com/apache/pinot/issues/12272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Shared aggregations in StarTree [pinot]

davecromberge commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1459517429 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java: ## @@ -497,4 +497,35 @@ public static AggregationFunctionType getAg

Re: [PR] Shared aggregations in StarTree [pinot]

davecromberge commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1459484119 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/AvgValueAggregator.java: ## @@ -26,10 +26,11 @@ public class AvgValueAggregator

Re: [I] Able to add duplicate rows with same primary key in dimension table [pinot]

walterddr commented on issue #12284: URL: https://github.com/apache/pinot/issues/12284#issuecomment-1900786250 hmm. I am not able to reproduce whatever you mentioned here regarding the duplicate primary key behavior. can you share a dataset? -- This is an automated message from the Apache

Re: [PR] Modify distribution pom to include services [pinot]

codecov-commenter commented on PR #12289: URL: https://github.com/apache/pinot/pull/12289#issuecomment-1900781004 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] MV encoding config not working [pinot]

gortiz commented on issue #12207: URL: https://github.com/apache/pinot/issues/12207#issuecomment-1900772218 Before closing it, let me try with your version. Do you know which commit or tag was used so I can use the same one? -- This is an automated message from the Apache Git Service. To

Re: [PR] Backwards compatible theta sketch aggregation [pinot]

codecov-commenter commented on PR #12288: URL: https://github.com/apache/pinot/pull/12288#issuecomment-1900768173 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Modify distribution pom to include services [pinot]

gortiz opened a new pull request, #12289: URL: https://github.com/apache/pinot/pull/12289 We have found that there was an issue running quickstarts. Specifically, once the code was compiled with `mvn install -DskipTests -Pbin-dist -Pbuild-shaded-jar`, running `./build/bin/quick-start-batch.

Re: [PR] Theta Sketch Aggregation Enhancements [pinot]

davecromberge commented on PR #12042: URL: https://github.com/apache/pinot/pull/12042#issuecomment-1900702821 @snleee @swaminathanmanish I have created the following draft PR to address the problem reported by @jackjlli: https://github.com/apache/pinot/pull/12288 Please let me know

[PR] Backwards compatible theta sketch aggregation [pinot]

davecromberge opened a new pull request, #12288: URL: https://github.com/apache/pinot/pull/12288 Servers running on versions before upgrading Pinot to the ThetaSketchAccumulator would return Sketches directly to the merge function. This ensures that there is backwards compatibility between

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1459028537 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java: ## @@ -145,6 +145,11 @@ public static boolean isSkipScanFilterReorder(Map

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1459026889 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/InstanceSelectorFactory.java: ## @@ -40,44 +43,48 @@ private InstanceSelectorFactory(

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1459025532 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java: ## @@ -89,7 +91,13 @@ Pair, Map> select(List segments

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1459011671 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java: ## @@ -89,7 +91,13 @@ Pair, Map> select(List segments

Re: [PR] Bump com.google.api.grpc:proto-google-iam-v1 from 1.0.0 to 1.26.0 [pinot]

codecov-commenter commented on PR #12287: URL: https://github.com/apache/pinot/pull/12287#issuecomment-1900344967 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1458937779 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java: ## @@ -50,8 +51,9 @@ public class BalancedInstanceSel

(pinot) branch master updated: Expose metric for table rebalance (#12270)

This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 894e56e0a2 Expose metric for table rebalance

Re: [PR] Expose metric for table rebalance [pinot]

KKcorps merged PR #12270: URL: https://github.com/apache/pinot/pull/12270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

(pinot) branch dependabot/maven/com.google.api.grpc-proto-google-iam-v1-1.25.0 deleted (was 1300fd7f8b)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.api.grpc-proto-google-iam-v1-1.25.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1300fd7f8b Bump com.google.api.grpc:proto-google-iam-v1 f

[PR] Bump com.google.api.grpc:proto-google-iam-v1 from 1.0.0 to 1.26.0 [pinot]

dependabot[bot] opened a new pull request, #12287: URL: https://github.com/apache/pinot/pull/12287 Bumps [com.google.api.grpc:proto-google-iam-v1](https://github.com/googleapis/sdk-platform-java) from 1.0.0 to 1.26.0. Release notes Sourced from https://github.com/googleapis/sdk-pl

Re: [PR] Bump com.google.api.grpc:proto-google-iam-v1 from 1.0.0 to 1.25.0 [pinot]

dependabot[bot] commented on PR #12280: URL: https://github.com/apache/pinot/pull/12280#issuecomment-1900276283 Superseded by #12287. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump com.google.api.grpc:proto-google-iam-v1 from 1.0.0 to 1.25.0 [pinot]

dependabot[bot] closed pull request #12280: Bump com.google.api.grpc:proto-google-iam-v1 from 1.0.0 to 1.25.0 URL: https://github.com/apache/pinot/pull/12280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

(pinot) branch dependabot/maven/com.google.api.grpc-proto-google-iam-v1-1.26.0 created (now a5cce55f17)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.api.grpc-proto-google-iam-v1-1.26.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at a5cce55f17 Bump com.google.api.grpc:proto-google-iam-v1 f

Re: [PR] Theta Sketch Aggregation Enhancements [pinot]

davecromberge commented on PR #12042: URL: https://github.com/apache/pinot/pull/12042#issuecomment-1900222025 Hi @jackjlli, Apologies for blocking your deployment - I am looking at a fix to introduce backward compatibility in the protocol messages between server and broker. -- This i

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1458823509 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/SegmentInstanceCandidate.java: ## @@ -41,4 +41,9 @@ public String getInstance() {

Re: [PR] Sticky query routing via query options [pinot]

saurabhd336 commented on code in PR #12276: URL: https://github.com/apache/pinot/pull/12276#discussion_r1458821960 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageReplicaGroupSelector.java: ## @@ -86,7 +87,16 @@ Pair, Map> select(List se