davecromberge commented on code in PR #12164:
URL: https://github.com/apache/pinot/pull/12164#discussion_r1459939202
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/store/StarTreeLoaderUtils.java:
##########
@@ -100,7 +100,16 @@ public StarTreeV2Metadata getMetadata() {
@Override
public DataSource getDataSource(String columnName) {
- return dataSourceMap.get(columnName);
+ DataSource result = dataSourceMap.get(columnName);
+ // Some query columnNames could be supported by the underlying value
aggregation type; do a secondary lookup
Review Comment:
Resolving before looking up the metadata is a little tricky due to possible
knock-on effects to the StarTreeIndexReader. I haven't been able to formulate a
straightforward solution (yet) - any ideas would be welcome.
Also, I reverted to checking the columnName directly against the map without
resolving stored types because this is necessary for group by queries where the
columnName might be a dimension, not necessarily a function column pair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
