(pinot) branch master updated: Fix NPE for IN clause on constant STRING dictionary (#11930)

2023-11-01 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new fee11d6dc5 Fix NPE for IN clause on constant STRI

Re: [I] Bug with IN predicate eval with multiple values with $SegmentName [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang closed issue #11929: Bug with IN predicate eval with multiple values with $SegmentName URL: https://github.com/apache/pinot/issues/11929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix NPE for IN clause on constant STRING dictionary [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang merged PR #11930: URL: https://github.com/apache/pinot/pull/11930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Allow users to specify lucene analyzer when creating text index [pinot]

2023-11-01 Thread via GitHub
jackluo923 commented on issue #9154: URL: https://github.com/apache/pinot/issues/9154#issuecomment-1789882591 @rohityadav1993 We have implemented this requested feature because we need it right away. After testing on production clusters at a large scale, we can release the changes here.

Re: [PR] Do not allow partial-upsert tables without default-partial-upsert-strategy [pinot]

2023-11-01 Thread via GitHub
tibrewalpratik17 closed pull request #11931: Do not allow partial-upsert tables without default-partial-upsert-strategy URL: https://github.com/apache/pinot/pull/11931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Do not allow partial-upsert tables without default-partial-upsert-strategy [pinot]

2023-11-01 Thread via GitHub
tibrewalpratik17 commented on PR #11931: URL: https://github.com/apache/pinot/pull/11931#issuecomment-1789881434 Found this is fixed in #10610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix NPE for IN clause on constant STRING dictionary [pinot]

2023-11-01 Thread via GitHub
codecov-commenter commented on PR #11930: URL: https://github.com/apache/pinot/pull/11930#issuecomment-1789875836 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11930?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Do not allow partial-upsert tables without default-partial-upsert-strategy [pinot]

2023-11-01 Thread via GitHub
tibrewalpratik17 opened a new pull request, #11931: URL: https://github.com/apache/pinot/pull/11931 We should not allow partial-upsert tables to be created without a default partial-upsert-strategy. Adding a check during table-creation to take care of this scenario. Without default-p

Re: [PR] Removing direct dependencies on `commons-logging` and replacing with `jcl-over-slf4j` [pinot]

2023-11-01 Thread via GitHub
timveil commented on PR #11920: URL: https://github.com/apache/pinot/pull/11920#issuecomment-1789844225 > > what repo are you referring to? > > Sorry for the confusion. I think the intention for this PR is to remove `commons-logging` dependency completely and replace it with `jcl-over

[PR] Fix NPE for IN clause on constant STRING dictionary [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang opened a new pull request, #11930: URL: https://github.com/apache/pinot/pull/11930 Fixes #11929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(pinot) branch master updated: Support auth for queryRunner (#11897)

2023-11-01 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 403790b88f Support auth for queryRunner (#11897)

Re: [PR] Support auth for QueryRunner [pinot]

2023-11-01 Thread via GitHub
xiangfu0 merged PR #11897: URL: https://github.com/apache/pinot/pull/11897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Replace timer with scheduled executor service in IngestionDelayTracker [pinot]

2023-11-01 Thread via GitHub
codecov-commenter commented on PR #11849: URL: https://github.com/apache/pinot/pull/11849#issuecomment-1789721167 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11849?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] [Flaky-test] ForwardIndexHandlerTest.testAddOtherIndexForForwardIndexDisabledColumn() [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #11928: URL: https://github.com/apache/pinot/issues/11928#issuecomment-1789646459 @vvivekiyer @somandal Can you help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] [Flaky-test] ForwardIndexHandlerTest.testAddOtherIndexForForwardIndexDisabledColumn() [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang opened a new issue, #11928: URL: https://github.com/apache/pinot/issues/11928 https://github.com/apache/pinot/actions/runs/6723727665/job/18274422070?pr=11926 Take a quick look and I think this test will fail when maxNumMultiValues is 1 (no duplicate) -- This is an au

Re: [PR] pre-configuration based assignment [pinot]

2023-11-01 Thread via GitHub
jasperjiaguo commented on PR #11578: URL: https://github.com/apache/pinot/pull/11578#issuecomment-1789629202 > should be fixed by #11915 Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [multistage] add rel trait rule for individual hep optimization [pinot]

2023-11-01 Thread via GitHub
ankitsultana commented on PR #11831: URL: https://github.com/apache/pinot/pull/11831#issuecomment-1789627102 @walterddr : Is this ready for review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] remove all direct and transitive dependencies on `commons-logging` [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #11917: URL: https://github.com/apache/pinot/issues/11917#issuecomment-1789617705 Fix: #11920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] [build][ci][flaky] cache maven artifact in GHA containers? [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #11925: URL: https://github.com/apache/pinot/issues/11925#issuecomment-1789616355 IIRC, @xiangfu0 tried this approach, but it is way too slow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Removing direct dependencies on `commons-logging` and replacing with `jcl-over-slf4j` [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on PR #11920: URL: https://github.com/apache/pinot/pull/11920#issuecomment-1789615269 > what repo are you referring to? Sorry for the confusion. I think the intention for this PR is to remove `commons-logging` dependency completely and replace it with `jcl-over-

Re: [PR] Bump com.google.api-client:google-api-client from 1.30.10 to 2.2.0 [pinot]

2023-11-01 Thread via GitHub
dependabot[bot] commented on PR #11906: URL: https://github.com/apache/pinot/pull/11906#issuecomment-1789604756 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch dependabot/maven/com.google.api-client-google-api-client-2.2.0 deleted (was 4fc80ef695)

2023-11-01 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.api-client-google-api-client-2.2.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 4fc80ef695 Bump com.google.api-client:google-api-client from 1

Re: [PR] Bump com.google.api-client:google-api-client from 1.30.10 to 2.2.0 [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang closed pull request #11906: Bump com.google.api-client:google-api-client from 1.30.10 to 2.2.0 URL: https://github.com/apache/pinot/pull/11906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(pinot) branch master updated: Refactor PlanFragmenter to make the logic more clear (#11912)

2023-11-01 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 03a9ec73cd Refactor PlanFragmenter to make the lo

Re: [PR] Refactor PlanFragmenter to make the logic more clear [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang merged PR #11912: URL: https://github.com/apache/pinot/pull/11912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[I] [multistage][bug] warning exceptions not populate to broker [pinot]

2023-11-01 Thread via GitHub
walterddr opened a new issue, #11927: URL: https://github.com/apache/pinot/issues/11927 Currently only the `MetadataBlockType == ERROR` will be populated back to the broker (see: #11746) however several warning messages are not attached for example - `numGroupLimitsReach` will not

(pinot) branch master updated: Fix flaky OfflineClusterIntegrationTest on server response size tests (#11926)

2023-11-01 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 168d630a05 Fix flaky OfflineClusterIntegrationTes

Re: [PR] Fix flaky OfflineClusterIntegrationTest on server response size tests [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang merged PR #11926: URL: https://github.com/apache/pinot/pull/11926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Randomize zookeeper port for test [pinot]

2023-11-01 Thread via GitHub
xiangfu0 closed pull request #11911: Randomize zookeeper port for test URL: https://github.com/apache/pinot/pull/11911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Randomize zookeeper port for test [pinot]

2023-11-01 Thread via GitHub
xiangfu0 commented on PR #11911: URL: https://github.com/apache/pinot/pull/11911#issuecomment-1789583233 Just realized the port is already randomized. Closed it for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fix flaky OfflineClusterIntegrationTest on server response size tests [pinot]

2023-11-01 Thread via GitHub
codecov-commenter commented on PR #11926: URL: https://github.com/apache/pinot/pull/11926#issuecomment-1789545363 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11926?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] Support for Dictionary Based Group-By [pinot]

2023-11-01 Thread via GitHub
ankitsultana commented on issue #11759: URL: https://github.com/apache/pinot/issues/11759#issuecomment-1789494825 To keep folks updated, we are starting work on this and hope to close this in November. There's a couple of use-cases where this will help internally and we are trying to find t

Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]

2023-11-01 Thread via GitHub
heydoriszhang commented on issue #11866: URL: https://github.com/apache/pinot/issues/11866#issuecomment-1789495307 Thanks for confirming and opened #11923 to track. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Fix flaky OfflineClusterIntegrationTest on server response size tests [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang opened a new pull request, #11926: URL: https://github.com/apache/pinot/pull/11926 The flakiness comes from the `assert` statement which can fail when table config change is not picked up by `TableCache` yet -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Removing direct dependencies on `commons-logging` and replacing with `jcl-over-slf4j` [pinot]

2023-11-01 Thread via GitHub
timveil commented on PR #11920: URL: https://github.com/apache/pinot/pull/11920#issuecomment-1789437338 > This is great! Can you also doublecheck if the new built repo doesn't have `commons-logging` pulled (check `.m2` folder) what repo are you referring to? -- This is an automated

Re: [PR] Removing direct dependencies on `commons-logging` and replacing with `jcl-over-slf4j` [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on PR #11920: URL: https://github.com/apache/pinot/pull/11920#issuecomment-1789386714 This is great! Can you also doublecheck if the new built repo doesn't have `commons-logging` pulled (check `.m2` folder) -- This is an automated message from the Apache Git Service

Re: [I] [build][ci][flaky] cache maven artifact in GHA containers? [pinot]

2023-11-01 Thread via GitHub
walterddr commented on issue #11925: URL: https://github.com/apache/pinot/issues/11925#issuecomment-1789386065 simple solution is to add 2 steps in GHA - at the end: package the `/.m2` folder and upload to some cloud storage - at the beginning: download the `/.m2` folder from that stora

[I] [build][ci][flaky] cache maven artifact in GHA [pinot]

2023-11-01 Thread via GitHub
walterddr opened a new issue, #11925: URL: https://github.com/apache/pinot/issues/11925 seeing more and more issues with ``` Error: Failed to execute goal on project pinot-pulsar: Could not resolve dependencies for project org.apache.pinot:pinot-pulsar:jar:1.1.0-SNAPSHOT: Could not

Re: [I] flaky StarTreeClusterIntegrationTest [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #11910: URL: https://github.com/apache/pinot/issues/11910#issuecomment-1789378763 I don't follow why this test failure is related to ZK port -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [draft][multistage] Support multiple semi join [pinot]

2023-11-01 Thread via GitHub
codecov-commenter commented on PR #11922: URL: https://github.com/apache/pinot/pull/11922#issuecomment-1789363980 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11922?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #11866: URL: https://github.com/apache/pinot/issues/11866#issuecomment-1789351098 Opened #11923 to track this feature. @heydoriszhang I think you may revert #9605 in your fork branch, and once #11923 is addressed you may remove that -- This is an automated

Re: [PR] Removing direct dependencies on `commons-logging` and replacing with `jcl-over-slf4j` [pinot]

2023-11-01 Thread via GitHub
codecov-commenter commented on PR #11920: URL: https://github.com/apache/pinot/pull/11920#issuecomment-1789349908 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] [Performance] Large Group By Optimization [pinot]

2023-11-01 Thread via GitHub
walterddr commented on issue #10498: URL: https://github.com/apache/pinot/issues/10498#issuecomment-1789340981 2 issues i think 1. when multiple threads merging all group-by results into a relatively low cardinality group set ( e.g. num-of-group ~= num-of-thread) causes concurrent index

Re: [I] Grouping data by time interval [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #48: URL: https://github.com/apache/pinot/issues/48#issuecomment-1789337499 This is supported now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] Grouping data by time interval [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang closed issue #48: Grouping data by time interval URL: https://github.com/apache/pinot/issues/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Colocated Join Support in Pinot [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang closed issue #8951: Colocated Join Support in Pinot URL: https://github.com/apache/pinot/issues/8951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] Bug in 0.10.0, Incorrect result when using more than two CASE WHEN statement in group by query [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang closed issue #8996: Bug in 0.10.0, Incorrect result when using more than two CASE WHEN statement in group by query URL: https://github.com/apache/pinot/issues/8996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [multistage] default group limit unable to override [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang closed issue #9970: [multistage] default group limit unable to override URL: https://github.com/apache/pinot/issues/9970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] [Performance] Large Group By Optimization [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #10498: URL: https://github.com/apache/pinot/issues/10498#issuecomment-1789328831 The major hotspot (bottleneck) is the step of multiple threads merging all group-by results into a single indexed table -- This is an automated message from the Apache Git Ser

Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]

2023-11-01 Thread via GitHub
Jackie-Jiang commented on issue #11866: URL: https://github.com/apache/pinot/issues/11866#issuecomment-1789314152 @ankitsultana It is a valid query, and the example you posted shows the problem of the original re-write. In Pinot, if we rewrite it into `select distinct concat(id, nm, '-') fr

[PR] [draft][multistage] Support multiple semi join [pinot]

2023-11-01 Thread via GitHub
walterddr opened a new pull request, #11922: URL: https://github.com/apache/pinot/pull/11922 depends on #11831 This PR enables multiple SEMI join can be planned within the same leaf-stage. TODO - [x] modified dynamic broadcast to stack semi joins together in dynamic broadcas

Re: [I] [multistage][bug] block splitter estimation is way off [pinot]

2023-11-01 Thread via GitHub
walterddr commented on issue #11921: URL: https://github.com/apache/pinot/issues/11921#issuecomment-1789261759 i think this is the root cause of #11919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[I] [multistage][bug] block splitter estimation is way off [pinot]

2023-11-01 Thread via GitHub
walterddr opened a new issue, #11921: URL: https://github.com/apache/pinot/issues/11921 when we send data over the mailboxes we are estimating the data size and cut the inbound messges into chunks. however ``` block.getDataSchema().getColumnNames().length * MEDIAN_COLUMN_SIZE_BYTES

[PR] Removing direct dependencies on `commons-logging` and replacing with `jcl-over-slf4j` [pinot]

2023-11-01 Thread via GitHub
timveil opened a new pull request, #11920: URL: https://github.com/apache/pinot/pull/11920 This PR works to remove all direct and transitive dependencies on `commons-logging` due to well documented class-loading issues and lack of active development. In places where `commons-logging` was d

[I] [multistage][bug] error propagation during GRPC failure is not handled when setup is not finished. [pinot]

2023-11-01 Thread via GitHub
walterddr opened a new issue, #11919: URL: https://github.com/apache/pinot/issues/11919 when GRPC internal failure occurs. the ReceivingMailbox doesn't propagate that error back to the next block fetcher if the message was the FIRST block error from broker: ``` 2023/11/01 08:45:52.2

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

2023-11-01 Thread via GitHub
walterddr commented on PR #11824: URL: https://github.com/apache/pinot/pull/11824#issuecomment-1789144413 > Using your words, semantic in phase 1 is: > > * For write path (null value vector creation): > > * ON iff only enabled at table level > * For query path: >

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

2023-11-01 Thread via GitHub
walterddr commented on code in PR #11824: URL: https://github.com/apache/pinot/pull/11824#discussion_r1378937058 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java: ## @@ -300,6 +303,27 @@ public void setTransformFunction(@Nullable String transformFunction) {

[I] [test][bug] query generator doesn't escape string in REGEXP_LIKE [pinot]

2023-11-01 Thread via GitHub
walterddr opened a new issue, #11918: URL: https://github.com/apache/pinot/issues/11918 see: ``` 2023-11-01T01:18:33.7042292Z [ERROR] ExactlyOnceKafkaRealtimeClusterIntegrationTest>BaseRealtimeClusterIntegrationTest.testGeneratedQueries:167->BaseClusterIntegrationTestSet.testGenerate

[I] remove all direct and transitive dependencies on `commons-logging` [pinot]

2023-11-01 Thread via GitHub
timveil opened a new issue, #11917: URL: https://github.com/apache/pinot/issues/11917 There are a number of modules that have either direct or transitive dependencies on `commons-logging`. Using this issue to track their removal. -- This is an automated message from the Apache Git Servic

Re: [PR] Updated for commons-configuration2 in PinotConfiguartion [pinot]

2023-11-01 Thread via GitHub
codecov-commenter commented on PR #11916: URL: https://github.com/apache/pinot/pull/11916#issuecomment-1788796124 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Updated for commons-configuration2 in PinotConfiguartion [pinot]

2023-11-01 Thread via GitHub
abhioncbr opened a new pull request, #11916: URL: https://github.com/apache/pinot/pull/11916 In continuation of the previous work https://github.com/apache/pinot/pull/11792 & https://github.com/apache/pinot/pull/11868, This PR upgrade the `PinotConfiguartion` to `commons-configuartion2`