timveil commented on PR #11920: URL: https://github.com/apache/pinot/pull/11920#issuecomment-1789844225
> > what repo are you referring to? > > Sorry for the confusion. I think the intention for this PR is to remove `commons-logging` dependency completely and replace it with `jcl-over-slf4j`. Can you verify if this is the case by building the pinot project, and check if it doesn't pull `commons-logging` from maven? Yes I was able to verify this using IntelliJ + maven. In Intellij, after the changes, `commons-logging` no longer appears in any module or as an "External Library". I also verified this by searching the effective pom and looking at the build output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
