Jackie-Jiang commented on code in PR #10915:
URL: https://github.com/apache/pinot/pull/10915#discussion_r1232972361
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -395,6 +402,18 @@ protected void finishOp
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8b2fb03d85 [Flaky-test] Fix flaky PinotResourceMa
Jackie-Jiang merged PR #10941:
URL: https://github.com/apache/pinot/pull/10941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
walterddr commented on issue #10872:
URL: https://github.com/apache/pinot/issues/10872#issuecomment-1595598701
sub-query is supported. the problem is this particular sub-query is not
supported :-) reason is exactly in GAP-FILL
--
This is an automated message from the Apache Git Service.
T
walterddr commented on PR #10873:
URL: https://github.com/apache/pinot/pull/10873#issuecomment-1595597854
the integration test failure seems legit. could you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
walterddr commented on code in PR #10873:
URL: https://github.com/apache/pinot/pull/10873#discussion_r1232943998
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##
@@ -185,8 +190,10 @@ private String getMultiStageQueryResponse
walterddr commented on PR #10933:
URL: https://github.com/apache/pinot/pull/10933#issuecomment-1595597232
+1 we are moving away from this. since extracting table name only needed by
controller and it is not designed as QPS heavy path
--
This is an automated message from the Apache Git Ser
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from a8988dd48f Bump snappy-java from 1.1.8.2 to 1.1.10.1 (#10922)
add 4af43665ec [multistage] Do Not Log Entire Plan in
walterddr merged PR #10930:
URL: https://github.com/apache/pinot/pull/10930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
codecov-commenter commented on PR #10941:
URL: https://github.com/apache/pinot/pull/10941#issuecomment-1595580531
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.xerial.snappy-snappy-java-1.1.10.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 0d96cec1ac Bump snappy-java from 1.1.8.2 to 1.1.10.1
The revisions t
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from ce50e71d1e Fix an integer overflow bug. (#10940)
add a8988dd48f Bump snappy-java from 1.1.8.2 to 1.1.10.1 (#10922)
Jackie-Jiang merged PR #10922:
URL: https://github.com/apache/pinot/pull/10922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #10921:
URL: https://github.com/apache/pinot/issues/10921#issuecomment-1595572662
Great suggestion!
Currently we simply return the exception thrown by the Calcite SQL parser.
We can explore if Calcite supports identifying the syntax error from a query.
Jackie-Jiang commented on issue #10907:
URL: https://github.com/apache/pinot/issues/10907#issuecomment-1595571975
We don't want to enforce user to re-create the table when they want to
enable null handling because a lot of users are okay to have old segments not
handling null and just the n
Jackie-Jiang opened a new pull request, #10941:
URL: https://github.com/apache/pinot/pull/10941
`testBasicAndConcurrentAddingAndDeletingSegments()` is flaky when segment
addition/deletion takes long time.
--
This is an automated message from the Apache Git Service.
To respond to the messa
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ce50e71d1e Fix an integer overflow bug. (#10940)
Jackie-Jiang merged PR #10940:
URL: https://github.com/apache/pinot/pull/10940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.google.guava-guava-32.0.1-jre
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 15d01ee44a Bump guava from 30.1.1-jre to 32.0.1-jre
The revisions tha
Jackie-Jiang closed pull request #10920: Bump guava from 30.1.1-jre to
32.0.1-jre
URL: https://github.com/apache/pinot/pull/10920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dependabot[bot] commented on PR #10920:
URL: https://github.com/apache/pinot/pull/10920#issuecomment-1595520565
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
Jackie-Jiang commented on PR #10920:
URL: https://github.com/apache/pinot/pull/10920#issuecomment-1595520529
There are dependency conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Jackie-Jiang commented on issue #10917:
URL: https://github.com/apache/pinot/issues/10917#issuecomment-1595519828
Should be fixed by #10887. We can reopen it if it happens again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Jackie-Jiang closed issue #10917: Integration Test Failure in
BaseRawIntSingleColumnDistinctExecutor
URL: https://github.com/apache/pinot/issues/10917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jackie-Jiang commented on code in PR #10703:
URL: https://github.com/apache/pinot/pull/10703#discussion_r1232890455
##
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##
@@ -409,7 +416,62 @@ protected TableConfig crea
Jackie-Jiang commented on PR #10904:
URL: https://github.com/apache/pinot/pull/10904#issuecomment-1595499931
`init()` should not connect the component to the cluster.
To allow registering extra properties, we can add a method in
`BaseBrokerStarter()` and leave the default implementation e
mcvsubbu commented on issue #10910:
URL: https://github.com/apache/pinot/issues/10910#issuecomment-1595491068
I would prefer that we write unit tests to test the ```uploadSegment()```
method in ```PinotFSSegmentUploader``` class. Can we try to avoid sleeps in
test? There is no right value
Jackie-Jiang commented on issue #10872:
URL: https://github.com/apache/pinot/issues/10872#issuecomment-1595488581
The new multi-stage query engine (with join support) should support
sub-query (cc @walterddr to confirm). One concern of directly supporting
sub-query in the single-stage query
Jackie-Jiang commented on issue #10910:
URL: https://github.com/apache/pinot/issues/10910#issuecomment-1595486217
Yeah, I can see the timeout is set pretty aggressive (100ms). We can
definitely make it longer
--
This is an automated message from the Apache Git Service.
To respond to the m
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from e800693dad Avoid parsing offset when invalid (#10893)
add 2baff8180f Bump jetty-server in
/pinot-plugins/pinot-st
Jackie-Jiang merged PR #10908:
URL: https://github.com/apache/pinot/pull/10908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/pinot-plugins/pinot-stream-ingestion/pinot-pulsar/org.eclipse.jetty-jetty-server-9.4.51.v20230217
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 16007e7074
codecov-commenter commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1595483248
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang commented on PR #10899:
URL: https://github.com/apache/pinot/pull/10899#issuecomment-1595482403
Not introduced in this PR, but per the documentation, seems `executeQuery()`
and `execute()` shouldn't be allowed in the `PreparedStatement`. cc @KKcorps
--
This is an automated m
shenyu0127 commented on PR #10613:
URL: https://github.com/apache/pinot/pull/10613#issuecomment-1595475333
@61yao will not continue working on this PR; I will patch this PR and finish
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mcvsubbu commented on PR #10892:
URL: https://github.com/apache/pinot/pull/10892#issuecomment-1595473885
> Before actually fixing this issue, I want to discuss should we allow
committing segment during the gracefully shutdown period? We need a clear
cutting point beyond which there should b
codecov-commenter commented on PR #10940:
URL: https://github.com/apache/pinot/pull/10940#issuecomment-1595471106
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang commented on issue #10903:
URL: https://github.com/apache/pinot/issues/10903#issuecomment-1595465096
cc @snleee @npawar @navina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chenboat commented on code in PR #10867:
URL: https://github.com/apache/pinot/pull/10867#discussion_r1232868278
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java:
##
@@ -0,0 +1,512 @@
+/**
+ * Licensed to the Apache
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e800693dad Avoid parsing offset when invalid (#10
Jackie-Jiang merged PR #10893:
URL: https://github.com/apache/pinot/pull/10893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
wirybeaver commented on PR #10758:
URL: https://github.com/apache/pinot/pull/10758#issuecomment-1595423664
@jtao15 @snleee Could you review the PR when you are available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
deemoliu closed pull request #10826: Upsert snapshot should be taken before new
a consuming segment created
URL: https://github.com/apache/pinot/pull/10826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
deemoliu commented on PR #10826:
URL: https://github.com/apache/pinot/pull/10826#issuecomment-1595422864
Discussed with @Jackie-Jiang. the fix will be addressed in
partitionUpsertMetadata manager. see #10928
--
This is an automated message from the Apache Git Service.
To respond to th
Jackie-Jiang commented on PR #10892:
URL: https://github.com/apache/pinot/pull/10892#issuecomment-1595422857
Before actually fixing this issue, I want to discuss should we allow
committing segment during the gracefully shutdown period? We need a clear
cutting point beyond which there should
tibrewalpratik17 commented on code in PR #10873:
URL: https://github.com/apache/pinot/pull/10873#discussion_r1232864254
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##
@@ -185,8 +190,10 @@ private String getMultiStageQueryR
Jackie-Jiang commented on code in PR #10891:
URL: https://github.com/apache/pinot/pull/10891#discussion_r1232863110
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -570,12 +570,14 @@ public static v
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 9a1795c2b0 Upgrade to Apache Datasketches 4.0.0 (
Jackie-Jiang merged PR #10878:
URL: https://github.com/apache/pinot/pull/10878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #10884:
URL: https://github.com/apache/pinot/issues/10884#issuecomment-1595412501
Broker request id is generated within the `BrokerRequestHandler`, and I
think we can keep it this way, but include it in the
`org.apache.pinot.common.response.BrokerResponse`.
walterddr commented on PR #10940:
URL: https://github.com/apache/pinot/pull/10940#issuecomment-1595408871
related to #10834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
shenyu0127 opened a new pull request, #10940:
URL: https://github.com/apache/pinot/pull/10940
Currently the when the `_limit` is `Integer.MAX_VALUE`, the assertion will
fail because of the integer overflow. This bug makes the
`MultiStageEngineCustomTenantIntegrationTest` flaky.
Teste
Jackie-Jiang commented on code in PR #10463:
URL: https://github.com/apache/pinot/pull/10463#discussion_r1232841016
##
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##
@@ -425,7 +425,7 @@ public Response downloadSegment(
public Response
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 85bb1fab54 Change list.of to immutableList.of to solve java 8
compilation (#10929)
add b2efb8117a Properly set th
Jackie-Jiang merged PR #10935:
URL: https://github.com/apache/pinot/pull/10935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
codecov-commenter commented on PR #10938:
URL: https://github.com/apache/pinot/pull/10938#issuecomment-1595365838
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10938?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #10939:
URL: https://github.com/apache/pinot/pull/10939#issuecomment-1595364737
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10939?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
tibrewalpratik17 commented on PR #10933:
URL: https://github.com/apache/pinot/pull/10933#issuecomment-1595337996
@xiangfu0 thanks for this! Just fyi we are planning to move away from this
flow in #10873.
--
This is an automated message from the Apache Git Service.
To respond to the messag
codecov-commenter commented on PR #10935:
URL: https://github.com/apache/pinot/pull/10935#issuecomment-1595338078
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
shenyu0127 opened a new pull request, #10939:
URL: https://github.com/apache/pinot/pull/10939
Needs to rebase on top of https://github.com/apache/pinot/pull/10938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
shenyu0127 opened a new pull request, #10938:
URL: https://github.com/apache/pinot/pull/10938
Tested in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
ankitsultana commented on code in PR #10937:
URL: https://github.com/apache/pinot/pull/10937#discussion_r1232774116
##
pinot-server/src/main/java/org/apache/pinot/server/api/resources/InstanceTagResource.java:
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundati
ankitsultana commented on code in PR #10937:
URL: https://github.com/apache/pinot/pull/10937#discussion_r1232772020
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java:
##
@@ -10,7 +10,7 @@
* http://www.apache.org/licenses/LICENSE-2.0
*
npuppala111 opened a new pull request, #10937:
URL: https://github.com/apache/pinot/pull/10937
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jbewing opened a new pull request, #10936:
URL: https://github.com/apache/pinot/pull/10936
### What
This PR fixes a bug which may trigger when an mmap'd segment larger than 2GB
(Integer.MAX_VALUE bytes) is prefetched by SegmentLocalFSDirectory.
There is an (outdated) comment above
shenyu0127 opened a new pull request, #10935:
URL: https://github.com/apache/pinot/pull/10935
Tested in unit tests.
@Jackie-Jiang identified this unnecessary resizing issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
zhuangdaz opened a new issue, #10934:
URL: https://github.com/apache/pinot/issues/10934
I have a col enabled with native text index and my query fails with the
following exception:
```
[
{
"errorCode": 200,
"message": "QueryExecutionError:\njava.lang.RuntimeException
codecov-commenter commented on PR #10933:
URL: https://github.com/apache/pinot/pull/10933#issuecomment-1595188546
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10933?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 commented on code in PR #10933:
URL: https://github.com/apache/pinot/pull/10933#discussion_r1232628210
##
pinot-query-runtime/src/test/resources/queries/BasicQuery.json:
##
@@ -61,6 +61,11 @@
{
"description": "Correlated subquery test",
"sql": "
Jackie-Jiang closed issue #10875: Adding new column as noDictionaryColumn to
existing table causes query-time exceptions
URL: https://github.com/apache/pinot/issues/10875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Jackie-Jiang commented on issue #10875:
URL: https://github.com/apache/pinot/issues/10875#issuecomment-1595150238
Verified that #10851 fixed the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Jackie-Jiang commented on issue #10828:
URL: https://github.com/apache/pinot/issues/10828#issuecomment-1595147866
@eaugene The compressed segment size should already been persisted within
the segment ZK metadata under the key `segment.size.in.bytes`. See #8358 for
more details
--
This is
shenyu0127 commented on PR #10914:
URL: https://github.com/apache/pinot/pull/10914#issuecomment-1595143454
> Should we consider doing the same trick as primitive data types by
tracking a `_hasNull` flag to avoid the extra null handling? That way the
behavior is consistent across all data ty
navina commented on issue #10452:
URL: https://github.com/apache/pinot/issues/10452#issuecomment-1595141414
Thanks for the review @mcvsubbu . I have addressed your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiangfu0 opened a new pull request, #10933:
URL: https://github.com/apache/pinot/pull/10933
- Fixing table name extraction for lateral join queries
- Adding test examples for lateral join
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228963312
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -64,24 +71,42 @@ public static String likeToRegexpLike(String
lucifer4j opened a new pull request, #10932:
URL: https://github.com/apache/pinot/pull/10932
bugfix #10924
The org.apache.pinot.client.PinotClientTransport class is an interface to
implement the client transport for Pinot Java Client connections. Currently,
there is a default implem
walterddr commented on code in PR #10930:
URL: https://github.com/apache/pinot/pull/10930#discussion_r1232312062
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java:
##
@@ -100,7 +100,7 @@ public void submit(Worker.QueryRequest request,
StreamOb
walterddr commented on code in PR #10930:
URL: https://github.com/apache/pinot/pull/10930#discussion_r1232312062
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java:
##
@@ -100,7 +100,7 @@ public void submit(Worker.QueryRequest request,
StreamOb
AnhQuanTran commented on issue #10931:
URL: https://github.com/apache/pinot/issues/10931#issuecomment-1594232837
@mayankshriv Can u help me, bro?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
AnhQuanTran opened a new issue, #10931:
URL: https://github.com/apache/pinot/issues/10931
Hi everyone,
Pinot version: 0.12.1
Java JDK: 11
I tried to ingestion data realtime from kafka to pinot with 2 cases:
**Case 1: It work like charm**
`{"event":{"header": "v1","body"
81 matches
Mail list logo
