[pinot] branch master updated: Avoid parsing offset when invalid (#10893)

[jackie]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new e800693dad Avoid parsing offset when invalid (#10893)
e800693dad is described below

commit e800693dad1038c5f6a09d67ca753d71160238bd
Author: Saurabh Dubey <saurabhd...@gmail.com>
AuthorDate: Sat Jun 17 04:34:03 2023 +0530

    Avoid parsing offset when invalid (#10893)
---
 .../pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
index 7ba6557233..0e1a70bfc2 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
@@ -687,7 +687,6 @@ public class LLRealtimeSegmentDataManager extends 
RealtimeSegmentDataManager {
           _state = State.HOLDING;
           SegmentCompletionProtocol.Response response = 
postSegmentConsumedMsg();
           SegmentCompletionProtocol.ControllerResponseStatus status = 
response.getStatus();
-          StreamPartitionMsgOffset rspOffset = extractOffset(response);
           boolean success;
           switch (status) {
             case NOT_LEADER:
@@ -696,6 +695,7 @@ public class LLRealtimeSegmentDataManager extends 
RealtimeSegmentDataManager {
               hold();
               break;
             case CATCH_UP:
+              StreamPartitionMsgOffset rspOffset = extractOffset(response);
               if (rspOffset.compareTo(_currentOffset) <= 0) {
                 // Something wrong with the controller. Back off and try again.
                 _segmentLogger.error("Invalid catchup offset {} in controller 
response, current offset {}", rspOffset,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org