snleee closed pull request #10856: Add the support for filling the default
header if the header is missing
URL: https://github.com/apache/pinot/pull/10856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
swaminathanmanish closed pull request #10830: (WIP..NOT READY) Adding
LazyReader for lazy initialization of record readers.
URL: https://github.com/apache/pinot/pull/10830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a change to branch minion-hotfix-schema-evolution
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 26e5952d75 Bug Fix: Segment Purger cannot purge old segments after
schema evolution (#10869)
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a change to branch minion-hotfix-schema-evolution-2
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 68e04e3c58 Bug Fix: Segment Purger cannot purge old segments after
schema evolution (#10869)
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a commit to branch minion-hotfix-schema-evolution-2
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 68e04e3c5899adc563ba81908e909f057eb39fc8
Author: Sajjad Moradi
AuthorDate: Wed Jun 7 20:55:29 2
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a change to branch minion-hotfix-schema-evolution
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 26e5952d75 Bug Fix: Segment Purger cannot purge old segments after
schema evolution (#10869)
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 26e5952d75 Bug Fix: Segment Purger cannot purge o
sajjad-moradi merged PR #10869:
URL: https://github.com/apache/pinot/pull/10869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
chenboat commented on code in PR #10867:
URL: https://github.com/apache/pinot/pull/10867#discussion_r1222399303
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java:
##
@@ -0,0 +1,512 @@
+/**
+ * Licensed to the Apache
chenboat commented on code in PR #10867:
URL: https://github.com/apache/pinot/pull/10867#discussion_r1222398109
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java:
##
@@ -0,0 +1,512 @@
+/**
+ * Licensed to the Apache
chenboat commented on issue #10866:
URL: https://github.com/apache/pinot/issues/10866#issuecomment-1581805593
I am not sure what the following means. Can you give an example or is this
idea from some well known source (then can you add a reference to it?)
```
What is meant by causality
JasonLeeWeiHern commented on issue #10753:
URL: https://github.com/apache/pinot/issues/10753#issuecomment-1581791502
Hi jackie, the error i faced was using version 0.11.0.
On our development environment, where table1 does not exist but table2 does
exist, it also shows the same error:
walterddr commented on issue #10871:
URL: https://github.com/apache/pinot/issues/10871#issuecomment-1581751011
> @walterddr Just curious will this not add an additional dependency of
pinot-controller module on `pinot-query-planner`?And what will we pass as
`WorkerManager` to the QueryEnviro
shenyu0127 commented on code in PR #10613:
URL: https://github.com/apache/pinot/pull/10613#discussion_r1222324918
##
pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/TransformBlockValSet.java:
##
@@ -46,47 +45,23 @@ public class TransformBlockValSet implements
shuitai commented on issue #7043:
URL: https://github.com/apache/pinot/issues/7043#issuecomment-1581704377
Any updates on this thread ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
shuitai opened a new issue, #10872:
URL: https://github.com/apache/pinot/issues/10872
I find the doc link
https://docs.pinot.apache.org/users/user-guide-query/gap-fill-functions
In section: Aggregation/Gapfill/Aggregation
The query supports subquery or nested sql, which means pinot
snleee commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r191763
##
pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java:
##
@@ -79,7 +82,7 @@ public File purgeSegment()
return null;
}
- Segm
abhioncbr commented on issue #10871:
URL: https://github.com/apache/pinot/issues/10871#issuecomment-1581669237
Sounds good to me. I can work on this if it's not urgent. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
snleee commented on PR #10856:
URL: https://github.com/apache/pinot/pull/10856#issuecomment-1581665194
@KKcorps Pinot schema is not the source of truth for the reader. Here,
CSVReader's `header` is indicating about the source schema.
In regular cases, `source schema + mapping (transf
deemoliu commented on PR #10836:
URL: https://github.com/apache/pinot/pull/10836#issuecomment-1581663750
thanks for discussion @Jackie-Jiang @navina @KKcorps
do you think i should add a wrapper for upsertConfig or just close this PR?
--
This is an automated message from the Apache
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 03c49e43b4 [multistage] register opChain finish callback for pipeline
breaker to continue (#10870)
add c704147d3e
Jackie-Jiang merged PR #10528:
URL: https://github.com/apache/pinot/pull/10528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r176612
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##
@@ -44,16 +45,18
sajjad-moradi commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r152119
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##
@@ -44,16 +45,1
sajjad-moradi commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r152119
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##
@@ -44,16 +45,1
Jackie-Jiang commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r141882
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##
@@ -44,16 +45,19
Jackie-Jiang commented on PR #10869:
URL: https://github.com/apache/pinot/pull/10869#issuecomment-1581585748
> There is also a case of older tables (that exist even now) when schema was
optional for offline tables
Good point. In that case, we can use the schema from the segment
--
tibrewalpratik17 commented on issue #10871:
URL: https://github.com/apache/pinot/issues/10871#issuecomment-1581585198
> And what will we pass as WorkerManager to the QueryEnvironment object as
it looks specific to broker / server configs?
On deeper look I see we don't need WorkerManager i
mcvsubbu commented on PR #10869:
URL: https://github.com/apache/pinot/pull/10869#issuecomment-1581580573
There is also a case of older tables (that exist even now) when schema was
optional for offline tables
--
This is an automated message from the Apache Git Service.
To respond to the me
tibrewalpratik17 commented on issue #10871:
URL: https://github.com/apache/pinot/issues/10871#issuecomment-1581566627
@walterddr Just curious will this not add an additional dependency of
pinot-controller module on `pinot-query-planner`?And what will we pass as
`WorkerManager` to the QueryE
jackjlli commented on code in PR #9416:
URL: https://github.com/apache/pinot/pull/9416#discussion_r117645
##
pinot-plugins/pinot-metrics/pinot-compound-metrics/src/main/java/org/apache/pinot/plugin/metrics/compound/CompoundPinotMetricsFactory.java:
##
@@ -0,0 +1,170 @@
+/**
sajjad-moradi commented on PR #10869:
URL: https://github.com/apache/pinot/pull/10869#issuecomment-1581551557
> > This doesn't seem to be the correct fix.
> > The real problem is that we are using the table config from the ZK and
schema from the segment file (we picked this way before bec
dario-liberman commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1581538259
I am happy to document the function and create a blog post, but I would
recommend we first merge it in silently (as experimental lets say), have it
there for a bit for folks to try
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 24b50ed65f jsonPathString should return null instead of string literal
"null" (#10855)
add 03c49e43b4 [multistage]
walterddr closed issue #10829: [flaky test] query with pipeline breaker seems
unstable
URL: https://github.com/apache/pinot/issues/10829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
walterddr merged PR #10870:
URL: https://github.com/apache/pinot/pull/10870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
walterddr commented on code in PR #10870:
URL: https://github.com/apache/pinot/pull/10870#discussion_r1222195019
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/RoundRobinScheduler.java:
##
@@ -169,6 +169,8 @@ public void deregister(OpChain operatorC
mcvsubbu commented on PR #10869:
URL: https://github.com/apache/pinot/pull/10869#issuecomment-1581532821
> This doesn't seem to be the correct fix.
>
> The real problem is that we are using the table config from the ZK and
schema from the segment file (we picked this way before becaus
sajjad-moradi commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r1222188549
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PurgeMinionClusterIntegrationTest.java:
##
@@ -96,23 +98,27 @@ public void setUp()
walterddr commented on issue #10871:
URL: https://github.com/apache/pinot/issues/10871#issuecomment-1581528046
CC @tibrewalpratik17 and @abhioncbr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jackie-Jiang commented on PR #10869:
URL: https://github.com/apache/pinot/pull/10869#issuecomment-1581527890
This doesn't seem to be the correct fix.
The real problem is that we are using the table config from the ZK and
schema from the segment file (we picked this way before because
walterddr opened a new issue, #10871:
URL: https://github.com/apache/pinot/issues/10871
Description
==
when query broker for a specific query. there's no need to parse out the
tenant info.
however when using the Pinot controller UI. controller needs to first detect
all the tables
kishoreg commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1581525481
This is amazing.Thanks for contributing.
what will the query look like. Does any other database support this
functionality or they mostly rely on window function..
Can we up
codecov-commenter commented on PR #10870:
URL: https://github.com/apache/pinot/pull/10870#issuecomment-1581510188
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10870?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
PrachiKhobragade commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r1222170641
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PurgeMinionClusterIntegrationTest.java:
##
@@ -96,23 +98,27 @@ public void setUp()
Jackie-Jiang commented on issue #10854:
URL: https://github.com/apache/pinot/issues/10854#issuecomment-1581451331
cc @snleee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Jackie-Jiang commented on issue #10849:
URL: https://github.com/apache/pinot/issues/10849#issuecomment-1581450218
Good catch. I believe the problem is in `likeToRegexpLike` not handing
escape properly. Seems `_` is not defined as a meta-character. cc @atris
--
This is an automated messag
walterddr opened a new pull request, #10870:
URL: https://github.com/apache/pinot/pull/10870
this should fix #10829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 24b50ed65f jsonPathString should return null inst
Jackie-Jiang merged PR #10855:
URL: https://github.com/apache/pinot/pull/10855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0f58e48c8e compress nullvector bitmap upon seal (
Jackie-Jiang merged PR #10852:
URL: https://github.com/apache/pinot/pull/10852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4b9af9d83b clean up output files upon exceptions
Jackie-Jiang merged PR #10847:
URL: https://github.com/apache/pinot/pull/10847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4b0d0d86a9 refine segment reload executor to avoi
Jackie-Jiang merged PR #10837:
URL: https://github.com/apache/pinot/pull/10837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
codecov-commenter commented on PR #10869:
URL: https://github.com/apache/pinot/pull/10869#issuecomment-1581425361
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
mcvsubbu commented on issue #10868:
URL: https://github.com/apache/pinot/issues/10868#issuecomment-1581414112
This is a production issue for us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sajjad-moradi opened a new pull request, #10869:
URL: https://github.com/apache/pinot/pull/10869
Solves the issue https://github.com/apache/pinot/issues/10868
I updated the minion purge integration tests to add a scenario in which the
segments are built with old schema. Without the fi
sajjad-moradi commented on issue #10868:
URL: https://github.com/apache/pinot/issues/10868#issuecomment-1581368892
This issue was masked for inverted index columns before index SPI
refactoring https://github.com/apache/pinot/pull/10184, because the check for
inverted index was bypassed by `
sajjad-moradi opened a new issue, #10868:
URL: https://github.com/apache/pinot/issues/10868
If a column is added to the schema and there's also an index defined for
that column, the older segments which were built by older schema/table config
cannot be purged with the following exception:
Jackie-Jiang commented on PR #10862:
URL: https://github.com/apache/pinot/pull/10862#issuecomment-1581327184
Good findings!
IMO we should find the reason why `stop()` doesn't stop the consumption
properly, and throw exception when the thread cannot be stopped. Essentially
`stop()` should
KKcorps commented on PR #10856:
URL: https://github.com/apache/pinot/pull/10856#issuecomment-1581324260
The issue I feel with this approach is that although we are adding column
names, we are not making any changes to the table schema.
So this will fail during ingestion time.
--
T
dario-liberman opened a new pull request, #10867:
URL: https://github.com/apache/pinot/pull/10867
#10866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
chenboat commented on issue #10863:
URL: https://github.com/apache/pinot/issues/10863#issuecomment-1581246120
This stackoverflow question suggests ElasticSearch (built on top of Lucene)
supports similar substring search feature.
https://stackoverflow.com/questions/44791075/in-elasticsearch-
dario-liberman opened a new issue, #10866:
URL: https://github.com/apache/pinot/issues/10866
A common use-case in real-time interactive analytic applications is [funnel
analysis](https://en.wikipedia.org/wiki/Funnel_analysis).
Example funnel analytics products to name a few:
- [Mix
walterddr commented on issue #10829:
URL: https://github.com/apache/pinot/issues/10829#issuecomment-1581239590
found another race-condition -->
1. when pipeline breaker returns it is side-cart loading the result map
materialized from the PipelineBreakerOperator --> which returns immediat
navina commented on PR #10836:
URL: https://github.com/apache/pinot/pull/10836#issuecomment-1581226541
> `comparisonColumn` might not be set in the upsert config, and we want to
use time column as the comparison column if it is not configured. If we pass
the `UpsertConfig` to the partition
jackluo923 opened a new issue, #10865:
URL: https://github.com/apache/pinot/issues/10865
Lucene strips away stop words and symbols prior to indexing but it seems
like Pinot doesn't do the same when running queries on a text index. As a
result, a query like:
`SELECT * FROM table WHERE tex
walterddr opened a new issue, #10864:
URL: https://github.com/apache/pinot/issues/10864
this specifically happens when the server mailbox / v2 engine service port
is dynamically configured.
when server restarts,
1. server updates the segment instance configuration with the new
dy
jackluo923 opened a new issue, #10863:
URL: https://github.com/apache/pinot/issues/10863
We've seen many cases where a user wants to search for a substring in a
field with a text index. If all of the tokens in the query are complete words,
we can directly use a phrase search:
`SELECT * F
gortiz commented on code in PR #9416:
URL: https://github.com/apache/pinot/pull/9416#discussion_r1221862604
##
pinot-plugins/pinot-metrics/pinot-compound-metrics/src/main/java/org/apache/pinot/plugin/metrics/compound/CompoundPinotMetricsFactory.java:
##
@@ -0,0 +1,170 @@
+/**
+
gortiz commented on code in PR #9416:
URL: https://github.com/apache/pinot/pull/9416#discussion_r1221862604
##
pinot-plugins/pinot-metrics/pinot-compound-metrics/src/main/java/org/apache/pinot/plugin/metrics/compound/CompoundPinotMetricsFactory.java:
##
@@ -0,0 +1,170 @@
+/**
+
walterddr commented on issue #10829:
URL: https://github.com/apache/pinot/issues/10829#issuecomment-1580945727
this is still flaky. see:
https://github.com/apache/pinot/actions/runs/5192571154/jobs/9366737060
--
This is an automated message from the Apache Git Service.
To respond to the
satish-mittal opened a new pull request, #10862:
URL: https://github.com/apache/pinot/pull/10862
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
abhioncbr commented on PR #10814:
URL: https://github.com/apache/pinot/pull/10814#issuecomment-1580715489
@walterddr I saw you have tried to build the PR. Just checking is it
acceptable line of solution or we need to look `TypeCoercion` logic?
--
This is an automated message from the Apac
geekboood commented on issue #10844:
URL: https://github.com/apache/pinot/issues/10844#issuecomment-1580687414
My Pinot server run on HDD so this seems normal. Does Pinot has mechanism to
put index on SSD, such as a seperate index directory?
--
This is an automated message from the Apach
satish-mittal commented on issue #10861:
URL: https://github.com/apache/pinot/issues/10861#issuecomment-1580194353
If we look at Helix path,
`SegmentOnlineOfflineStateModel.onBecomeOnlineFromConsuming` calls
`LLRealtimeSegmentDataManager.goOnlineFromConsuming()`:
```
public void
satish-mittal commented on issue #10861:
URL: https://github.com/apache/pinot/issues/10861#issuecomment-1580175347
cc @atris @mcvsubbu @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
satish-mittal commented on issue #10861:
URL: https://github.com/apache/pinot/issues/10861#issuecomment-1580172849
The entire 10 minutes seem to be taken in index building only. That explains
why we are seeing SIGSEGV only now after enabling lucene index.
```
2023/06/06 12:37:08.77
satish-mittal opened a new issue, #10861:
URL: https://github.com/apache/pinot/issues/10861
Observing that pinot servers are periodically crashing with SIGSEGV after we
enabled lucene based text index on one column. Here is one such instance:
```
2023/06/05 10:57:24.157 INFO
[MutableS
snleee commented on PR #10856:
URL: https://github.com/apache/pinot/pull/10856#issuecomment-1580148040
> Can we also document user experience when this feature is enabled ?
>
> 1. What happens if proper headers are there already ? Here the algorithm
should not get this wrong and overr
82 matches
Mail list logo
