walterddr commented on issue #10871: URL: https://github.com/apache/pinot/issues/10871#issuecomment-1581751011
> @walterddr Just curious will this not add an additional dependency of pinot-controller module on `pinot-query-planner`?And what will we pass as `WorkerManager` to the QueryEnvironment object as it looks specific to broker / server configs? Controller is never designed for sustained QPS workload --> in fact each pending query will hog up a thread/cpu thus it can handle maximum `no_of_core` query at a time. > > Also for 2. we can use `RelToPlanNodeConverter.getTableNamesFromRelRoot(relRoot.rel)` which internally uses `RelOptUtils.findAllTableQualifiedNames(relRoot)` at the moment. This is a part of pinot-query-planner module itself. yes, that's what I meant, we dont need to configure `WorkerManager` as we are not assigning worker at the moment, we only want to do the planning part. > Sounds good to me. I can work on this if it's not urgent. Thanks. Thank you @abhioncbr, sorry I was originally intended to @ankitsultana but yes this is not urgent. please feel free to pick this one up at your convenience. (assigned to you) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
