[GitHub] [pinot] Ehsan-Irshad commented on issue #5612: Support column rename with backwards compatibility

2023-01-30 Thread via GitHub
Ehsan-Irshad commented on issue #5612: URL: https://github.com/apache/pinot/issues/5612#issuecomment-1409747185 https://docs.pinot.apache.org/users/tutorials/schema-evolution "Pinot only allows adding new columns to the schema. In order to drop a column, change the column name or data typ

[pinot] branch master updated: revise table regex to exclude dot (#10207)

2023-01-30 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 63f21c864e revise table regex to exclude dot (#10

[GitHub] [pinot] Jackie-Jiang merged pull request #10207: revise table regex to exclude dot

2023-01-30 Thread via GitHub
Jackie-Jiang merged PR #10207: URL: https://github.com/apache/pinot/pull/10207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] codecov-commenter commented on pull request #10206: Java serialization for BrokerResponse

2023-01-30 Thread via GitHub
codecov-commenter commented on PR #10206: URL: https://github.com/apache/pinot/pull/10206#issuecomment-1409635609 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] zhtaoxiang opened a new pull request, #10207: revise table regex to exclude dot

2023-01-30 Thread via GitHub
zhtaoxiang opened a new pull request, #10207: URL: https://github.com/apache/pinot/pull/10207 (.*?) is too greedy in table name matching, it also includes `.`, for example ```pinot_server_1_Value Attribute exposed for management "org.apache.pinot.common.metrics":name="pinot.server.realt

[GitHub] [pinot] SabrinaZhaozyf opened a new pull request, #10206: Java serialization for BrokerResponse

2023-01-30 Thread via GitHub
SabrinaZhaozyf opened a new pull request, #10206: URL: https://github.com/apache/pinot/pull/10206 This PR extends BrokerResponse to be Java Serializable as part of our pagination effort: https://github.com/apache/pinot/issues/5246 @jackjlli @siddharthteotia -- This is an automated mes

[GitHub] [pinot] 61yao opened a new issue, #10205: [multistage] Return meaningful error msg for unsupported type

2023-01-30 Thread via GitHub
61yao opened a new issue, #10205: URL: https://github.com/apache/pinot/issues/10205 For example, today, the error msg is below when the column type is json. It is better we print out "json is not supported" [ { "message": "SQLParsingError:\njava.lang.RuntimeException

[pinot] branch master updated (544499cf3b -> c03e17d339)

2023-01-30 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 544499cf3b add the missing pinot-minion-log4j2.xml to docker config (#10203) add c03e17d339 improve error messag

[GitHub] [pinot] xiangfu0 merged pull request #10202: improve error message for NormalizedDateSegmentNameGenerator

2023-01-30 Thread via GitHub
xiangfu0 merged PR #10202: URL: https://github.com/apache/pinot/pull/10202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (325a1628c4 -> 544499cf3b)

2023-01-30 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 325a1628c4 [multistage] support count distinct in intermediate stage (#10188) add 544499cf3b add the missing pin

[GitHub] [pinot] xiangfu0 merged pull request #10203: add the missing pinot-minion-log4j2.xml to docker config

2023-01-30 Thread via GitHub
xiangfu0 merged PR #10203: URL: https://github.com/apache/pinot/pull/10203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (0a774844c8 -> 325a1628c4)

2023-01-30 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 0a774844c8 Fix a typo in ready to consume check (#10204) add 325a1628c4 [multistage] support count distinct in

[GitHub] [pinot] siddharthteotia commented on pull request #10188: [multistage] support count distinct in intermediate stage

2023-01-30 Thread via GitHub
siddharthteotia commented on PR #10188: URL: https://github.com/apache/pinot/pull/10188#issuecomment-1409441181 FYI @vvivekiyer @somandal @jasperjiaguo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pinot] siddharthteotia commented on pull request #10188: [multistage] support count distinct in intermediate stage

2023-01-30 Thread via GitHub
siddharthteotia commented on PR #10188: URL: https://github.com/apache/pinot/pull/10188#issuecomment-1409440572 Yes I didn't mean to special case that sort of plan for `DISTINCTCOUNT`. You are right. Just that lately we have been thinking of leveraging multi-stage engine also for no

[GitHub] [pinot] siddharthteotia merged pull request #10188: [multistage] support count distinct in intermediate stage

2023-01-30 Thread via GitHub
siddharthteotia merged PR #10188: URL: https://github.com/apache/pinot/pull/10188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] agavra commented on pull request #10188: [multistage] support count distinct in intermediate stage

2023-01-30 Thread via GitHub
agavra commented on PR #10188: URL: https://github.com/apache/pinot/pull/10188#issuecomment-1409433252 @siddharthteotia - yes I believe your understanding is correct, though I believe that could apply to almost every aggregation that we have in the multistage engine - correct? Essentially y

[pinot] branch master updated: Fix a typo in ready to consume check (#10204)

2023-01-30 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0a774844c8 Fix a typo in ready to consume check (

[GitHub] [pinot] Jackie-Jiang merged pull request #10204: Fix a typo in ready to consume check

2023-01-30 Thread via GitHub
Jackie-Jiang merged PR #10204: URL: https://github.com/apache/pinot/pull/10204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10204: Fix a typo in ready to consume check

2023-01-30 Thread via GitHub
Jackie-Jiang opened a new pull request, #10204: URL: https://github.com/apache/pinot/pull/10204 Fix a typo introduced in #10198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] siddharthteotia commented on pull request #10188: [multistage] support count distinct in intermediate stage

2023-01-30 Thread via GitHub
siddharthteotia commented on PR #10188: URL: https://github.com/apache/pinot/pull/10188#issuecomment-1409379408 Is my reading correct that let's say the following `DISTINCTCOUNT` query on multi stage engine can potentially be done in a 3 stage plan as opposed to a existing engine's 2 stage

[GitHub] [pinot] jugomezv commented on a diff in pull request #10182: deprecate _gaugeValues used in AbstractMetrics

2023-01-30 Thread via GitHub
jugomezv commented on code in PR #10182: URL: https://github.com/apache/pinot/pull/10182#discussion_r1091019669 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -732,14 +729,4 @@ private void removeGaugeFromMetricRegistry(String metricNa

[GitHub] [pinot] siddharthteotia commented on issue #10201: Support for offset in grouped queries

2023-01-30 Thread via GitHub
siddharthteotia commented on issue #10201: URL: https://github.com/apache/pinot/issues/10201#issuecomment-1409039680 Please take a look at the discussion thread and doc in https://github.com/apache/pinot/issues/5246 -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10186: Fix bug is realtime segment completion for MV Raw columns

2023-01-30 Thread via GitHub
vvivekiyer commented on code in PR #10186: URL: https://github.com/apache/pinot/pull/10186#discussion_r1090937481 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseRealtimeClusterIntegrationTest.java: ## @@ -92,9 +92,11 @@ protected void overrideSer

[pinot] branch master updated: [multistage] add RelFieldTrimmer (#10187)

2023-01-30 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 99ceafb2ee [multistage] add RelFieldTrimmer (

[GitHub] [pinot] siddharthteotia merged pull request #10187: [multistage] add RelFieldTrimmer

2023-01-30 Thread via GitHub
siddharthteotia merged PR #10187: URL: https://github.com/apache/pinot/pull/10187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] Jackie-Jiang commented on issue #5612: Support column rename with backwards compatibility

2023-01-30 Thread via GitHub
Jackie-Jiang commented on issue #5612: URL: https://github.com/apache/pinot/issues/5612#issuecomment-1408893599 Currently pinot doesn't support column alias within the config (alias in the query is supported). One workaround is to use the ingestion transform to mirror a column. It can also

[GitHub] [pinot] codecov-commenter commented on pull request #10202: improve error message for NormalizedDateSegmentNameGenerator

2023-01-30 Thread via GitHub
codecov-commenter commented on PR #10202: URL: https://github.com/apache/pinot/pull/10202#issuecomment-1408296380 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] zhtaoxiang opened a new pull request, #10202: improve error message for NormalizedDateSegmentNameGenerator

2023-01-30 Thread via GitHub
zhtaoxiang opened a new pull request, #10202: URL: https://github.com/apache/pinot/pull/10202 When I NormalizedDateSegmentNameGenerator while ingesting data, I got the error message `Must provide date time format spec for NormalizedDateSegmentNameGenerator.`. It took me time to figure out t

[GitHub] [pinot] codecov-commenter commented on pull request #10192: [draft] Index spi: index service

2023-01-30 Thread via GitHub
codecov-commenter commented on PR #10192: URL: https://github.com/apache/pinot/pull/10192#issuecomment-1408201675 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft