vvivekiyer commented on code in PR #10186:
URL: https://github.com/apache/pinot/pull/10186#discussion_r1090937481
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseRealtimeClusterIntegrationTest.java:
##########
@@ -92,9 +92,11 @@ protected void overrideServerConf(PinotConfiguration
configuration) {
protected List<String> getNoDictionaryColumns() {
// Randomly set time column as no dictionary column.
if (new Random().nextInt(2) == 0) {
- return Arrays.asList("ActualElapsedTime", "ArrDelay", "DepDelay",
"CRSDepTime", "DaysSinceEpoch");
+ return Arrays.asList("ActualElapsedTime", "ArrDelay", "DepDelay",
"CRSDepTime", "RandomAirports",
+ "DivTotalGTimes", "DaysSinceEpoch");
} else {
- return super.getNoDictionaryColumns();
+ return Arrays.asList("ActualElapsedTime", "ArrDelay", "DepDelay",
"CRSDepTime", "RandomAirports",
Review Comment:
I tried adding it earlier. There are some tests extending
BaseClusterIntegrationTest that fail because they work only on SV columns. I'll
take this up as a separate change if that's ok?
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseRealtimeClusterIntegrationTest.java:
##########
@@ -92,9 +92,11 @@ protected void overrideServerConf(PinotConfiguration
configuration) {
protected List<String> getNoDictionaryColumns() {
// Randomly set time column as no dictionary column.
if (new Random().nextInt(2) == 0) {
- return Arrays.asList("ActualElapsedTime", "ArrDelay", "DepDelay",
"CRSDepTime", "DaysSinceEpoch");
+ return Arrays.asList("ActualElapsedTime", "ArrDelay", "DepDelay",
"CRSDepTime", "RandomAirports",
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
