[GitHub] [pinot] codecov-commenter commented on pull request #10046: bytes dictionaries don't work with variable length byte[]s

codecov-commenter commented on PR #10046: URL: https://github.com/apache/pinot/pull/10046#issuecomment-1368571305 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] richardstartin opened a new pull request, #10046: bytes dictionaries don't work with variable length byte[]s

richardstartin opened a new pull request, #10046: URL: https://github.com/apache/pinot/pull/10046 this demonstrates that bytes dictionaries can't handle variable length input, and BYTES query parameters need to be padded to `numBytesPerEntry` for lookups to work properly. If this padding is

[pinot] 01/01: bytes dictionaries don't work with variable length byte[]s

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch broken-bytesdictionary in repository https://gitbox.apache.org/repos/asf/pinot.git commit 8fc1bbf79212691c4dbd12092557a4c20bfccb2e Author: Richard Startin AuthorDate: Sun Jan 1 22:56:45 2

[pinot] branch broken-bytesdictionary updated (8ad3adb0f3 -> 8fc1bbf792)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch broken-bytesdictionary in repository https://gitbox.apache.org/repos/asf/pinot.git discard 8ad3adb0f3 bytes dictionaries don't work with variable length byte[]s new 8fc1bbf792 bytes

[pinot] branch broken-bytesdictionary created (now 8ad3adb0f3)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch broken-bytesdictionary in repository https://gitbox.apache.org/repos/asf/pinot.git at 8ad3adb0f3 bytes dictionaries don't work with variable length byte[]s This branch includes the

[pinot] 01/01: bytes dictionaries don't work with variable length byte[]s

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch broken-bytesdictionary in repository https://gitbox.apache.org/repos/asf/pinot.git commit 8ad3adb0f31179ec426ca8b77685708c398ee03e Author: Richard Startin AuthorDate: Sun Jan 1 22:56:45 2

[GitHub] [pinot] richardstartin commented on a diff in pull request #10044: push unsigned byte comparison down into ValueReader

richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1059521413 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/util/ValueReader.java: ## @@ -20,6 +20,9 @@ import java.io.Closeable; import java.math

[GitHub] [pinot] richardstartin commented on a diff in pull request #10044: push unsigned byte comparison down into ValueReader

richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1059802361 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BaseImmutableDictionary.java: ## @@ -259,8 +259,7 @@ protected int bina

[pinot] branch pushdown-comparison updated (dda4a8c8fa -> 011b086da0)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch pushdown-comparison in repository https://gitbox.apache.org/repos/asf/pinot.git from dda4a8c8fa push unsigned byte comparison down into ValueReader add 011b086da0 don't apply to

[GitHub] [pinot] bobby-richard opened a new pull request, #10045: add checkpointing support to flink connector

bobby-richard opened a new pull request, #10045: URL: https://github.com/apache/pinot/pull/10045 fixes #9997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pinot] richardstartin commented on a diff in pull request #10044: push unsigned byte comparison down into ValueReader

richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1059782099 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BaseImmutableDictionary.java: ## @@ -259,8 +259,7 @@ protected int bina

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10034: Create metadata only tarball for metadata push job

zhtaoxiang commented on code in PR #10034: URL: https://github.com/apache/pinot/pull/10034#discussion_r1059725960 ## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmentCreationMapper.java: ##

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10034: Create metadata only tarball for metadata push job

zhtaoxiang commented on code in PR #10034: URL: https://github.com/apache/pinot/pull/10034#discussion_r1059725445 ## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmentCreationMapper.java: ##