richardstartin commented on code in PR #10044: URL: https://github.com/apache/pinot/pull/10044#discussion_r1059521413
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/util/ValueReader.java: ########## @@ -20,6 +20,9 @@ import java.io.Closeable; import java.math.BigDecimal; +import java.nio.ByteBuffer; +import java.nio.ByteOrder; +import org.apache.pinot.segment.spi.memory.PinotDataBuffer; Review Comment: there might be a better place for the shared logic than a static on this interface, which would keep `PinotDataBuffer` out of this interface. I'm open to suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
