[GitHub] [pinot] codecov-commenter commented on pull request #9887: [multistage] improved task scheduling

codecov-commenter commented on PR #9887: URL: https://github.com/apache/pinot/pull/9887#issuecomment-137034 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] agavra opened a new pull request, #9887: [multistage] improved task scheduling

agavra opened a new pull request, #9887: URL: https://github.com/apache/pinot/pull/9887 This PR follows up on #9753 and supports improved task scheduling that only schedules operator chains when they have data available for them to process. **Review Guide**: 1. Look at the changes

[GitHub] [pinot] snleee commented on a diff in pull request #9884: WIP - feat: add compressed file support for ORCRecordReader

snleee commented on code in PR #9884: URL: https://github.com/apache/pinot/pull/9884#discussion_r1036648934 ## pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java: ## @@ -106,6 +110,19 @@ public void init(File dat

[GitHub] [pinot] snleee commented on a diff in pull request #9884: WIP - feat: add compressed file support for ORCRecordReader

snleee commented on code in PR #9884: URL: https://github.com/apache/pinot/pull/9884#discussion_r1036648934 ## pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java: ## @@ -106,6 +110,19 @@ public void init(File dat

[GitHub] [pinot] codecov-commenter commented on pull request #9885: Fix issues for realtime table reload

codecov-commenter commented on PR #9885: URL: https://github.com/apache/pinot/pull/9885#issuecomment-1333051752 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9885?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] Jackie-Jiang commented on pull request #9885: Fix issues for realtime table reload

Jackie-Jiang commented on PR #9885: URL: https://github.com/apache/pinot/pull/9885#issuecomment-1333022911 > would be nice if we can add some unit-test It is slightly hard to test the reload behavior in the unit test. Currently most of the reload test is done in the integration test.

[pinot] branch master updated: #9834 Added Delete Schema/Table pinot admin commands (#9857)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2dae95127d #9834 Added Delete Schema/Table pinot

[GitHub] [pinot] Jackie-Jiang closed issue #9834: Add Delete Schema/Table for pinot-admin command

Jackie-Jiang closed issue #9834: Add Delete Schema/Table for pinot-admin command URL: https://github.com/apache/pinot/issues/9834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] Jackie-Jiang merged pull request #9857: #9834 Added Delete Schema/Table pinot admin commands

Jackie-Jiang merged PR #9857: URL: https://github.com/apache/pinot/pull/9857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] walterddr opened a new pull request, #9886: [draft][multistage] Fixing NOT IT and the leaf-stage return type

walterddr opened a new pull request, #9886: URL: https://github.com/apache/pinot/pull/9886 Still a draft. This PR attempt to use LeafStageSendOperator to canonicalize mismatches in type, duplicate columns, and other nuances related to the type and schema differences between V1 and V2

[pinot] branch master updated: support BOOL_AND and BOOL_OR aggregate functions (#9848)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0a6d84391d support BOOL_AND and BOOL_OR aggregate

[GitHub] [pinot] walterddr merged pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

walterddr merged PR #9848: URL: https://github.com/apache/pinot/pull/9848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] walterddr commented on a diff in pull request #9885: Fix issues for realtime table reload

walterddr commented on code in PR #9885: URL: https://github.com/apache/pinot/pull/9885#discussion_r1036602848 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -210,40 +209,38 @@ private InstanceResponseBlock executeInternal

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #9885: Fix issues for realtime table reload

Jackie-Jiang opened a new pull request, #9885: URL: https://github.com/apache/pinot/pull/9885 Fix #9761 Fix 2 issues: 1. When loading the just committed segment, we should pull the latest table config 2. Ignore the invalid freshness value from the empty consuming segment (befor

[GitHub] [pinot] Jackie-Jiang commented on issue #9784: Query freshness lag spikes after running rebalance w/ includeConsuming=false

Jackie-Jiang commented on issue #9784: URL: https://github.com/apache/pinot/issues/9784#issuecomment-1332863780 Checked the code and confirmed the behavior: when the committed segments are moved to a different server, when that server is queried, we can only use the max end time of the comm

[GitHub] [pinot] egalpin commented on issue #7519: FILTER Clause Support

egalpin commented on issue #7519: URL: https://github.com/apache/pinot/issues/7519#issuecomment-1332857491 @atris Any update on the progress of a PR to support GROUP BY? Would be a very exciting feature to see 😊 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] etolbakov opened a new pull request, #9884: WIP - feat: add compressed file support for ORCRecordReader

etolbakov opened a new pull request, #9884: URL: https://github.com/apache/pinot/pull/9884 This is WIP on https://github.com/apache/pinot/issues/9847 The aim of this change is to support gz compressed files for `ORCRecordReader` and `ParquetAvroRecordReader` in order to achieve the featur

[GitHub] [pinot] Jackie-Jiang commented on issue #9761: [flakytest] LLCRealtimeClusterIntegrationTest.testInvertedIndexTriggering

Jackie-Jiang commented on issue #9761: URL: https://github.com/apache/pinot/issues/9761#issuecomment-1332839628 This is caused by a bug (or undesired behavior) in real-time freshness calculation: when a new consuming segment is created without consuming records from upstream, the freshness

[GitHub] [pinot] priyen closed pull request #9097: [Work in progress] Distinct count HLL pre-agg on realtime side

priyen closed pull request #9097: [Work in progress] Distinct count HLL pre-agg on realtime side URL: https://github.com/apache/pinot/pull/9097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pinot] priyen opened a new pull request, #9883: Distinct Count HLL pre-aggregation in realtime segments

priyen opened a new pull request, #9883: URL: https://github.com/apache/pinot/pull/9883 This adds support for distinct count hll pre-aggregation. It introduces a new property on the fieldSpec, fixedLength in bytes so that BYTES data type can be treated as fixed length and we can utilize the

[GitHub] [pinot] navina commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

navina commented on code in PR #9859: URL: https://github.com/apache/pinot/pull/9859#discussion_r1036471037 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java: ## @@ -156,11 +174,21 @@ public

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

zhtaoxiang commented on code in PR #9825: URL: https://github.com/apache/pinot/pull/9825#discussion_r1036364399 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java: ## @@ -2

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1036358541 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ## @@ -117,6 +135,26 @@ public void removeSegment(String segme

[GitHub] [pinot] xiangfu0 opened a new issue, #9881: Make HTTP header not use underscore

xiangfu0 opened a new issue, #9881: URL: https://github.com/apache/pinot/issues/9881 Usually it's fine, however we observed many cases that when users put pinot controller/brokers behind a nginx reverse proxy, then it will by default drop headers with underscore. For now at least we

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

Jackie-Jiang commented on code in PR #9848: URL: https://github.com/apache/pinot/pull/9848#discussion_r1036349202 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/AggregationResultHolder.java: ## @@ -30,6 +30,12 @@ public interface AggregationResultHolder {

[GitHub] [pinot] Jackie-Jiang commented on issue #9305: query with condition comparing with zero got incorrect results

Jackie-Jiang commented on issue #9305: URL: https://github.com/apache/pinot/issues/9305#issuecomment-1332611091 @huang1st Sorry I lost track of this issue. Did you find the cause of the issue? Is the `value` column always whole number in the input data? What is the rough cardinality (uni

[GitHub] [pinot] navina commented on a diff in pull request #9863: Add rate limit to Kinesis requests

navina commented on code in PR #9863: URL: https://github.com/apache/pinot/pull/9863#discussion_r1036325601 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java: ## @@ -155,6 +162,17 @@ private KinesisRec

[GitHub] [pinot] navina commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

navina commented on code in PR #9859: URL: https://github.com/apache/pinot/pull/9859#discussion_r1036323485 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java: ## @@ -156,11 +174,21 @@ public

[GitHub] [pinot] agavra opened a new pull request, #9880: enable tests with rounding errors [MINOR]

agavra opened a new pull request, #9880: URL: https://github.com/apache/pinot/pull/9880 reformat the `Aggregates.json` test and enable the tests with rounding errors, just divide by 2 to make sure the ints round to the same value. -- This is an automated message from the Apache Git Servic

[pinot] branch master updated: [multistage] support sort push-down (#9832)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 041865a80f [multistage] support sort push-down (#9

[GitHub] [pinot] walterddr merged pull request #9832: [multistage] support sort push-down

walterddr merged PR #9832: URL: https://github.com/apache/pinot/pull/9832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] snleee commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

snleee commented on code in PR #9825: URL: https://github.com/apache/pinot/pull/9825#discussion_r1036255304 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java: ## @@ -242,6

[GitHub] [pinot] Jackie-Jiang commented on issue #8094: Make it possible to read strings from `Dictionary` as `byte[]`

Jackie-Jiang commented on issue #8094: URL: https://github.com/apache/pinot/issues/8094#issuecomment-1332558930 Done with #9441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] Jackie-Jiang closed issue #8094: Make it possible to read strings from `Dictionary` as `byte[]`

Jackie-Jiang closed issue #8094: Make it possible to read strings from `Dictionary` as `byte[]` URL: https://github.com/apache/pinot/issues/8094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pinot] Jackie-Jiang closed issue #4230: NULL value support for all data types

Jackie-Jiang closed issue #4230: NULL value support for all data types URL: https://github.com/apache/pinot/issues/4230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [pinot] Jackie-Jiang closed issue #5600: Pinot 0.4 Release | Realtime table- Error in creating a segment

Jackie-Jiang closed issue #5600: Pinot 0.4 Release | Realtime table- Error in creating a segment URL: https://github.com/apache/pinot/issues/5600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] Jackie-Jiang closed issue #5388: Batch ingestion is too slow

Jackie-Jiang closed issue #5388: Batch ingestion is too slow URL: https://github.com/apache/pinot/issues/5388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [pinot] siddharthteotia commented on issue #9348: [Feature] Change forward index and dictionary properties during segment reload

siddharthteotia commented on issue #9348: URL: https://github.com/apache/pinot/issues/9348#issuecomment-1332555219 This effort is completed. For offline segments, following segment format updates can be made without having to refresh / backfill - Create dictionary and rewrite dependen

[GitHub] [pinot] siddharthteotia closed issue #9348: [Feature] Change forward index and dictionary properties during segment reload

siddharthteotia closed issue #9348: [Feature] Change forward index and dictionary properties during segment reload URL: https://github.com/apache/pinot/issues/9348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pinot] Jackie-Jiang closed issue #6726: Bump up DataTable version to address TODOs in DataTableBuilders

Jackie-Jiang closed issue #6726: Bump up DataTable version to address TODOs in DataTableBuilders URL: https://github.com/apache/pinot/issues/6726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] Jackie-Jiang commented on issue #6726: Bump up DataTable version to address TODOs in DataTableBuilders

Jackie-Jiang commented on issue #6726: URL: https://github.com/apache/pinot/issues/6726#issuecomment-1332554580 Done with #8890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pinot] dependabot[bot] commented on pull request #9878: Bump checkstyle from 8.45.1 to 10.5.0

dependabot[bot] commented on PR #9878: URL: https://github.com/apache/pinot/pull/9878#issuecomment-1332552864 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

[GitHub] [pinot] Jackie-Jiang commented on pull request #9878: Bump checkstyle from 8.45.1 to 10.5.0

Jackie-Jiang commented on PR #9878: URL: https://github.com/apache/pinot/pull/9878#issuecomment-1332552828 Close because the new dependency it is not compatible with java 8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pinot] Jackie-Jiang closed pull request #9878: Bump checkstyle from 8.45.1 to 10.5.0

Jackie-Jiang closed pull request #9878: Bump checkstyle from 8.45.1 to 10.5.0 URL: https://github.com/apache/pinot/pull/9878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] siddharthteotia commented on pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on PR #9868: URL: https://github.com/apache/pinot/pull/9868#issuecomment-1332537913 Overall looks good. @vvivekiyer tagged you on two comment threads that you may want to address in follow-ups -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1036284918 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java: ## @@ -500,6 +494,123 @@ public void testEn

[pinot] branch master updated (9bd420fc4a -> 6210f43ca0)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9bd420fc4a [multistage][hotfix] shuffle rewrite (#9870) add 6210f43ca0 Disable Dictionary (#9868) No new revi

[GitHub] [pinot] siddharthteotia merged pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia merged PR #9868: URL: https://github.com/apache/pinot/pull/9868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9868: URL: https://github.com/apache/pinot/pull/9868#discussion_r1036281464 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -258,6 +269,31 @@ Map computeOperation(S

[GitHub] [pinot] Jackie-Jiang closed issue #654: Pinot column to support no dictionary indexing

Jackie-Jiang closed issue #654: Pinot column to support no dictionary indexing URL: https://github.com/apache/pinot/issues/654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pinot] walterddr commented on pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr commented on PR #9870: URL: https://github.com/apache/pinot/pull/9870#issuecomment-1332524377 @61yao merging this first to unblock some other PRs. please let me know if anything else requires follow up. > Can we also add query option to disable shuffle if needed. So we can k

[GitHub] [pinot] walterddr merged pull request #9870: [multistage][hotfix] shuffle rewrite

walterddr merged PR #9870: URL: https://github.com/apache/pinot/pull/9870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[pinot] branch master updated: [multistage][hotfix] shuffle rewrite (#9870)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9bd420fc4a [multistage][hotfix] shuffle rewrite (#

[pinot] branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.5.0 updated (75a048451d -> e0e861b75a)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.5.0 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 75a048451d Fix violations discard 2108dc196d Bump checkstyle from 8.

[pinot] branch master updated: Bump spotless-maven-plugin from 2.9.0 to 2.28.0 (#9877)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 99d2eb84c9 Bump spotless-maven-plugin from 2.9.0

[GitHub] [pinot] Jackie-Jiang merged pull request #9877: Bump spotless-maven-plugin from 2.9.0 to 2.28.0

Jackie-Jiang merged PR #9877: URL: https://github.com/apache/pinot/pull/9877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.5.0 updated (2108dc196d -> 75a048451d)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.5.0 in repository https://gitbox.apache.org/repos/asf/pinot.git from 2108dc196d Bump checkstyle from 8.45.1 to 10.5.0 add 75a048451d

[pinot] branch master updated: Bug fix: Get correct primary key count (#9876)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 28f337a6af Bug fix: Get correct primary key count

[GitHub] [pinot] Jackie-Jiang merged pull request #9876: Bug fix: Get correct primary key count

Jackie-Jiang merged PR #9876: URL: https://github.com/apache/pinot/pull/9876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] walterddr merged pull request #9879: [multistage][test] remove json file requirement

walterddr merged PR #9879: URL: https://github.com/apache/pinot/pull/9879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[pinot] branch master updated (a22250270d -> 4198af7016)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from a22250270d [multistage] test coverage for CASE and fix bug with CHAR literals (#9846) add 4198af7016 remove json f

[GitHub] [pinot] jadami10 commented on a diff in pull request #9803: Optimize AdaptiveServerSelection for replicaGroup based routing

jadami10 commented on code in PR #9803: URL: https://github.com/apache/pinot/pull/9803#discussion_r1036226603 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/HybridSelector.java: ## @@ -85,4 +87,30 @@ public List> fetchAllServerRankingsWithS

[GitHub] [pinot] agavra commented on a diff in pull request #9832: [multistage] support sort push-down

agavra commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036210452 ## pinot-query-planner/src/test/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRuleTest.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] walterddr commented on a diff in pull request #9832: [multistage] support sort push-down

walterddr commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036208974 ## pinot-query-planner/src/test/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRuleTest.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] agavra commented on a diff in pull request #9832: [multistage] support sort push-down

agavra commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036208045 ## pinot-query-planner/src/test/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRuleTest.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] agavra commented on a diff in pull request #9832: [multistage] support sort push-down

agavra commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036206249 ## pinot-query-planner/src/test/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRuleTest.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] walterddr opened a new pull request, #9879: [multistage][test] remove json file requirement

walterddr opened a new pull request, #9879: URL: https://github.com/apache/pinot/pull/9879 remove the need for a list of JSON files. still don't support JAR unpack and assume resources are files. but that's good enough for now -- This is an automated message from the Apache Git Service. T

[GitHub] [pinot] walterddr commented on a diff in pull request #9832: [multistage] support sort push-down

walterddr commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036177859 ## pinot-query-planner/src/test/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRuleTest.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] walterddr commented on a diff in pull request #9832: [multistage] support sort push-down

walterddr commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036173291 ## pinot-query-planner/src/test/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRuleTest.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] walterddr commented on a diff in pull request #9832: [multistage] support sort push-down

walterddr commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036169120 ## pinot-query-planner/src/test/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRuleTest.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] walterddr commented on a diff in pull request #9832: [multistage] support sort push-down

walterddr commented on code in PR #9832: URL: https://github.com/apache/pinot/pull/9832#discussion_r1036156995 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRule.java: ## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] [pinot] walterddr commented on a diff in pull request #9571: [multi-stage] allow configurable timeout

walterddr commented on code in PR #9571: URL: https://github.com/apache/pinot/pull/9571#discussion_r1036123561 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java: ## @@ -22,20 +22,43 @@ * Configuration for setting up query runtime. */ publi

[GitHub] [pinot] mathieudruart commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

mathieudruart commented on code in PR #9859: URL: https://github.com/apache/pinot/pull/9859#discussion_r1036065677 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java: ## @@ -156,11 +174,21 @@

[GitHub] [pinot] KKcorps commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

KKcorps commented on code in PR #9825: URL: https://github.com/apache/pinot/pull/9825#discussion_r1036053646 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java: ## @@ -276,

[GitHub] [pinot] KKcorps commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

KKcorps commented on code in PR #9825: URL: https://github.com/apache/pinot/pull/9825#discussion_r1036047120 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPushUtils.java: ## @@ -97,6 +97,49 @@ public static URI generateSegmentTarURI(URI dirURI,

[GitHub] [pinot] KKcorps commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

KKcorps commented on code in PR #9825: URL: https://github.com/apache/pinot/pull/9825#discussion_r1036047120 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPushUtils.java: ## @@ -97,6 +97,49 @@ public static URI generateSegmentTarURI(URI dirURI,

[GitHub] [pinot] KKcorps commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

KKcorps commented on code in PR #9825: URL: https://github.com/apache/pinot/pull/9825#discussion_r1036044210 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java: ## @@ -67,7 +72,35 @@ static Pinot

[GitHub] [pinot] KKcorps commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

KKcorps commented on code in PR #9859: URL: https://github.com/apache/pinot/pull/9859#discussion_r1035942175 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java: ## @@ -156,11 +174,21 @@ publi

[GitHub] [pinot] KKcorps commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

KKcorps commented on code in PR #9859: URL: https://github.com/apache/pinot/pull/9859#discussion_r1035941781 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java: ## @@ -156,11 +174,21 @@ publi

[GitHub] [pinot] codecov-commenter commented on pull request #9877: Bump spotless-maven-plugin from 2.9.0 to 2.28.0

codecov-commenter commented on PR #9877: URL: https://github.com/apache/pinot/pull/9877#issuecomment-1332028603 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9877?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[pinot] branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.5.0 created (now 2108dc196d)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.5.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 2108dc196d Bump checkstyle from 8.45.1 to 10.5.0 No new revision

[GitHub] [pinot] dependabot[bot] opened a new pull request, #9878: Bump checkstyle from 8.45.1 to 10.5.0

dependabot[bot] opened a new pull request, #9878: URL: https://github.com/apache/pinot/pull/9878 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.45.1 to 10.5.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases

[pinot] branch dependabot/maven/com.diffplug.spotless-spotless-maven-plugin-2.28.0 created (now 48b0b1d125)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.diffplug.spotless-spotless-maven-plugin-2.28.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 48b0b1d125 Bump spotless-maven-plugin from 2.9.0 to 2

[GitHub] [pinot] dependabot[bot] opened a new pull request, #9877: Bump spotless-maven-plugin from 2.9.0 to 2.28.0

dependabot[bot] opened a new pull request, #9877: URL: https://github.com/apache/pinot/pull/9877 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.9.0 to 2.28.0. Changelog Sourced from https://github.com/diffplug/spotless/blob/main/CHANGES.md";>spotless-mav

[GitHub] [pinot] codecov-commenter commented on pull request #9875: Update cardinality when converting raw column to dict based

codecov-commenter commented on PR #9875: URL: https://github.com/apache/pinot/pull/9875#issuecomment-1331817358 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9875?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] ankitsultana commented on a diff in pull request #9873: [multistage] Add Pluggable Physical Optimizers + Greedy Shuffle Skip Optimizer

ankitsultana commented on code in PR #9873: URL: https://github.com/apache/pinot/pull/9873#discussion_r1035655511 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/SmartShuffleRewriteVisitor.java: ## @@ -0,0 +1,468 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] ankitsultana commented on a diff in pull request #9873: [Draft] [multistage] PoC for Shuffle Skip Algorithm

ankitsultana commented on code in PR #9873: URL: https://github.com/apache/pinot/pull/9873#discussion_r1035642443 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java: ## @@ -98,6 +98,10 @@ protected List queryRunner(String sql) { prote

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

zhtaoxiang commented on code in PR #9825: URL: https://github.com/apache/pinot/pull/9825#discussion_r1035630266 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPushUtils.java: ## @@ -97,6 +97,49 @@ public static URI generateSegmentTarURI(URI dirU