[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011238308 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java: ## @@ -64,4 +71,50 @@ public static boolean isFstTypeNative

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011238148 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java: ## @@ -64,4 +71,50 @@ public static boolean isFstTypeNative

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011233715 ## pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java: ## @@ -1864,6 +1878,26 @@ public void testInterSegment() { query = "SELECT c

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011230919 ## pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java: ## @@ -1864,6 +1878,26 @@ public void testInterSegment() { query = "SELECT c

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011229923 ## pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java: ## @@ -1864,6 +1878,26 @@ public void testInterSegment() { query = "SELECT c

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011227863 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java: ## @@ -64,4 +71,50 @@ public static boolean isFstTypeNative

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9708: Customize stopword for Lucene Index

jasperjiaguo commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011183270 ## pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java: ## @@ -1864,6 +1878,14 @@ public void testInterSegment() { query = "SELECT coun

[GitHub] [pinot] KKcorps commented on pull request #9681: Close Filesystem on exit with Minion Tasks

KKcorps commented on PR #9681: URL: https://github.com/apache/pinot/pull/9681#issuecomment-1299546146 @walterddr that is out of the scope for this. In minion tasks, user provided FS configs take priority over cached FS. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011097757 ## pinot-core/src/test/resources/data/text_search_data/skills.txt: ## @@ -21,4 +21,7 @@ C++, Java, Python, realtime streaming systems, Machine learning, spark, K

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011096425 ## pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java: ## @@ -1864,6 +1878,14 @@ public void testInterSegment() { query = "SELECT c

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9708: Customize stopword for Lucene Index

siddharthteotia commented on code in PR #9708: URL: https://github.com/apache/pinot/pull/9708#discussion_r1011096425 ## pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java: ## @@ -1864,6 +1878,14 @@ public void testInterSegment() { query = "SELECT c

[GitHub] [pinot] codecov-commenter commented on pull request #9708: Customize stopword for Lucene Index

codecov-commenter commented on PR #9708: URL: https://github.com/apache/pinot/pull/9708#issuecomment-1299478437 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[pinot] branch master updated (e4ee05355c -> a5413962ab)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from e4ee05355c fix PinotVersion to be compatible with prometheus (#9701) add a5413962ab Fix the setup for ControllerTe

[GitHub] [pinot] Jackie-Jiang merged pull request #9704: Fix the setup for ControllerTest shared cluster

Jackie-Jiang merged PR #9704: URL: https://github.com/apache/pinot/pull/9704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011078687 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -92,10 +112,14 @@ public void updateIndic

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011073256 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -104,8 +104,15 @@ public void process()

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011068710 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +304,295 @@ private void rewrite

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011061918 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +304,295 @@ private void rewrite

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011047656 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +304,295 @@ private void rewrite

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011046909 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +304,295 @@ private void rewrite

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011043808 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +304,295 @@ private void rewrite

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011043306 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +304,295 @@ private void rewrite

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011041747 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -127,7 +151,15 @@ Map computeOperation(S

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011038492 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -387,7 +464,7 @@ public void testComp

[GitHub] [pinot] siddharthteotia commented on pull request #9678: Support creating dictionary at runtime for an existing column

siddharthteotia commented on PR #9678: URL: https://github.com/apache/pinot/pull/9678#issuecomment-1299407339 Let's add e2e query execution tests as well (need not be in integration but one of the subclasses of BaseQueriesTest) -- This is an automated message from the Apache Git Service.

[GitHub] [pinot] jasperjiaguo opened a new pull request, #9708: Customize stopword for Lucene Index

jasperjiaguo opened a new pull request, #9708: URL: https://github.com/apache/pinot/pull/9708 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

[GitHub] [pinot] codecov-commenter commented on pull request #9707: initial commit to support all scalar/transform/filter match

codecov-commenter commented on PR #9707: URL: https://github.com/apache/pinot/pull/9707#issuecomment-1299385769 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9707?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011013773 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -26,23 +26,43 @@ import java.util.HashSet; i

[GitHub] [pinot] walterddr commented on pull request #9681: Close Filesystem on exit with Minion Tasks

walterddr commented on PR #9681: URL: https://github.com/apache/pinot/pull/9681#issuecomment-1299373327 another thought since we are talking about how to map fsClassName to pinotFS. should we also address the fact that users might have different `fsConfiguration` for the same `fsCla

[GitHub] [pinot] walterddr commented on a diff in pull request #9693: [multi-stage] [cleanup] Clean up PinotOperatorTable

walterddr commented on code in PR #9693: URL: https://github.com/apache/pinot/pull/9693#discussion_r1011010698 ## pinot-query-planner/src/main/java/org/apache/calcite/sql/fun/PinotOperatorTable.java: ## @@ -87,13 +86,6 @@ public final void initNoDuplicate() { } } - pr

[pinot] branch master updated: fix PinotVersion to be compatible with prometheus (#9701)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e4ee05355c fix PinotVersion to be compatible with

[GitHub] [pinot] walterddr merged pull request #9701: fix PinotVersion to be compatible with prometheus

walterddr merged PR #9701: URL: https://github.com/apache/pinot/pull/9701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011006549 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -26,23 +26,43 @@ import java.util.HashSet; i

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011009045 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -302,34 +351,54 @@ public void testCompute

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011007524 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +306,293 @@ private void rewriteRawSV

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011007394 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +306,293 @@ private void rewriteRawSV

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011007064 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +306,293 @@ private void rewriteRawSV

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011006867 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +306,293 @@ private void rewriteRawSV

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011006727 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -244,16 +279,16 @@ private void rewriteRawMVFo

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

vvivekiyer commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1011006485 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java: ## @@ -416,15 +416,11 @@ void buildIndexC

[GitHub] [pinot] codecov-commenter commented on pull request #9702: [multistage][bugfix] fix case-when issue

codecov-commenter commented on PR #9702: URL: https://github.com/apache/pinot/pull/9702#issuecomment-1299343165 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9702?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] somandal commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

somandal commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1010667763 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -302,34 +351,54 @@ public void testComputeOp

[GitHub] [pinot] codecov-commenter commented on pull request #9705: Allow to configure multi-datadirs as instance configs and a Quickstart example about them

codecov-commenter commented on PR #9705: URL: https://github.com/apache/pinot/pull/9705#issuecomment-1299323345 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[pinot] branch master updated (85ee94f004 -> 694999cbd0)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 85ee94f004 Make PinotHelixResourceManager test run on a standalone cluster (#9703) add 694999cbd0 [Clean up] Auto

[GitHub] [pinot] Jackie-Jiang merged pull request #9706: [Clean up] Auto reformat controller tests

Jackie-Jiang merged PR #9706: URL: https://github.com/apache/pinot/pull/9706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated (7a93045768 -> 85ee94f004)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7a93045768 AdaptiveServerSelection: Fix timer (#9697) add 85ee94f004 Make PinotHelixResourceManager test run on a

[GitHub] [pinot] Jackie-Jiang merged pull request #9703: Make PinotHelixResourceManager test run on a standalone cluster

Jackie-Jiang merged PR #9703: URL: https://github.com/apache/pinot/pull/9703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] codecov-commenter commented on pull request #9704: Fix the setup for ControllerTest shared cluster

codecov-commenter commented on PR #9704: URL: https://github.com/apache/pinot/pull/9704#issuecomment-1299301116 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9704?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr opened a new pull request, #9707: initial commit to support all scalar/transform/filter match

walterddr opened a new pull request, #9707: URL: https://github.com/apache/pinot/pull/9707 - create placeholder function if those can be implemented in the future - ignore ones that don't make sense post transform - rewrite some aliases so that they can be understood by V2 engine as wel

[GitHub] [pinot] klsince opened a new pull request, #9705: Quickstart example for multi-datadirs support on server

klsince opened a new pull request, #9705: URL: https://github.com/apache/pinot/pull/9705 This PR is part of the work to support multi-datadir for Pinot server as tracked by https://github.com/apache/pinot/issues/8843. This one makes it simpler to config the feature, and adds a QuickS

[pinot] branch master updated (dcc496f63b -> 7a93045768)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from dcc496f63b Add record availability lag for Kafka connector (#9621) add 7a93045768 AdaptiveServerSelection: Fix

[GitHub] [pinot] siddharthteotia merged pull request #9697: AdaptiveServerSelection: Fix timer

siddharthteotia merged PR #9697: URL: https://github.com/apache/pinot/pull/9697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] Jackie-Jiang commented on pull request #9696: Fix the setup for ControllerTest and make ResourceManagerTest standalone

Jackie-Jiang commented on PR #9696: URL: https://github.com/apache/pinot/pull/9696#issuecomment-1299210759 Break into #9703 and #9704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #9704: Fix the setup for ControllerTest shared cluster

Jackie-Jiang opened a new pull request, #9704: URL: https://github.com/apache/pinot/pull/9704 Currently the ControllerTest shared cluster setup mixes the single tenant and multi-tenant setup, which can cause unexpected behavior and is hard to debug -- This is an automated message from the

[GitHub] [pinot] dmyang commented on a diff in pull request #9697: AdaptiveServerSelection: Fix timer

dmyang commented on code in PR #9697: URL: https://github.com/apache/pinot/pull/9697#discussion_r1010913789 ## pinot-core/src/main/java/org/apache/pinot/core/transport/server/routing/stats/ServerRoutingStatsManager.java: ## @@ -47,8 +48,13 @@ public class ServerRoutingStatsManag

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9697: AdaptiveServerSelection: Fix timer

vvivekiyer commented on code in PR #9697: URL: https://github.com/apache/pinot/pull/9697#discussion_r1010909353 ## pinot-core/src/main/java/org/apache/pinot/core/transport/server/routing/stats/ServerRoutingStatsManager.java: ## @@ -47,8 +48,13 @@ public class ServerRoutingStatsM

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9697: AdaptiveServerSelection: Fix timer

vvivekiyer commented on code in PR #9697: URL: https://github.com/apache/pinot/pull/9697#discussion_r1010909353 ## pinot-core/src/main/java/org/apache/pinot/core/transport/server/routing/stats/ServerRoutingStatsManager.java: ## @@ -47,8 +48,13 @@ public class ServerRoutingStatsM

[pinot] branch master updated: Add record availability lag for Kafka connector (#9621)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new dcc496f63b Add record availability lag for Kafka

[GitHub] [pinot] Jackie-Jiang merged pull request #9621: Add record availability lag for Kafka connector

Jackie-Jiang merged PR #9621: URL: https://github.com/apache/pinot/pull/9621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #9703: Make PinotHelixResourceManager test run on a standalone cluster

Jackie-Jiang opened a new pull request, #9703: URL: https://github.com/apache/pinot/pull/9703 Related to #9651 Refactor `PinotHelixResourceManagerStatelessTest` to include all the tests for `PinotHelixResourceManager`, which uses multi-tenant setup -- This is an automated message

[GitHub] [pinot] Jackie-Jiang closed pull request #9696: Fix the setup for ControllerTest and make ResourceManagerTest standalone

Jackie-Jiang closed pull request #9696: Fix the setup for ControllerTest and make ResourceManagerTest standalone URL: https://github.com/apache/pinot/pull/9696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] Jackie-Jiang commented on pull request #9696: Fix the setup for ControllerTest and make ResourceManagerTest standalone

Jackie-Jiang commented on PR #9696: URL: https://github.com/apache/pinot/pull/9696#issuecomment-1299172594 This PR contains 2 parts of the changes: Refactor `PinotHelixResourceManagerTest` to use a standalone cluster; Fix the setup for ControllerTest. Closing this one and create 2 separate

[GitHub] [pinot] dmyang commented on a diff in pull request #9697: AdaptiveServerSelection: Fix timer

dmyang commented on code in PR #9697: URL: https://github.com/apache/pinot/pull/9697#discussion_r1010890179 ## pinot-core/src/main/java/org/apache/pinot/core/transport/server/routing/stats/ServerRoutingStatsManager.java: ## @@ -47,8 +48,13 @@ public class ServerRoutingStatsManag

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9701: fix PinotVersion to be compatible with prometheus

Jackie-Jiang commented on code in PR #9701: URL: https://github.com/apache/pinot/pull/9701#discussion_r1010849620 ## pinot-common/src/main/java/org/apache/pinot/common/version/PinotVersion.java: ## @@ -45,6 +45,16 @@ private PinotVersion() { // private constructor for utili

[GitHub] [pinot] Jackie-Jiang commented on pull request #9681: Close Filesystem on exit with Minion Tasks

Jackie-Jiang commented on PR #9681: URL: https://github.com/apache/pinot/pull/9681#issuecomment-1298980906 > I can do that. But then, the question is what should one do if no FS configs are mentioned in the task config. Currently we get the FS from cache which uses minion FS configs.

[GitHub] [pinot] walterddr commented on a diff in pull request #9702: [multistage][bugfix] fix case-when issue

walterddr commented on code in PR #9702: URL: https://github.com/apache/pinot/pull/9702#discussion_r1010755913 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java: ## @@ -717,15 +718,16 @@ private static Expression toExpression(SqlNode node) {

[GitHub] [pinot] walterddr opened a new pull request, #9702: [multistage][bugfix] fix case-when issue

walterddr opened a new pull request, #9702: URL: https://github.com/apache/pinot/pull/9702 case when is not parsed the same in SqlNode and RelNode. this address the discrepancy in the compilation between v1 and v2. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] codecov-commenter commented on pull request #9701: fix PinotVersion to be compatible with prometheus

codecov-commenter commented on PR #9701: URL: https://github.com/apache/pinot/pull/9701#issuecomment-1298896783 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9701?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] amrishlal commented on pull request #9669: [Work In Progress] Avoid setting result column types to STRING when resultset is empty.

amrishlal commented on PR #9669: URL: https://github.com/apache/pinot/pull/9669#issuecomment-1298876212 @Jackie-Jiang @siddharthteotia Things are now setup so that a query will always run against at least one segment and this will allow for properly setting result metadata column names and

[GitHub] [pinot] somandal commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

somandal commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1010661628 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -271,118 +306,293 @@ private void rewriteRawSVFo

[GitHub] [pinot] somandal commented on a diff in pull request #9678: Support creating dictionary at runtime for an existing column

somandal commented on code in PR #9678: URL: https://github.com/apache/pinot/pull/9678#discussion_r1010639412 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java: ## @@ -416,15 +416,11 @@ void buildIndexCre

[GitHub] [pinot] vvivekiyer commented on pull request #9697: AdaptiveServerSelection: Fix timer

vvivekiyer commented on PR #9697: URL: https://github.com/apache/pinot/pull/9697#issuecomment-1298800876 @dmyang please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pinot] agavra opened a new pull request, #9701: fix PinotVersion to be compatible with prometheus

agavra opened a new pull request, #9701: URL: https://github.com/apache/pinot/pull/9701 I introduced the JMX bean for pinot version in #9578 but didn't realize that prometheus won't export metric names/labels that have `.` in them. This changes this so that the version replaces all `.` and

[GitHub] [pinot] codecov-commenter commented on pull request #9700: WIP UI: show segment debug details when segment is in bad state

codecov-commenter commented on PR #9700: URL: https://github.com/apache/pinot/pull/9700#issuecomment-1298739839 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9700?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] jayeshchoudhary commented on pull request #9700: WIP UI: show segment debug details when segment is in bad state

jayeshchoudhary commented on PR #9700: URL: https://github.com/apache/pinot/pull/9700#issuecomment-1298698637 cc - @npawar @mayankshriv @saurabhd336 @joshigaurava -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pinot] jayeshchoudhary commented on pull request #9699: UI: re-define the segment status

jayeshchoudhary commented on PR #9699: URL: https://github.com/apache/pinot/pull/9699#issuecomment-1298635232 @npawar @joshigaurava @saurabhd336 @mayankshriv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pinot] walterddr closed pull request #9682: batch 1 of transform/scalar function match

walterddr closed pull request #9682: batch 1 of transform/scalar function match URL: https://github.com/apache/pinot/pull/9682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pinot] KKcorps commented on pull request #9681: Close Filesystem on exit with Minion Tasks

KKcorps commented on PR #9681: URL: https://github.com/apache/pinot/pull/9681#issuecomment-1298544251 I can do that. But then, the question is what should one do if no FS configs are mentioned in the task config. Currently we get the FS from cache which uses minion FS configs. -- This is

[GitHub] [pinot] bdstuart opened a new issue, #9698: RealtimeToOfflineSegmentsTask fails if the OFFLINE table has a Timestamp Index

bdstuart opened a new issue, #9698: URL: https://github.com/apache/pinot/issues/9698 -- RealtimeToOfflineSegmentTask config "task": { "taskTypeConfigsMap": { "RealtimeToOfflineSegmentsTask": { "bucketTimePeriod": "1d", "bufferTimePeriod": "1d",

[GitHub] [pinot] 61yao commented on pull request #9682: batch 1 of transform/scalar function match

61yao commented on PR #9682: URL: https://github.com/apache/pinot/pull/9682#issuecomment-1298177648 This PR is intended to put the calcite function name in scalar functions we already support? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pinot] antwigambrah commented on a diff in pull request #9662: Table rebalance status

antwigambrah commented on code in PR #9662: URL: https://github.com/apache/pinot/pull/9662#discussion_r1010173249 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -383,6 +383,23 @@ public RebalanceResult rebalance(Tab