walterddr commented on code in PR #9693:
URL: https://github.com/apache/pinot/pull/9693#discussion_r1011010698
##########
pinot-query-planner/src/main/java/org/apache/calcite/sql/fun/PinotOperatorTable.java:
##########
@@ -87,13 +86,6 @@ public final void initNoDuplicate() {
}
}
- private boolean notRegistered(SqlFunction op) {
- List<SqlOperator> operatorList = new ArrayList<>();
- lookupOperatorOverloads(op.getNameAsId(), op.getFunctionType(),
op.getSyntax(), operatorList,
- SqlNameMatchers.withCaseSensitive(false));
- return operatorList.size() == 0;
- }
Review Comment:
no please do not remove this registration check. passing
`op.getFunctionType()` is not the same as passing directly `null`
it is being ignored by calcite right now but it is not guarantee not to be
used in the future. deviating from calcite behavior could cause debuggability
issues in the future (as we are basically overriding a behavior on our own)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
