[GitHub] [pinot] navina commented on a diff in pull request #9515: Exposing consumer's record lag in /consumingSegmentsInfo

2022-10-09 Thread GitBox
navina commented on code in PR #9515: URL: https://github.com/apache/pinot/pull/9515#discussion_r990923539 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java: ## @@ -205,15 +205,19 @@ static public class ConsumingSegmentInfo {

[GitHub] [pinot] navina commented on a diff in pull request #9515: Exposing consumer's record lag in /consumingSegmentsInfo

2022-10-09 Thread GitBox
navina commented on code in PR #9515: URL: https://github.com/apache/pinot/pull/9515#discussion_r990922956 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java: ## @@ -134,6 +150,35 @@ public Response getConsumptionStatus(

[GitHub] [pinot] navina commented on pull request #9544: Make StreamMessage generic and a bug fix

2022-10-09 Thread GitBox
navina commented on PR #9544: URL: https://github.com/apache/pinot/pull/9544#issuecomment-1272803951 @vvivekiyer Not sure how much value a discussion can offer if the PR has already been merged. But here is my take on this: > MessageBatch is a generic interface because users of Pinot

[GitHub] [pinot] codecov-commenter commented on pull request #9511: Handle exception in realtime decoder gracefully

2022-10-09 Thread GitBox
codecov-commenter commented on PR #9511: URL: https://github.com/apache/pinot/pull/9511#issuecomment-1272770369 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9511?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] KKcorps commented on a diff in pull request #9511: Handle exception in realtime decoder gracefully

2022-10-09 Thread GitBox
KKcorps commented on code in PR #9511: URL: https://github.com/apache/pinot/pull/9511#discussion_r990903032 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java: ## @@ -51,6 +51,10 @@ public class IngestionConfig extends BaseJsonConfig {

[GitHub] [pinot] KKcorps commented on a diff in pull request #9511: Handle exception in realtime decoder gracefully

2022-10-09 Thread GitBox
KKcorps commented on code in PR #9511: URL: https://github.com/apache/pinot/pull/9511#discussion_r990903032 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java: ## @@ -51,6 +51,10 @@ public class IngestionConfig extends BaseJsonConfig {

[GitHub] [pinot] liyujiel commented on issue #9284: Pinot quickstart issue with "Load data into Kafka and create Pinot schema/tables"

2022-10-09 Thread GitBox
liyujiel commented on issue #9284: URL: https://github.com/apache/pinot/issues/9284#issuecomment-1272742458 I believe https://github.com/apache/pinot/pull/9562 can fix this issue :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pinot] liyujiel commented on pull request #9562: bugfix: quick start on docker and kubernetes avro file path issue

2022-10-09 Thread GitBox
liyujiel commented on PR #9562: URL: https://github.com/apache/pinot/pull/9562#issuecomment-1272733554 @xiangfu0 I realize there are several places that still use `release-0.7.1`, do you want me to change all of them to `release-0.11.0`? -- This is an automated message from the Apache Git

[GitHub] [pinot] codecov-commenter commented on pull request #9562: bugfix: quick start on docker and kubernetes avro file path issue

2022-10-09 Thread GitBox
codecov-commenter commented on PR #9562: URL: https://github.com/apache/pinot/pull/9562#issuecomment-1272654689 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #9562: bugfix: quick start on docker and kubernetes avro file path issue

2022-10-09 Thread GitBox
xiangfu0 commented on code in PR #9562: URL: https://github.com/apache/pinot/pull/9562#discussion_r990852372 ## docker/images/pinot/README.md: ## @@ -163,7 +163,7 @@ docker run --network=pinot_default apachepinot/pinot:release-0.7.1 AddTable -sch Below is the script to inges

[pinot] branch master updated: Make StreamMessage generic (#9544)

2022-10-09 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0d69ae1157 Make StreamMessage generic (#9544) 0d6

[GitHub] [pinot] sajjad-moradi merged pull request #9544: Make StreamMessage generic and a bug fix

2022-10-09 Thread GitBox
sajjad-moradi merged PR #9544: URL: https://github.com/apache/pinot/pull/9544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

[GitHub] [pinot] sajjad-moradi commented on pull request #9544: Make StreamMessage generic and a bug fix

2022-10-09 Thread GitBox
sajjad-moradi commented on PR #9544: URL: https://github.com/apache/pinot/pull/9544#issuecomment-1272619992 I'm merging this PR as the issue it fixes has broken LinkedIn's build. As Vivek mentioned, we can discuss short term & long term fixes if needed. -- This is an automated message fro

[GitHub] [pinot] walterddr commented on pull request #9479: Refactor and allow InstanceResponseBlock to delay generate DataTable

2022-10-09 Thread GitBox
walterddr commented on PR #9479: URL: https://github.com/apache/pinot/pull/9479#issuecomment-1272603681 close in favor of #9561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pinot] walterddr closed pull request #9479: Refactor and allow InstanceResponseBlock to delay generate DataTable

2022-10-09 Thread GitBox
walterddr closed pull request #9479: Refactor and allow InstanceResponseBlock to delay generate DataTable URL: https://github.com/apache/pinot/pull/9479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] walterddr commented on a diff in pull request #9561: [Refactor] Return InstanceResponseBlock in QueryExecutor

2022-10-09 Thread GitBox
walterddr commented on code in PR #9561: URL: https://github.com/apache/pinot/pull/9561#discussion_r990822348 ## pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/InstanceResponseBlock.java: ## @@ -18,26 +18,132 @@ */ package org.apache.pinot.core.operator.blocks

[pinot] branch master updated: add array element at function (#9554)

2022-10-09 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new fd95f75d3e add array element at function (#9554) f

[GitHub] [pinot] walterddr commented on a diff in pull request #9554: add array element at function

2022-10-09 Thread GitBox
walterddr commented on code in PR #9554: URL: https://github.com/apache/pinot/pull/9554#discussion_r990818168 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java: ## @@ -151,4 +151,29 @@ public static double[] arrayConcatDouble(double[] valu

[GitHub] [pinot] walterddr merged pull request #9554: add array element at function

2022-10-09 Thread GitBox
walterddr merged PR #9554: URL: https://github.com/apache/pinot/pull/9554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] liyujiel opened a new pull request, #9562: bugfix: quick start on docker and kubernetes test file path issue

2022-10-09 Thread GitBox
liyujiel opened a new pull request, #9562: URL: https://github.com/apache/pinot/pull/9562 Signed-off-by: Yujie Li bugfix for docker and Kubernetes quick start. With the wrong path it will fail to start the load data job with the error: ``` k logs pinot-realtime-quick