navina commented on code in PR #9515:
URL: https://github.com/apache/pinot/pull/9515#discussion_r990923539
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java:
##########
@@ -205,15 +205,19 @@ static public class ConsumingSegmentInfo {
public long _lastConsumedTimestamp;
@JsonProperty("partitionToOffsetMap")
public Map<String, String> _partitionToOffsetMap;
+ @JsonProperty("partitionToOffsetLagMap")
+ public Map<String, String> _partitionToOffsetLagMap;
Review Comment:
> it would be helpful here to also return the upstreamLatestOffset. Just
offset lag might sometimes not be too indicative given they might not be
contiguous?
Sure. Makes sense.
> Another thought, instead of so many partitionTo* maps now, we could also
have a Map<String, ConsumingSegmentInfoReader.PartitionOffsetInfo>
_partitionToOffsetInfo where this value object could hold current consumer
offset, latest stream offset, and lag
I tried doing this ☝️ Then, I ran into some json serializer error that I
couldn't figure out. Let me give it another try. If I get stuck, I will paste
the error and we can work through it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
