[GitHub] [pinot] ankitsultana commented on a diff in pull request #8989: Part-1: Add Table Group Ingestion

2022-07-24 Thread GitBox
ankitsultana commented on code in PR #8989: URL: https://github.com/apache/pinot/pull/8989#discussion_r928346232 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -881,6 +884,18 @@ private static void validateFieldConfigList(@

[GitHub] [pinot] ankitsultana commented on a diff in pull request #8989: Part-1: Add Table Group Ingestion

2022-07-24 Thread GitBox
ankitsultana commented on code in PR #8989: URL: https://github.com/apache/pinot/pull/8989#discussion_r928345833 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignmentUtils.java: ## @@ -135,6 +135,18 @@ public static List a

[GitHub] [pinot] ddcprg commented on issue #9091: LL Realtime ingestion may drop messages if the segment time threshold is crossed

2022-07-24 Thread GitBox
ddcprg commented on issue #9091: URL: https://github.com/apache/pinot/issues/9091#issuecomment-1193372380 @Jackie-Jiang @richardstartin I've pushed a fix, you can look at it in the draft PR. I've still not made it proper PR because I want to make sure this makes sense for kinesis an other p

[GitHub] [pinot] mcvsubbu commented on a diff in pull request #8907: Log Request header for Broker

2022-07-24 Thread GitBox
mcvsubbu commented on code in PR #8907: URL: https://github.com/apache/pinot/pull/8907#discussion_r928277903 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -658,9 +661,34 @@ private boolean isFilterAlwaysTrue(PinotQuery

[GitHub] [pinot] mcvsubbu commented on a diff in pull request #8907: Log Request header for Broker

2022-07-24 Thread GitBox
mcvsubbu commented on code in PR #8907: URL: https://github.com/apache/pinot/pull/8907#discussion_r928277796 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -658,9 +661,34 @@ private boolean isFilterAlwaysTrue(PinotQuery

[pinot] branch master updated: Handle unknown magic byte error in Confluent Avro decoder (#9045) (#9051)

2022-07-24 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new bbec0a8070 Handle unknown magic byte error in C

[GitHub] [pinot] mcvsubbu merged pull request #9051: Handle unknown magic byte error in Confluent Avro decoder (#9045)

2022-07-24 Thread GitBox
mcvsubbu merged PR #9051: URL: https://github.com/apache/pinot/pull/9051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] ddcprg commented on pull request #9051: Handle unknown magic byte error in Confluent Avro decoder (#9045)

2022-07-24 Thread GitBox
ddcprg commented on PR #9051: URL: https://github.com/apache/pinot/pull/9051#issuecomment-1193330026 @mcvsubbu @Jackie-Jiang all green now but I still can't merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL