[pinot] branch master updated: add project/transform operator to multistage engine (#8967)

2022-06-30 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d4a64e3853 add project/transform operator to

[GitHub] [pinot] siddharthteotia merged pull request #8967: add project/transform operator to multistage engine

2022-06-30 Thread GitBox
siddharthteotia merged PR #8967: URL: https://github.com/apache/pinot/pull/8967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #9006: Add Segment Lineage List API #9005

2022-06-30 Thread GitBox
sajjad-moradi commented on code in PR #9006: URL: https://github.com/apache/pinot/pull/9006#discussion_r911522746 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java: ## @@ -652,6 +652,29 @@ public Response e

[GitHub] [pinot] jtao15 commented on pull request #9006: Add Segment Lineage List API #9005

2022-06-30 Thread GitBox
jtao15 commented on PR #9006: URL: https://github.com/apache/pinot/pull/9006#issuecomment-1171778972 Looks like it only returns the lineage entry Ids, can we return the actual entries as well? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pinot] yuanbenson1772 opened a new pull request, #9006: Add Segment Lineage List API #9005

2022-06-30 Thread GitBox
yuanbenson1772 opened a new pull request, #9006: URL: https://github.com/apache/pinot/pull/9006 Currently, there is no easy way to access segment lineage entries. Adding `listSegmentLineage` Rest API on the controller for users to retrieve such IDs. No tests added yet as core implemen

[GitHub] [pinot] codecov-commenter commented on pull request #9004: Part 3 - Rename valueType to storedType in ForwardIndexReader

2022-06-30 Thread GitBox
codecov-commenter commented on PR #9004: URL: https://github.com/apache/pinot/pull/9004#issuecomment-1171768045 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9004?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] yuanbenson1772 opened a new issue, #9005: Add Segment Lineage List API

2022-06-30 Thread GitBox
yuanbenson1772 opened a new issue, #9005: URL: https://github.com/apache/pinot/issues/9005 Adding segment lineage list API on the controller for users to retrieve IDs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[pinot] branch master updated: Add data schema to stage nodes (#8985)

2022-06-30 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d86d4abc63 Add data schema to stage nodes (#8

[GitHub] [pinot] siddharthteotia merged pull request #8985: Add data schema to stage nodes

2022-06-30 Thread GitBox
siddharthteotia merged PR #8985: URL: https://github.com/apache/pinot/pull/8985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] somandal opened a new pull request, #9004: Part 3 - Rename valueType to storedType in ForwardIndexReader

2022-06-30 Thread GitBox
somandal opened a new pull request, #9004: URL: https://github.com/apache/pinot/pull/9004 This part 3 of a multi-part set of changes to add support for multi-value noDict column types for immutable and mutable fixed width columns. Support to create segments with multi-value columns with dic

[GitHub] [pinot] zhtaoxiang closed pull request #9002: remove duplicated server queries metric report

2022-06-30 Thread GitBox
zhtaoxiang closed pull request #9002: remove duplicated server queries metric report URL: https://github.com/apache/pinot/pull/9002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] snleee opened a new issue, #9003: Segment download on the server side can be incomplete

2022-06-30 Thread GitBox
snleee opened a new issue, #9003: URL: https://github.com/apache/pinot/issues/9003 ``` // First attempt via segment upload (FAILED due to 2022/06/30 01:17:37.045 INFO [BaseTableDataManager] Download segment: xxx of table: sales_seat_metrics_additive_OFFLINE as crc changes from: 822932

[GitHub] [pinot] codecov-commenter commented on pull request #9001: Remove double counting of queries in pinot-server

2022-06-30 Thread GitBox
codecov-commenter commented on PR #9001: URL: https://github.com/apache/pinot/pull/9001#issuecomment-1171686444 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9001?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] sajjad-moradi merged pull request #8877: Emit metrics if there's no consuming segment for a partition

2022-06-30 Thread GitBox
sajjad-moradi merged PR #8877: URL: https://github.com/apache/pinot/pull/8877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

[pinot] branch master updated: Emit metrics if there's no consuming segment for a partition (#8877)

2022-06-30 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new bc27ad99ec Emit metrics if there's no consuming s

[pinot] branch master updated (ad32a2a5ec -> db452c5df1)

2022-06-30 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ad32a2a5ec adding in AggregateNode and related contents. (#8946) add db452c5df1 Part 2 - Add support for multi

[GitHub] [pinot] siddharthteotia merged pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia merged PR #8993: URL: https://github.com/apache/pinot/pull/8993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] jackjlli opened a new pull request, #9001: Remove double counting on pinot-server

2022-06-30 Thread GitBox
jackjlli opened a new pull request, #9001: URL: https://github.com/apache/pinot/pull/9001 This PR removed the double counting on pinot-server if `PriorityScheduler` is used. The value of `QUERIES` metric has already been in https://github.com/apache/pinot/blob/master/pinot-core/src/m

[pinot] branch remove-double-couting created (now c64a30ffae)

2022-06-30 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch remove-double-couting in repository https://gitbox.apache.org/repos/asf/pinot.git at c64a30ffae Remove double counting on pinot-server This branch includes the following new commits: n

[pinot] 01/01: Remove double counting on pinot-server

2022-06-30 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch remove-double-couting in repository https://gitbox.apache.org/repos/asf/pinot.git commit c64a30ffae94731104e560d00921f02807cfaa58 Author: Jack Li(Analytics Engineering) AuthorDate: Thu Jun 30 12:57

[pinot] branch master updated: adding in AggregateNode and related contents. (#8946)

2022-06-30 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ad32a2a5ec adding in AggregateNode and relate

[GitHub] [pinot] siddharthteotia merged pull request #8946: add groupby operator to multistage engine

2022-06-30 Thread GitBox
siddharthteotia merged PR #8946: URL: https://github.com/apache/pinot/pull/8946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] KKcorps commented on a diff in pull request #8877: Emit metrics if there's no consuming segment for a partition

2022-06-30 Thread GitBox
KKcorps commented on code in PR #8877: URL: https://github.com/apache/pinot/pull/8877#discussion_r911358944 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/MissingConsumingSegmentFinder.java: ## @@ -0,0 +1,221 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] KKcorps commented on pull request #8877: Emit metrics if there's no consuming segment for a partition

2022-06-30 Thread GitBox
KKcorps commented on PR #8877: URL: https://github.com/apache/pinot/pull/8877#issuecomment-1171563261 I have taken a quick look and it looks fine to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] mcvsubbu commented on pull request #8877: Emit metrics if there's no consuming segment for a partition

2022-06-30 Thread GitBox
mcvsubbu commented on PR #8877: URL: https://github.com/apache/pinot/pull/8877#issuecomment-1171560444 We have this problem in production, so we need to commit soon. I suggest we commit it now, and the re-visit if @KKcorps finds any issues. -- This is an automated message from the Apach

[pinot] branch helix-1.0 updated (19a2f55c00 -> 04aeeee2f2)

2022-06-30 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git omit 19a2f55c00 Upgrade Helix to 1.0.4 add bae91b2d0d reduce GHA runner JVM mem footprint (#8997) add 37992b98ce

[GitHub] [pinot] jackjlli commented on a diff in pull request #8999: Retry validateJobs for a while to avoid flaky errors

2022-06-30 Thread GitBox
jackjlli commented on code in PR #8999: URL: https://github.com/apache/pinot/pull/8999#discussion_r911318797 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerStatelessTest.java: ## @@ -239,10 +242,20 @@ private void validateJob(Stri

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911314611 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -468,6 +907,80 @@ private void validateSimpleAggregateQueryResults(ResultTable

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911302896 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] ankitsultana commented on issue #8996: Bug in 0.10.0, Incorrect result when using more than two CASE WHEN statement in group by query

2022-06-30 Thread GitBox
ankitsultana commented on issue #8996: URL: https://github.com/apache/pinot/issues/8996#issuecomment-1171496859 Cherry picking https://github.com/apache/pinot/pull/8748 on v0.10.0 fixed it for us. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pinot] taohu18 commented on issue #8996: Bug in 0.10.0, Incorrect result when using more than two CASE WHEN statement in group by query

2022-06-30 Thread GitBox
taohu18 commented on issue #8996: URL: https://github.com/apache/pinot/issues/8996#issuecomment-1171488524 @richardstartin I downloaded pinot from the official build, not sure if it's on master or not. I will try with the most recent official build to see if it's fixed -- This is an auto

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911275573 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911275199 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911267892 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911266357 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911266357 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911260876 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911219349 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911219349 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911179077 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Test + p

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911172129 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionarySingleColumnGroupKeyGenerator.java: ## @@ -164,8 +166,113 @@ private Map createGro

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
somandal commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r911172129 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionarySingleColumnGroupKeyGenerator.java: ## @@ -164,8 +166,113 @@ private Map createGro

[GitHub] [pinot] diogobaeder commented on issue #8977: Unable to get float/double JSON results from sum()

2022-06-30 Thread GitBox
diogobaeder commented on issue #8977: URL: https://github.com/apache/pinot/issues/8977#issuecomment-1171343146 Nice, glad to know! Thanks @Jackie-Jiang , I'll close the ticket now since it dropped in the main branch already. -- This is an automated message from the Apache Git Service. To

[GitHub] [pinot] diogobaeder closed issue #8977: Unable to get float/double JSON results from sum()

2022-06-30 Thread GitBox
diogobaeder closed issue #8977: Unable to get float/double JSON results from sum() URL: https://github.com/apache/pinot/issues/8977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] gyokketto commented on a diff in pull request #8991: update-dependencies

2022-06-30 Thread GitBox
gyokketto commented on code in PR #8991: URL: https://github.com/apache/pinot/pull/8991#discussion_r911144374 ## pom.xml: ## @@ -121,24 +121,24 @@ See also: the surefire plugin section and the profiles section.--> true -1.9.2 -1.11.1 -0.9.8 -0.7

[GitHub] [pinot] gyokketto commented on a diff in pull request #8991: update-dependencies

2022-06-30 Thread GitBox
gyokketto commented on code in PR #8991: URL: https://github.com/apache/pinot/pull/8991#discussion_r911143536 ## pinot-clients/pinot-java-client/pom.xml: ## @@ -80,11 +80,28 @@ io.netty - netty + netty-all + ${netty.version} + + + o

[GitHub] [pinot] walterddr closed issue #8968: OfflineGRPCServerIntegrationTest is flaky

2022-06-30 Thread GitBox
walterddr closed issue #8968: OfflineGRPCServerIntegrationTest is flaky URL: https://github.com/apache/pinot/issues/8968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pinot] walterddr commented on issue #8968: OfflineGRPCServerIntegrationTest is flaky

2022-06-30 Thread GitBox
walterddr commented on issue #8968: URL: https://github.com/apache/pinot/issues/8968#issuecomment-1171296942 closing after #8997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [pinot] walterddr closed pull request #8767: [DO NOT MERGE][CI MOD] running GRPC integration test 100 times

2022-06-30 Thread GitBox
walterddr closed pull request #8767: [DO NOT MERGE][CI MOD] running GRPC integration test 100 times URL: https://github.com/apache/pinot/pull/8767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] walterddr commented on pull request #8767: [DO NOT MERGE][CI MOD] running GRPC integration test 100 times

2022-06-30 Thread GitBox
walterddr commented on PR #8767: URL: https://github.com/apache/pinot/pull/8767#issuecomment-1171296191 looks like #8997 fixed this. closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pinot] jadami10 commented on issue #8998: BadQueryRequestException when filtering on metric column first

2022-06-30 Thread GitBox
jadami10 commented on issue #8998: URL: https://github.com/apache/pinot/issues/8998#issuecomment-1171280855 i just missed typing it. I've updated the description. I will be updating to latest master early next week so can check again. -- This is an automated message from the Apache Git Se

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8927: Proper null handling in SELECT, ORDER BY, DISTINCT, and GROUP BY

2022-06-30 Thread GitBox
Jackie-Jiang commented on code in PR #8927: URL: https://github.com/apache/pinot/pull/8927#discussion_r911061582 ## pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/TransformBlockValSet.java: ## @@ -40,12 +44,40 @@ public class TransformBlockValSet implements

[pinot] branch master updated: Refector DateTime field specs to reduce overhead (#8960)

2022-06-30 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9735291f02 Refector DateTime field specs to reduc

[GitHub] [pinot] Jackie-Jiang merged pull request #8960: Refector DateTime field specs to reduce overhead

2022-06-30 Thread GitBox
Jackie-Jiang merged PR #8960: URL: https://github.com/apache/pinot/pull/8960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated: Add more explicit checks in PinotHelixResourceManagerTest (#9000)

2022-06-30 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1dcb2c4581 Add more explicit checks in PinotHelix

[GitHub] [pinot] Jackie-Jiang merged pull request #9000: Add more explicit checks in PinotHelixResourceManagerTest

2022-06-30 Thread GitBox
Jackie-Jiang merged PR #9000: URL: https://github.com/apache/pinot/pull/9000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang commented on issue #8998: BadQueryRequestException when filtering on metric column first

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8998: URL: https://github.com/apache/pinot/issues/8998#issuecomment-1171204386 The query is missing the `group by currency` though. What is the response with the latest master? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pinot] Jackie-Jiang commented on pull request #8877: Emit metrics if there's no consuming segment for a partition

2022-06-30 Thread GitBox
Jackie-Jiang commented on PR #8877: URL: https://github.com/apache/pinot/pull/8877#issuecomment-1171190684 cc @KKcorps to also take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pinot] Jackie-Jiang commented on issue #8992: String equality in Case statement inside date transform function throws

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8992: URL: https://github.com/apache/pinot/issues/8992#issuecomment-1171186183 The exception is thrown from the scalar function version of the `equals`, which means this operation is applied to an aggregation result? Do you have the exactly same query work

[GitHub] [pinot] Jackie-Jiang commented on issue #8990: UDF is not working as ingrestion Transform fumction

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8990: URL: https://github.com/apache/pinot/issues/8990#issuecomment-1171177988 Do you have the full stack trace for the exception? Do you have the plug-in jar included in the segment creation package? -- This is an automated message from the Apache Git Ser

[GitHub] [pinot] Jackie-Jiang commented on issue #8977: Unable to get float/double JSON results from sum()

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8977: URL: https://github.com/apache/pinot/issues/8977#issuecomment-1171171879 The `CAST` support for post-aggregation is added in #8535, so should be available in the next release -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] Jackie-Jiang commented on issue #8983: Support all additive functions with rollup

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8983: URL: https://github.com/apache/pinot/issues/8983#issuecomment-1171167607 The challenge here is that the intermediate result (e.g. `list` for `percentile`) must be of the same type of the input. In order to support any aggregation function, we need to f

[GitHub] [pinot] Jackie-Jiang commented on issue #8791: RealtimeNonReplicaGroupSegmentAssignmentTest.testRelocateCompletedSegments is flaky

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8791: URL: https://github.com/apache/pinot/issues/8791#issuecomment-1171161592 A lot of test failures are not easy to re-produce locally. Usually they failed due to very limited resources provided by the CI VMs: https://docs.github.com/en/actions/using-githu

[GitHub] [pinot] richardstartin commented on issue #8996: Bug in 0.10.0, Incorrect result when using more than two CASE WHEN statement in group by query

2022-06-30 Thread GitBox
richardstartin commented on issue #8996: URL: https://github.com/apache/pinot/issues/8996#issuecomment-1171159276 @taohu18 Does this occur on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8960: Refector DateTime field specs to reduce overhead

2022-06-30 Thread GitBox
Jackie-Jiang commented on code in PR #8960: URL: https://github.com/apache/pinot/pull/8960#discussion_r910960563 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFieldSpec.java: ## @@ -70,17 +72,8 @@ public DateTimeFieldSpec() { */ public DateTimeFieldSpec(Str

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8971: Fix thread safety issue with java client

2022-06-30 Thread GitBox
Jackie-Jiang commented on code in PR #8971: URL: https://github.com/apache/pinot/pull/8971#discussion_r910925837 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionFactory.java: ## @@ -28,7 +28,8 @@ * Creates connections to Pinot, given various

[GitHub] [pinot] Jackie-Jiang commented on issue #8948: Stuck unassigned segments after metadata push while controller is shutting down

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8948: URL: https://github.com/apache/pinot/issues/8948#issuecomment-1171116013 Refreshing the existing segment is expected to keep the idempotency. When pushing a segment, if segment does not already exist, Pinot will create the ZK metadata first, then uploa

[GitHub] [pinot] Jackie-Jiang commented on issue #8974: Server Response Deserialization Time Metric on Broker Side

2022-06-30 Thread GitBox
Jackie-Jiang commented on issue #8974: URL: https://github.com/apache/pinot/issues/8974#issuecomment-1171107752 @navina Can you please also take a look at this issue? It should be similar to the metric you added in #8941 -- This is an automated message from the Apache Git Service. To res

[GitHub] [pinot] codecov-commenter commented on pull request #8981: Fix a repeatable problem in PinotTaskManagerStatelessTest

2022-06-30 Thread GitBox
codecov-commenter commented on PR #8981: URL: https://github.com/apache/pinot/pull/8981#issuecomment-1171106156 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] codecov-commenter commented on pull request #9000: Add more explicit checks in PinotHelixResourceManagerTest

2022-06-30 Thread GitBox
codecov-commenter commented on PR #9000: URL: https://github.com/apache/pinot/pull/9000#issuecomment-1171102636 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8828: Add controller API for reload segment task status

2022-06-30 Thread GitBox
Jackie-Jiang commented on code in PR #8828: URL: https://github.com/apache/pinot/pull/8828#discussion_r910907030 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/SegmentDataManager.java: ## @@ -27,6 +27,15 @@ */ public abstract class SegmentDat

[GitHub] [pinot] codecov-commenter commented on pull request #8999: Retry validateJobs for a while to avoid flaky errors

2022-06-30 Thread GitBox
codecov-commenter commented on PR #8999: URL: https://github.com/apache/pinot/pull/8999#issuecomment-1171093885 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8999?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8960: Refector DateTime field specs to reduce overhead

2022-06-30 Thread GitBox
xiangfu0 commented on code in PR #8960: URL: https://github.com/apache/pinot/pull/8960#discussion_r905588167 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFieldSpec.java: ## @@ -70,17 +72,8 @@ public DateTimeFieldSpec() { */ public DateTimeFieldSpec(String

[GitHub] [pinot] gortiz opened a new pull request, #9000: Add more explicit checks in PinotHelixResourceManagerTest

2022-06-30 Thread GitBox
gortiz opened a new pull request, #9000: URL: https://github.com/apache/pinot/pull/9000 While trying to fix some flaky tests, I found quite difficult to understand why this test fails when it just said that "3 was expected but found 4" instead of "this set was expected but found this other"

[GitHub] [pinot] gortiz opened a new pull request, #8999: Retry validateJobs for a while to avoid flaky errors

2022-06-30 Thread GitBox
gortiz opened a new pull request, #8999: URL: https://github.com/apache/pinot/pull/8999 This PR tries to fix #8776. What the test does is to modify the state in helix and then verify that the result is correct. IICU Helix, there is no read-after-write guarantee in Helix, so there is

[GitHub] [pinot] gortiz commented on issue #8776: [Flaky Test] PinotTaskManagerStatelessTest.testPinotTaskManagerSchedulerWithUpdate()

2022-06-30 Thread GitBox
gortiz commented on issue #8776: URL: https://github.com/apache/pinot/issues/8776#issuecomment-1171042743 After some time thinking about this test and understanding how it works, I think the test was designed with this scenario in mind: ```mermaid sequenceDiagram Tes

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910711631 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionarySingleColumnGroupKeyGenerator.java: ## @@ -164,8 +166,113 @@ private Map cr

[GitHub] [pinot] siddharthteotia commented on pull request #8917: Add support for querying noDict MV columns for offline (all data types) and realtime (fixed width) segments

2022-06-30 Thread GitBox
siddharthteotia commented on PR #8917: URL: https://github.com/apache/pinot/pull/8917#issuecomment-1170868977 Part 2 split from this PR https://github.com/apache/pinot/pull/8993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910695632 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -807,4 +1320,283 @@ private void validateAggregateWithGroupByQueryResult

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910694202 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -468,6 +907,80 @@ private void validateSimpleAggregateQueryResults(Resul

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910692036 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -468,6 +907,80 @@ private void validateSimpleAggregateQueryResults(Resul

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910687228 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910687228 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910684831 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910683733 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910681944 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910680710 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910680710 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910678999 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910677514 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910675440 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

2022-06-30 Thread GitBox
siddharthteotia commented on code in PR #8993: URL: https://github.com/apache/pinot/pull/8993#discussion_r910675440 ## pinot-core/src/test/java/org/apache/pinot/queries/MultiValueRawQueriesTest.java: ## @@ -338,6 +338,445 @@ public void testSelectQueries() { } } + @Te