[pinot] branch master updated (551d53b6da -> 17404b200e)

2022-06-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 551d53b6da Spark Connector, support for TIMESTAMP and BOOLEAN fields (#8825) add 17404b200e Add swagger authoriz

[GitHub] [pinot] xiangfu0 merged pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
xiangfu0 merged PR #8830: URL: https://github.com/apache/pinot/pull/8830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] yupeng9 merged pull request #8825: Spark Connector, support for TIMESTAMP and BOOLEAN fields

2022-06-03 Thread GitBox
yupeng9 merged PR #8825: URL: https://github.com/apache/pinot/pull/8825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[pinot] branch master updated (e55c127d5e -> 551d53b6da)

2022-06-03 Thread yupeng
This is an automated email from the ASF dual-hosted git repository. yupeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from e55c127d5e Spark Connector GRPC reader fix for reading realtime tables (#8824) add 551d53b6da Spark Connector, su

[GitHub] [pinot] yupeng9 merged pull request #8824: Spark Connector GRPC reader fix for reading realtime tables

2022-06-03 Thread GitBox
yupeng9 merged PR #8824: URL: https://github.com/apache/pinot/pull/8824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[pinot] branch master updated (24e2ad53bf -> e55c127d5e)

2022-06-03 Thread yupeng
This is an automated email from the ASF dual-hosted git repository. yupeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 24e2ad53bf Fix auth provider for minion (#8831) add e55c127d5e Spark Connector GRPC reader fix for reading realtim

[GitHub] [pinot] codecov-commenter commented on pull request #8833: [DRAFT] Add multi-stage groupby operator

2022-06-03 Thread GitBox
codecov-commenter commented on PR #8833: URL: https://github.com/apache/pinot/pull/8833#issuecomment-1146494710 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[pinot] branch master updated (cd55015c0a -> 24e2ad53bf)

2022-06-03 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from cd55015c0a Update ZK config in helm chart (#8817) add 24e2ad53bf Fix auth provider for minion (#8831) No new rev

[GitHub] [pinot] apucher merged pull request #8831: (BUGFIX) Fix auth provider for minion

2022-06-03 Thread GitBox
apucher merged PR #8831: URL: https://github.com/apache/pinot/pull/8831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[GitHub] [pinot] dd-willgan opened a new issue, #8832: PinotClientTransport package private

2022-06-03 Thread GitBox
dd-willgan opened a new issue, #8832: URL: https://github.com/apache/pinot/issues/8832 Hi, I'm trying to use the Pinot Java Client (recommended over the JDBC client for production) with authentication by instantiating a [JsonAsyncHttpClientTransportFactory](https://github.com/apache/pinot/b

[GitHub] [pinot] dongxiaoman commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
dongxiaoman commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889389874 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/MmapDebugResource.java: ## @@ -65,11 +75,10 @@ public List getOffHeapSizes() { @GET @Produces

[GitHub] [pinot] dongxiaoman commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
dongxiaoman commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889389108 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotLeadControllerRestletResource.java: ## @@ -83,8 +92,8 @@ public LeadControllerResponse

[GitHub] [pinot] dongxiaoman commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
dongxiaoman commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889385536 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerHealthCheck.java: ## @@ -37,8 +38,10 @@ import org.apache.pinot.controller.

[GitHub] [pinot] apucher commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
apucher commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889384255 ## pinot-tools/src/main/java/org/apache/pinot/tools/service/api/resources/PinotServiceManagerInstanceResource.java: ## @@ -70,8 +78,7 @@ public class PinotServiceManagerIn

[GitHub] [pinot] apucher commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
apucher commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889383920 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/MmapDebugResource.java: ## @@ -65,11 +75,10 @@ public List getOffHeapSizes() { @GET @Produces(Med

[GitHub] [pinot] apucher commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
apucher commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889383573 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableTenantConfigs.java: ## @@ -58,9 +66,9 @@ public class PinotTableTenantConfigs { @P

[GitHub] [pinot] apucher commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
apucher commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889383195 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotLeadControllerRestletResource.java: ## @@ -83,8 +92,8 @@ public LeadControllerResponse get

[GitHub] [pinot] apucher commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
apucher commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889382927 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerHealthCheck.java: ## @@ -37,8 +38,10 @@ import org.apache.pinot.controller.Base

[GitHub] [pinot] apucher commented on a diff in pull request #8831: (BUGFIX) Fix auth provider for minion

2022-06-03 Thread GitBox
apucher commented on code in PR #8831: URL: https://github.com/apache/pinot/pull/8831#discussion_r889378370 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -538,7 +538,7 @@ public static class Minion { * Service token for accessing protect

[GitHub] [pinot] dongxiaoman commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
dongxiaoman commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889371435 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -41,6 +41,7 @@ private CommonConstants() { public static final String DEFAULT_METR

[GitHub] [pinot] codecov-commenter commented on pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
codecov-commenter commented on PR #8830: URL: https://github.com/apache/pinot/pull/8830#issuecomment-1146377816 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8830?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] codecov-commenter commented on pull request #8831: (BUGFIX) Fix auth provider for minion

2022-06-03 Thread GitBox
codecov-commenter commented on PR #8831: URL: https://github.com/apache/pinot/pull/8831#issuecomment-1146375013 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] klsince commented on a diff in pull request #8831: (BUGFIX) Fix auth provider for minion

2022-06-03 Thread GitBox
klsince commented on code in PR #8831: URL: https://github.com/apache/pinot/pull/8831#discussion_r889353631 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -538,7 +538,7 @@ public static class Minion { * Service token for accessing protect

[GitHub] [pinot] timsants opened a new pull request, #8831: (BUGFIX) Fix auth provider for minion

2022-06-03 Thread GitBox
timsants opened a new pull request, #8831: URL: https://github.com/apache/pinot/pull/8831 Bug fix for auth in minion tasks. **Problem** The auth token was not being generated. As a result, any request made to the controller was failing with a 403. **Fix** Token is now gen

[GitHub] [pinot] apucher commented on a diff in pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
apucher commented on code in PR #8830: URL: https://github.com/apache/pinot/pull/8830#discussion_r889340386 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -41,6 +41,7 @@ private CommonConstants() { public static final String DEFAULT_METRICS_

[GitHub] [pinot] dongxiaoman commented on pull request #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
dongxiaoman commented on PR #8830: URL: https://github.com/apache/pinot/pull/8830#issuecomment-1146346586 cc @apucher @xiangfu0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] kkrugler commented on pull request #8812: Fix segment generation error handling

2022-06-03 Thread GitBox
kkrugler commented on PR #8812: URL: https://github.com/apache/pinot/pull/8812#issuecomment-1146335202 Hi @Jackie-Jiang - let me know if you'd like any further changes, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pinot] kkrugler commented on issue #8829: Automate documented functions

2022-06-03 Thread GitBox
kkrugler commented on issue #8829: URL: https://github.com/apache/pinot/issues/8829#issuecomment-1146332109 +10 for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] dongxiaoman opened a new pull request, #8830: Add swagger authorization header support

2022-06-03 Thread GitBox
dongxiaoman opened a new pull request, #8830: URL: https://github.com/apache/pinot/pull/8830 ## Description This PR adds the `Authorization: xxx` header support into the Swagger UI in Pinot. Now when the users opens Pinot Swagger, they will see an extra "Authorize" button. 1. If th

[pinot] branch multi_stage_query_engine updated: Merge Multistage Engine back to main (#8720)

2022-06-03 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/multi_stage_query_engine by this push: new 82623d8f

[GitHub] [pinot] siddharthteotia merged pull request #8720: Merge Multistage Engine back to main

2022-06-03 Thread GitBox
siddharthteotia merged PR #8720: URL: https://github.com/apache/pinot/pull/8720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] KKcorps commented on a diff in pull request #8787: Cleanup Kinesis Logs

2022-06-03 Thread GitBox
KKcorps commented on code in PR #8787: URL: https://github.com/apache/pinot/pull/8787#discussion_r889240851 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java: ## @@ -159,23 +159,23 @@ private KinesisRe

[pinot] branch master updated: Update ZK config in helm chart (#8817)

2022-06-03 Thread kharekartik
This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new cd55015c0a Update ZK config in helm chart (#

[GitHub] [pinot] KKcorps merged pull request #8817: Update ZK config in helm chart

2022-06-03 Thread GitBox
KKcorps merged PR #8817: URL: https://github.com/apache/pinot/pull/8817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[pinot] branch master updated (7b9e16b65d -> 05271b0b09)

2022-06-03 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7b9e16b65d Not overwrite the whole SystemResourceInfo config map (#8820) add 05271b0b09 add auth provider to min

[GitHub] [pinot] apucher merged pull request #8826: add auth provider to minion client

2022-06-03 Thread GitBox
apucher merged PR #8826: URL: https://github.com/apache/pinot/pull/8826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[GitHub] [pinot] geeknarrator commented on pull request #8781: Fix Upsert config validation to check for metrics aggregation

2022-06-03 Thread GitBox
geeknarrator commented on PR #8781: URL: https://github.com/apache/pinot/pull/8781#issuecomment-1146176170 @Jackie-Jiang - Could you please help me merge this? I have resolved the conflict. (also the formatting changes are done by the pinot checkstyle configuration. -- This is an automat

[GitHub] [pinot] KKcorps commented on pull request #8708: [Feature] Deduplication

2022-06-03 Thread GitBox
KKcorps commented on PR #8708: URL: https://github.com/apache/pinot/pull/8708#issuecomment-1146049919 @saurabhd336 Please add documentation for this in `Import Data` section. You can create a new page titled `Stream Ingestion with Dedup` -- This is an automated message from the Apache Git

[GitHub] [pinot] egalpin opened a new issue, #8829: Automate documented functions

2022-06-03 Thread GitBox
egalpin opened a new issue, #8829: URL: https://github.com/apache/pinot/issues/8829 In the Pinot docs[1], only a subset of available functions are documented. I think it would be highly valuable to automate listing any function found in code[2] to be part of those docs. Even if the defaul

[GitHub] [pinot] saurabhd336 opened a new pull request, #8828: (WIP) Add server API for task status

2022-06-03 Thread GitBox
saurabhd336 opened a new pull request, #8828: URL: https://github.com/apache/pinot/pull/8828 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

[GitHub] [pinot] gortiz commented on pull request #8818: regexp_like fusing

2022-06-03 Thread GitBox
gortiz commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145835768 I didn't know LIKE expressions were evaluated as REGEX_LIKE. Reading the code, it seems that the transformation is made in `RequestContextUtils`, which is evaluated after the filter optimiza

[GitHub] [pinot] richardstartin commented on pull request #8818: regexp_like fusing

2022-06-03 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145814759 I don’t believe the native FST supports backreferences, and I don’t think it would be easy to add support either. Not sure about the lucene FST index. As mentioned above, LIKE statem

[GitHub] [pinot] gortiz commented on pull request #8818: regexp_like fusing

2022-06-03 Thread GitBox
gortiz commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145804872 I've changed the implementation and the description of the PR to be focused on `regexp_like` instead of `text_match`. Anyway, I would like to have some benchmarks before this feature

[GitHub] [pinot] richardstartin commented on pull request #8818: text_match fusing

2022-06-03 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145792924 > ORMs are not going to generate them On the contrary, this exact pattern has been observed generated by customer systems querying Pinot -- This is an automated message fro

[GitHub] [pinot] gortiz commented on pull request #8818: text_match fusing

2022-06-03 Thread GitBox
gortiz commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145782478 ORMs are not going to generate them, but a user may try to do something like `regexp_like(col1, '(.+)=\1')`, which will be positive in texts like `a=a` but false in `b=a`. I think this is ve

[GitHub] [pinot] KKcorps opened a new pull request, #8827: Improve MeetupRsvp Quickstart

2022-06-03 Thread GitBox
KKcorps opened a new pull request, #8827: URL: https://github.com/apache/pinot/pull/8827 * Use only `lowLevel` consumer * Add bounds to data generator so that latitude and longitude are in correct range and country and cities have reduced cardinalities. -- This is an automated message

[GitHub] [pinot] richardstartin commented on pull request #8818: text_match fusing

2022-06-03 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145708838 I don’t think it’s possible to express backtracking behaviour in a LIKE statement, this optimisation would target long unions of LIKE statements generated by ORMs, and should be most

[GitHub] [pinot] gortiz commented on a diff in pull request #8818: text_match fusing

2022-06-03 Thread GitBox
gortiz commented on code in PR #8818: URL: https://github.com/apache/pinot/pull/8818#discussion_r888712252 ## pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java: ## @@ -255,6 +255,9 @@ private BaseFilterOperator constructPhysicalOperator(FilterContext filte

[GitHub] [pinot] codecov-commenter commented on pull request #8826: add auth provider to minion client

2022-06-03 Thread GitBox
codecov-commenter commented on PR #8826: URL: https://github.com/apache/pinot/pull/8826#issuecomment-1145678928 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8826?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[pinot] branch auth-minion-client updated (05f0621822 -> 698b59ea45)

2022-06-03 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch auth-minion-client in repository https://gitbox.apache.org/repos/asf/pinot.git from 05f0621822 add back type ref for 1.8 add 698b59ea45 another TypeRef No new revisions were added by t