gortiz commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145782478
ORMs are not going to generate them, but a user may try to do something like `regexp_like(col1, '(.+)=\1')`, which will be positive in texts like `a=a` but false in `b=a`. I think this is very bizarre, but possible. What I'm going to do is to try to detect the usage of backreferences in the regexp. To do so, I'm going to discard any `regexp_like` whose predicate matches with `.*(?:(?:\\[0-9]+)|(?:\\k\<\w+\>)).*`. The function may have false positives (for example the regexp`\\1` will be a false positive) and false negatives (where is more difficult to find examples, maybe playing with utf8?), but it may be good enough to activate the query option by default in a future release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
