This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5b44c22 Remove secrets from job spec (#8420
KKcorps merged pull request #8420:
URL: https://github.com/apache/pinot/pull/8420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a change to branch optimise_memory
in repository https://gitbox.apache.org/repos/asf/pinot.git.
discard e05c502 Bug fix: use of Mv array instead of SV array
discard 4548460 Remove unused imports
discard 6
KKcorps edited a comment on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1082646626
It will look something like this -
https://github.com/KKcorps/incubator-pinot/pull/1/files
This is a very crude implementation and final PR should look really
different from
codecov-commenter edited a comment on pull request #8420:
URL: https://github.com/apache/pinot/pull/8420#issuecomment-1079765886
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
KKcorps commented on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1082646626
It will look something like this -
https://github.com/KKcorps/incubator-pinot/pull/1/files
I do not like adding `avro` dependency to broker though so might move the
classes to some
codecov-commenter edited a comment on pull request #8420:
URL: https://github.com/apache/pinot/pull/8420#issuecomment-1079765886
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
KKcorps commented on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1082642019
@Jackie-Jiang @mayankshriv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
KKcorps opened a new issue #8437:
URL: https://github.com/apache/pinot/issues/8437
Currently, for a query, broker can only return JSON response. However, for
better performance on client side, it might be desirable to get response in a
compact, fast, binary format such as Avro, ProtoBuf, F
snleee commented on a change in pull request #8422:
URL: https://github.com/apache/pinot/pull/8422#discussion_r838100092
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -1757,6 +1758,10 @@ public void del
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r838098563
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapCollection.java
##
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apa
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r838098478
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapCollection.java
##
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apa
mqliang commented on pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#issuecomment-1082597767
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
snleee commented on a change in pull request #8422:
URL: https://github.com/apache/pinot/pull/8422#discussion_r838064064
##
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
##
@@ -184,18 +184,26 @@ private TableDataManag
codecov-commenter edited a comment on pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#issuecomment-1081210576
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#issuecomment-1081210576
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#issuecomment-1082486381
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#issuecomment-1082486381
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#issuecomment-1081210576
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#issuecomment-1082486381
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8434:
URL: https://github.com/apache/pinot/pull/8434#issuecomment-1082275642
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8434:
URL: https://github.com/apache/pinot/pull/8434#issuecomment-1082275642
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8434:
URL: https://github.com/apache/pinot/pull/8434#issuecomment-1082275642
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
mqliang commented on a change in pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#discussion_r838036344
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/SqlResultComparator.java
##
@@ -126,29 +126,32 @@ public static boolean areEqual(Jso
codecov-commenter edited a comment on pull request #8434:
URL: https://github.com/apache/pinot/pull/8434#issuecomment-1082275642
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
mcvsubbu commented on a change in pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#discussion_r838034930
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/SqlResultComparator.java
##
@@ -126,29 +126,32 @@ public static boolean areEqual(Js
codecov-commenter commented on pull request #8425:
URL: https://github.com/apache/pinot/pull/8425#issuecomment-1082521230
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
PrachiKhobragade commented on issue #8217:
URL: https://github.com/apache/pinot/issues/8217#issuecomment-1082506697
Picking this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
Jackie-Jiang commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r838008174
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapCollection.java
##
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apach
codecov-commenter edited a comment on pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#issuecomment-1081210576
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#issuecomment-1081210576
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
jtao15 commented on pull request #8422:
URL: https://github.com/apache/pinot/pull/8422#issuecomment-1082493001
Updated the pr to remove TableDataManager only when the table is removed
based on offline discussions.
--
This is an automated message from the Apache Git Service.
To respond to
codecov-commenter edited a comment on pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#issuecomment-1082486381
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
mqliang commented on a change in pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#discussion_r838004763
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/SqlResultComparator.java
##
@@ -381,22 +384,22 @@ private static boolean
areNumEntr
codecov-commenter commented on pull request #8433:
URL: https://github.com/apache/pinot/pull/8433#issuecomment-1082486381
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
amrishlal commented on pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#issuecomment-1082478220
@siddharthteotia please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
amrishlal commented on a change in pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#discussion_r837997074
##
File path:
pinot-plugins/pinot-input-format/pinot-avro-base/src/test/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractorTest.java
##
@@
amrishlal commented on a change in pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#discussion_r837995097
##
File path:
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroSchemaUtil.java
##
@@ -95,6 +10
codecov-commenter edited a comment on pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#issuecomment-1079284319
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8411?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#issuecomment-1079284319
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8411?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837962874
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java
##
@@ -178,6 +179,11 @@ private TransformOperator
buildT
codecov-commenter edited a comment on pull request #8355:
URL: https://github.com/apache/pinot/pull/8355#issuecomment-1082426754
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8355?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
nizarhejazi commented on issue #8418:
URL: https://github.com/apache/pinot/issues/8418#issuecomment-1082429570
@siddharthteotia Pinot BigDecimal can store arbitrary precision integer
unscaled value, and a 16-bit integer scale.
Precision and scale configuration are related Presto/Tri
codecov-commenter commented on pull request #8355:
URL: https://github.com/apache/pinot/pull/8355#issuecomment-1082426754
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8355?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837950536
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/operator/filter/BitmapCollectionTest.java
##
@@ -0,0 +1,237 @@
+/**
+ * Licensed to the
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837949612
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/operator/filter/BitmapCollectionTest.java
##
@@ -0,0 +1,237 @@
+/**
+ * Licensed to the
richardstartin commented on pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#issuecomment-1082418102
A few points about enforcing invariants and preconditions came up in this
review:
* it would be nice to be able to assume SV bitmap indexes are disjoint, but
they won't
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837945158
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,28 @@ protected FilterBlock getN
richardstartin commented on pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#issuecomment-1082412064
I've squashed the commits to make it easier to rebase (merge conflict with
#8408)
--
This is an automated message from the Apache Git Service.
To respond to the message
Jackie-Jiang commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837936950
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/operator/filter/BitmapCollectionTest.java
##
@@ -0,0 +1,237 @@
+/**
+ * Licensed to the A
Jackie-Jiang commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837935497
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/SortedIndexBasedFilterOperator.java
##
@@ -132,6 +133,92 @@ protected Fil
Jackie-Jiang commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837933873
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,28 @@ protected FilterBlock getNex
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d2ca07e Combine Metadata and Dictionary
richardstartin merged pull request #8408:
URL: https://github.com/apache/pinot/pull/8408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
codecov-commenter edited a comment on pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#issuecomment-1079508001
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8408?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#issuecomment-1079508001
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8408?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
kodeine edited a comment on issue #8373:
URL: https://github.com/apache/pinot/issues/8373#issuecomment-1082381323
This works with new chart version just released, 0.2.5, but documentation is
still wrong with indentation of host tls etc
--
This is an automated message from the Apache Git
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837917982
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/OrFilterOperator.java
##
@@ -60,4 +62,25 @@ public String toExplainStri
kodeine closed issue #8373:
URL: https://github.com/apache/pinot/issues/8373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@p
kodeine commented on issue #8373:
URL: https://github.com/apache/pinot/issues/8373#issuecomment-1082381323
This works with new chart version just released, 0.2.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
codecov-commenter edited a comment on pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#issuecomment-1079508001
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8408?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837916533
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,28 @@ protected FilterBlock getN
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837912376
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/SortedIndexBasedFilterOperator.java
##
@@ -132,6 +133,92 @@ protected F
Jackie-Jiang commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837903870
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,28 @@ protected FilterBlock getNex
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 24cc357 update 0.2.5 index with new zookeeper d
xiangfu0 merged pull request #8436:
URL: https://github.com/apache/pinot/pull/8436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
xiangfu0 opened a new pull request #8436:
URL: https://github.com/apache/pinot/pull/8436
## Description
Reformat helm index file
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6ec6d4a Adding pinot helm 0.2.5 (#8435)
6ec6d4a
xiangfu0 merged pull request #8435:
URL: https://github.com/apache/pinot/pull/8435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
Jackie-Jiang commented on pull request #8428:
URL: https://github.com/apache/pinot/pull/8428#issuecomment-1082354580
This operator only applies to the aggregation FILTER, where we don't need to
scan the main filter multiple times
--
This is an automated message from the Apache Git Servic
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837889234
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BaseFilterOperator.java
##
@@ -40,4 +43,128 @@ public boolean isResultE
Jackie-Jiang commented on a change in pull request #8426:
URL: https://github.com/apache/pinot/pull/8426#discussion_r837887248
##
File path:
pinot-core/src/test/java/org/apache/pinot/queries/JsonIngestionFromAvroQueriesTest.java
##
@@ -0,0 +1,341 @@
+/**
+ * Licensed to the Ap
Jackie-Jiang commented on a change in pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#discussion_r837877827
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java
##
@@ -40,80 +39,90 @@
import
org.a
xiangfu0 opened a new pull request #8435:
URL: https://github.com/apache/pinot/pull/8435
## Description
Release pinot helm 0.2.5
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837877211
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapBasedFilterOperator.java
##
@@ -100,6 +101,67 @@ protected Filter
Jackie-Jiang commented on a change in pull request #8369:
URL: https://github.com/apache/pinot/pull/8369#discussion_r837876217
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java
##
@@ -75,6 +81,11 @@ public FilterConfig getFi
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837875629
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/SortedIndexBasedFilterOperator.java
##
@@ -132,6 +133,96 @@ protected F
Jackie-Jiang commented on issue #8423:
URL: https://github.com/apache/pinot/issues/8423#issuecomment-1082332216
After some offline discussion, one way to solve this issue is to add a
`DELETE` message, and only remove the `tableDataManager` when the table is
deleted
--
This is an automat
Jackie-Jiang commented on issue #8399:
URL: https://github.com/apache/pinot/issues/8399#issuecomment-1082330899
We may consider adding a new config in the `IngestionConfig` to store the
json string of the record into a field. The logic needs to be implemented into
the `RecordExtractor`
-
Jackie-Jiang commented on issue #8424:
URL: https://github.com/apache/pinot/issues/8424#issuecomment-1082322894
We need to add the `ScalarFunction` version of the `CAST` function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837851321
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/SortedIndexBasedFilterOperator.java
##
@@ -132,6 +133,96 @@ protected F
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837850811
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/OrFilterOperator.java
##
@@ -60,4 +64,37 @@ public String toExplainStri
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837850683
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/OrFilterOperator.java
##
@@ -32,6 +34,8 @@
private final List _filte
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837850389
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapBasedFilterOperator.java
##
@@ -100,6 +101,67 @@ protected Filter
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837847120
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,39 @@ protected FilterBlock getN
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837845568
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,39 @@ protected FilterBlock getN
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837845361
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,39 @@ protected FilterBlock getN
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837845079
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BaseFilterOperator.java
##
@@ -40,4 +43,128 @@ public boolean isResultE
codecov-commenter commented on pull request #8434:
URL: https://github.com/apache/pinot/pull/8434#issuecomment-1082275642
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837806164
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BaseFilterOperator.java
##
@@ -40,4 +43,128 @@ public boolean isResultE
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837783754
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BaseFilterOperator.java
##
@@ -40,4 +43,128 @@ public boolean isResultE
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837783041
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/SortedIndexBasedFilterOperator.java
##
@@ -132,6 +133,96 @@ protected F
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837782397
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/OrFilterOperator.java
##
@@ -60,4 +64,37 @@ public String toExplainStri
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837782085
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapBasedFilterOperator.java
##
@@ -100,6 +101,67 @@ protected Filter
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837780689
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapBasedFilterOperator.java
##
@@ -100,6 +101,67 @@ protected Filter
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837779585
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BaseFilterOperator.java
##
@@ -40,4 +43,128 @@ public boolean isResultE
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837779005
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,39 @@ protected FilterBlock getN
richardstartin commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837778215
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,39 @@ protected FilterBlock getN
codecov-commenter edited a comment on pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#issuecomment-1065843913
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
Jackie-Jiang commented on a change in pull request #8411:
URL: https://github.com/apache/pinot/pull/8411#discussion_r837719142
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java
##
@@ -45,6 +47,39 @@ protected FilterBlock getNex
1 - 100 of 179 matches
Mail list logo
