richardstartin commented on a change in pull request #8411: URL: https://github.com/apache/pinot/pull/8411#discussion_r837917982
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/OrFilterOperator.java ########## @@ -60,4 +62,25 @@ public String toExplainString() { public List<Operator> getChildOperators() { return new ArrayList<>(_filterOperators); } + + @Override + public boolean canOptimizeCount() { + boolean allChildrenProduceBitmaps = true; + for (BaseFilterOperator child : _filterOperators) { + allChildrenProduceBitmaps &= child.canProduceBitmaps(); + } + return allChildrenProduceBitmaps; + } + + @Override + public int getNumMatchingDocs() { Review comment: Same as and, was handled, no safety problem, indicates a problem elsewhere in the planner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org