[GitHub] [pinot] codecov-commenter edited a comment on pull request #8343: Timestamp type index

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8343: URL: https://github.com/apache/pinot/pull/8343#issuecomment-1065843913 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r830415123 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java ## @@ -0,0 +1,471 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r830415110 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java ## @@ -0,0 +1,471 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r830414833 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/BaseQueriesTest.java ## @@ -197,21 +198,31 @@ protected BrokerResponseNative getBroker

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r830413641 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -79,7 +79,6 @@ private SelectionOperator

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring

2022-03-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #8369: URL: https://github.com/apache/pinot/pull/8369#discussion_r830412345 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java ## @@ -52,6 +52,7 @@ private boolean _enableDynamicStar

[GitHub] [pinot] Jackie-Jiang commented on issue #8371: Retain instance sequence for table rebalance

2022-03-18 Thread GitBox
Jackie-Jiang commented on issue #8371: URL: https://github.com/apache/pinot/issues/8371#issuecomment-1072897100 We may add some strategy for instance assignment to allow minimum movement using some greedy algorithm -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r830401982 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/filter/RowMatcherFactory.java ## @@ -0,0 +1,47 @@ +/** + * Licensed to the A

[pinot] branch master updated (114e4c5 -> b05a541)

2022-03-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 114e4c5 add UT for disjoint check on lineage segmentFroms (#8242) add b05a541 Adding schema validation for rec

[GitHub] [pinot] xiangfu0 merged pull request #8370: Adding schema validation for recommendation engine

2022-03-18 Thread GitBox
xiangfu0 merged pull request #8370: URL: https://github.com/apache/pinot/pull/8370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r830269326 ## File path: pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java ## @@ -58,10 +61,9 @@ import

[pinot] branch master updated (cd311bc -> 114e4c5)

2022-03-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from cd311bc Use netty-bom to keep the netty-related libraries sync (#8365) add 114e4c5 add UT for disjoint check on

[GitHub] [pinot] Jackie-Jiang merged pull request #8242: add UT for disjoint check on lineage segmentFroms

2022-03-18 Thread GitBox
Jackie-Jiang merged pull request #8242: URL: https://github.com/apache/pinot/pull/8242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8343: Timestamp type index

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8343: URL: https://github.com/apache/pinot/pull/8343#issuecomment-1065843913 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8370: Adding schema validation for recommendation engine

2022-03-18 Thread GitBox
codecov-commenter commented on pull request #8370: URL: https://github.com/apache/pinot/pull/8370#issuecomment-1072839077 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] jackjlli opened a new issue #8371: Retain instance sequence for table rebalance

2022-03-18 Thread GitBox
jackjlli opened a new issue #8371: URL: https://github.com/apache/pinot/issues/8371 Currently when the table rebalance request is made, the list of instances will be sorted by the instance ids before the instance partition is formed. While when an instance with a smaller instance id got sw

[GitHub] [pinot] xiangfu0 opened a new pull request #8370: Adding schema validation for recommendation engine

2022-03-18 Thread GitBox
xiangfu0 opened a new pull request #8370: URL: https://github.com/apache/pinot/pull/8370 ## Description Current tests have broken schema which cannot pass schema validation. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broke

[GitHub] [pinot] codecov-commenter commented on pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring

2022-03-18 Thread GitBox
codecov-commenter commented on pull request #8369: URL: https://github.com/apache/pinot/pull/8369#issuecomment-1072796262 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8369?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] noon-stripe opened a new pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring

2022-03-18 Thread GitBox
noon-stripe opened a new pull request #8369: URL: https://github.com/apache/pinot/pull/8369 ## Description This PR adds configuration for generalized pre-aggregation (see #8360 ). Nothing is using this configuration yet. That will come in later PRs. ## Upgrade Notes Does t

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8304: URL: https://github.com/apache/pinot/pull/8304#issuecomment-1066731691 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830273744 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ## @@ -0,0 +1,74 @@ +/** + * Li

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r830255356 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNotNullTransformFunction.java ## @@ -0,0 +1,101 @@ +/** + *

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[pinot] annotated tag release-0.10.0-rc0 updated (30c4635 -> ba4d699)

2022-03-18 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to annotated tag release-0.10.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git. *** WARNING: tag release-0.10.0-rc0 was modified! *** from 30c4635 (commit) to ba4d699 (tag) t

[pinot] branch release-0.10.0-rc updated (08d0db1 -> 30c4635)

2022-03-18 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git. from 08d0db1 Update the end date in notice file add 30c4635 [maven-release-plugin] prepare release releas

[GitHub] [pinot] snleee opened a new pull request #8368: Invoke MetadataEventNotifier on schema delete

2022-03-18 Thread GitBox
snleee opened a new pull request #8368: URL: https://github.com/apache/pinot/pull/8368 Invoke MetadataEventNotifier on schema delete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[pinot] branch release-0.10.0-rc updated: [maven-release-plugin] prepare for next development iteration

2022-03-18 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-0.10.0-rc by this push: new cd8951c [maven-release-plu

[GitHub] [pinot] KKcorps commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830250099 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ## @@ -0,0 +1,74 @@ +/** + * Licensed

[GitHub] [pinot] KKcorps commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830247631 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java ## @@ -161,4 +161,55 @@ prot

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r830247106 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] klsince commented on a change in pull request #8242: handle lineage with empty segmentsFrom

2022-03-18 Thread GitBox
klsince commented on a change in pull request #8242: URL: https://github.com/apache/pinot/pull/8242#discussion_r830221603 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2963,6 +2961,25 @@ public String

[pinot] branch master updated: Use netty-bom to keep the netty-related libraries sync (#8365)

2022-03-18 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new cd311bc Use netty-bom to keep the netty-rela

[GitHub] [pinot] siddharthteotia merged pull request #8365: Use netty-bom to keep the netty-related libraries sync

2022-03-18 Thread GitBox
siddharthteotia merged pull request #8365: URL: https://github.com/apache/pinot/pull/8365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830184435 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TruncateDecimalTransformFunction.java ## @@ -0,0 +1,98 @@ +

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830185003 ## File path: pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/TrigonometricFunctionsTest.java ## @@ -0,0 +1,163 @@ +/** +

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830182233 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java ## @@ -161,4 +161,55

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830181728 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SingleParamMathTransformFunction.java ## @@ -161,4 +161,55

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830180752 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ## @@ -0,0 +1,74 @@ +/** + * Li

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830180329 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java ## @@ -0,0 +1,100 @@ +/*

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830179375 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ## @@ -0,0 +1,74 @@ +/** + * Li

[GitHub] [pinot] richardstartin commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r830174453 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PowerTransformFunction.java ## @@ -0,0 +1,74 @@ +/** + * Li

[GitHub] [pinot] richardstartin commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r830172170 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNullTransformFunction.java ## @@ -0,0 +1,97 @@ +/** + * L

[GitHub] [pinot] KKcorps commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
KKcorps commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r830170091 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNullTransformFunction.java ## @@ -0,0 +1,97 @@ +/** + * Licensed

[GitHub] [pinot] walterddr commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r830161160 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java ## @@ -0,0 +1,49 @@ +/** + * Licensed to the

[GitHub] [pinot] walterddr commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r830158935 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java ## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pinot] walterddr commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r830154691 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java ## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pinot] walterddr commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r830154238 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StageNodeConverter.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apach

[GitHub] [pinot] walterddr commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r830153576 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/context/PlannerContext.java ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829434243 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -217,6 +218,10 @@ private BrokerRes

[GitHub] [pinot] xiangfu0 commented on issue #6297: Adding Pinot Redash integration

2022-03-18 Thread GitBox
xiangfu0 commented on issue #6297: URL: https://github.com/apache/pinot/issues/6297#issuecomment-1071163899 0.3.3 is good with Pinot < 0.8. Pinot introduces new data types: TIMESTAMP/JSON after 0.8.0 The python client support is added here: [Changes](https://github.com/python-

[GitHub] [pinot] walterddr commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r830069740 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java ## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] walterddr commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829216994 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(String sto

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8329: URL: https://github.com/apache/pinot/pull/8329#issuecomment-1063683490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8337: Fix bug when importing files with the same name in different directories

2022-03-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #8337: URL: https://github.com/apache/pinot/pull/8337#discussion_r829277096 ## File path: pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGen

[GitHub] [pinot] codecov-commenter commented on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
codecov-commenter commented on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter commented on pull request #8367: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest

2022-03-18 Thread GitBox
codecov-commenter commented on pull request #8367: URL: https://github.com/apache/pinot/pull/8367#issuecomment-1072075697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] mcvsubbu commented on issue #8260: Add support for JOIN - Multi-stage execution query engine

2022-03-18 Thread GitBox
mcvsubbu commented on issue #8260: URL: https://github.com/apache/pinot/issues/8260#issuecomment-1070855641 @walterddr can you please open up access to the design doc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pinot] codecov-commenter commented on pull request #8366: Fix the missing NOT handling

2022-03-18 Thread GitBox
codecov-commenter commented on pull request #8366: URL: https://github.com/apache/pinot/pull/8366#issuecomment-1071936916 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8366: Fix the missing NOT handling

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8366: URL: https://github.com/apache/pinot/pull/8366#issuecomment-1071936916 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] xiangfu0 merged pull request #8367: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest

2022-03-18 Thread GitBox
xiangfu0 merged pull request #8367: URL: https://github.com/apache/pinot/pull/8367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] INNOCENT-BOY commented on a change in pull request #8314: Access Control management Development

2022-03-18 Thread GitBox
INNOCENT-BOY commented on a change in pull request #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r829641115 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/provider/UserCache.java ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache S

[GitHub] [pinot] richardstartin commented on a change in pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829480330 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/TransformPipelineTest.java ## @@ -25,18 +25,16 @@ im

[GitHub] [pinot] dongxiaoman commented on pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-18 Thread GitBox
dongxiaoman commented on pull request #8364: URL: https://github.com/apache/pinot/pull/8364#issuecomment-1071514091 cc @npawar The PR for the follow up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-18 Thread GitBox
dongxiaoman commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829506556 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/TransformPipelineTest.java ## @@ -25,18 +25,16 @@ impor

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829288558 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(String

[GitHub] [pinot] xiangfu0 closed issue #8324: MultiNodesOfflineClusterIntegrationTest.testInstanceDecommission is flaky

2022-03-18 Thread GitBox
xiangfu0 closed issue #8324: URL: https://github.com/apache/pinot/issues/8324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [pinot] KKcorps merged pull request #8333: Add support for Kinesis datasource in Github Events recipe

2022-03-18 Thread GitBox
KKcorps merged pull request #8333: URL: https://github.com/apache/pinot/pull/8333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] codecov-commenter commented on pull request #8365: Use netty-bom to keep the netty-related libraries sync

2022-03-18 Thread GitBox
codecov-commenter commented on pull request #8365: URL: https://github.com/apache/pinot/pull/8365#issuecomment-1071906939 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] KKcorps commented on pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
KKcorps commented on pull request #8304: URL: https://github.com/apache/pinot/pull/8304#issuecomment-1071315988 @Jackie-Jiang @richardstartin I have added the unit-tests as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pinot] etadelta222 commented on issue #6297: Adding Pinot Redash integration

2022-03-18 Thread GitBox
etadelta222 commented on issue #6297: URL: https://github.com/apache/pinot/issues/6297#issuecomment-1071159036 Hi @xiangfu0 , I'm trying to get this open pr approved on Redash (https://github.com/getredash/redash/pull/5446). This query runner is compatible with which version of Pinot? --

[GitHub] [pinot] Jackie-Jiang commented on pull request #8331: Support NOT LIKE and NOT BETWEEN

2022-03-18 Thread GitBox
Jackie-Jiang commented on pull request #8331: URL: https://github.com/apache/pinot/pull/8331#issuecomment-1072022674 Related to #7701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pinot] icefury71 merged pull request #8273: Add prefixesToRename config for renaming fields upon ingestion

2022-03-18 Thread GitBox
icefury71 merged pull request #8273: URL: https://github.com/apache/pinot/pull/8273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829187138 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/StageNode.java ## @@ -0,0 +1,37 @@ +/** + * Licensed to the Ap

[GitHub] [pinot] richardstartin commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r830054309 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNullTransformFunction.java ## @@ -0,0 +1,97 @@ +/** + * L

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8367: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8367: URL: https://github.com/apache/pinot/pull/8367#issuecomment-1072075697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] egalpin commented on issue #8353: Provide a way to group by an entire multi value field

2022-03-18 Thread GitBox
egalpin commented on issue #8353: URL: https://github.com/apache/pinot/issues/8353#issuecomment-1071971565 You might be able to achieve this behaviour today using Ingestion Transforms. If you had a transform which sorted (depending on whether order of values matters in your use case) the e

[GitHub] [pinot] walterddr commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829212117 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java ## @@ -0,0 +1,55 @@ +/** + * Licensed to the Ap

[GitHub] [pinot] codecov-commenter commented on pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-18 Thread GitBox
codecov-commenter commented on pull request #8364: URL: https://github.com/apache/pinot/pull/8364#issuecomment-1071540686 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] KKcorps commented on a change in pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
KKcorps commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r828766021 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java ## @@ -57,12 +57,20 @@ public Lit

[GitHub] [pinot] kkrugler commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
kkrugler commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829485698 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8304: URL: https://github.com/apache/pinot/pull/8304#issuecomment-1066731691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] richardstartin commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829533085 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(Strin

[GitHub] [pinot] richardstartin commented on a change in pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8264: URL: https://github.com/apache/pinot/pull/8264#discussion_r830054309 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsNullTransformFunction.java ## @@ -0,0 +1,97 @@ +/** + * L

[GitHub] [pinot] walterddr commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
walterddr commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829638811 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-18 Thread GitBox
codecov-commenter edited a comment on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] richardstartin commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-18 Thread GitBox
richardstartin commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829798759 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +262,38 @@ public static URL makeKeyStoreUrl(Strin

[pinot] branch master updated: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest (#8367)

2022-03-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 25cd6e3 Fix the flakiness of MultiNodesOfflineC

[GitHub] [pinot] xiangfu0 closed issue #8324: MultiNodesOfflineClusterIntegrationTest.testInstanceDecommission is flaky

2022-03-18 Thread GitBox
xiangfu0 closed issue #8324: URL: https://github.com/apache/pinot/issues/8324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [pinot] xiangfu0 merged pull request #8367: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest

2022-03-18 Thread GitBox
xiangfu0 merged pull request #8367: URL: https://github.com/apache/pinot/pull/8367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc