walterddr commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829212117
########## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner.nodes; + +import java.util.Collections; +import java.util.List; +import org.apache.calcite.rel.RelDistribution; + + +public class MailboxSendNode extends AbstractStageNode { Review comment: Yes I agree that we need to add more attributes to the stage nodes. should we consider start simple and add attributes to the `ExchangeNode`? to me the only thing we need to separate is `SendExchangeNode` and `ReceiveExchangeNode`. the items you mentioned above can be inferred by the `Exchange.Type` e.g. a `SendExchangeNode` with `Exchange.Type == BROADCAST` result in a broadcastSender and correspondingly the receiving side result in an UnorderedReceiver. ########## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner.nodes; + +import java.util.Collections; +import java.util.List; +import org.apache.calcite.rel.RelDistribution; + + +public class MailboxSendNode extends AbstractStageNode { Review comment: Yes I agree that we need to add more attributes to the stage nodes. should we consider start simple and add attributes to the `ExchangeNode`? to me the only thing we need to separate is `SendExchangeNode` and `ReceiveExchangeNode`. the items you mentioned above can be inferred by the `Exchange.Type` - e.g. a `SendExchangeNode` with `Exchange.Type == BROADCAST` result in a broadcastSender benefit of having this is we can add more attributes to the `ExchangeNode` without exploding the combination of possible attributes. say later we want to have a `HashPartitionButOrderedWithinPartitionSender` ########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java ########## @@ -616,4 +620,14 @@ void refreshSegment(String segment) { } } } + + @Override + public Map<String, ServerInstance> getEnabledServerInstanceMap() { + return new HashMap<>(_enabledServerInstanceMap); Review comment: at this moment no but there's a chance the enabledServerInstanceMap changed during cluster change handler that modifies the routing table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
