[GitHub] [pinot] codecov-commenter edited a comment on pull request #8093: Allow quickstart to get table files from filesystem.

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8093: URL: https://github.com/apache/pinot/pull/8093#issuecomment-1024840831 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8093: Allow quickstart to get table files from filesystem.

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8093: URL: https://github.com/apache/pinot/pull/8093#issuecomment-1024840831 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8093: Allow quickstart to get table files from filesystem.

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8093: URL: https://github.com/apache/pinot/pull/8093#issuecomment-1024840831 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8093: Allow quickstart to get table files from filesystem.

2022-01-28 Thread GitBox
codecov-commenter commented on pull request #8093: URL: https://github.com/apache/pinot/pull/8093#issuecomment-1024840831 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] amrishlal commented on pull request #8093: Allow quickstart to get table files from filesystem.

2022-01-28 Thread GitBox
amrishlal commented on pull request #8093: URL: https://github.com/apache/pinot/pull/8093#issuecomment-1024836788 @xiangfu0 Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pinot] amrishlal opened a new pull request #8093: Allow quickstart to get table files from filesystem.

2022-01-28 Thread GitBox
amrishlal opened a new pull request #8093: URL: https://github.com/apache/pinot/pull/8093 ## Description Add command line option -bootstrapTableDir that will allow Quickstart to load table schema, config, and data files from a directory on the filesystem. This option along with the rece

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8082: Listener TLS customization

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8082: URL: https://github.com/apache/pinot/pull/8082#issuecomment-1024807257 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8082: Listener TLS customization

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8082: URL: https://github.com/apache/pinot/pull/8082#issuecomment-1024807257 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] apucher commented on issue #8041: Need Help - Realtime table | External Kafka Topic Configuration with SSL

2022-01-28 Thread GitBox
apucher commented on issue #8041: URL: https://github.com/apache/pinot/issues/8041#issuecomment-1024811050 Have you tried using an absolute path for key and trust store as suggested above? if not, you could also ping the Apache Pinot Slack Community here: https://communityinviter.co

[GitHub] [pinot] ImAbhishekTomar commented on issue #8041: Need Help - Realtime table | External Kafka Topic Configuration with SSL

2022-01-28 Thread GitBox
ImAbhishekTomar commented on issue #8041: URL: https://github.com/apache/pinot/issues/8041#issuecomment-1024810461 registry hosted on http and https both and I tried but nothing is working in config. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8082: Listener TLS customization

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8082: URL: https://github.com/apache/pinot/pull/8082#issuecomment-1024807257 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8082: Listener TLS customization

2022-01-28 Thread GitBox
codecov-commenter commented on pull request #8082: URL: https://github.com/apache/pinot/pull/8082#issuecomment-1024807257 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[pinot] branch listener-tls-customization updated (1148538 -> 29e4860)

2022-01-28 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch listener-tls-customization in repository https://gitbox.apache.org/repos/asf/pinot.git. from 1148538 allow null defaults add 29e4860 java8 optional method No new revisions were added

[pinot] branch listener-tls-customization updated (88f040a -> 1148538)

2022-01-28 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch listener-tls-customization in repository https://gitbox.apache.org/repos/asf/pinot.git. from 88f040a update POM add 1148538 allow null defaults No new revisions were added by this up

[pinot] branch listener-tls-customization updated (3633704 -> 88f040a)

2022-01-28 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch listener-tls-customization in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 3633704 controller working discard 7a18a16 prototype add c8dde9b allow JSON forward inde

[GitHub] [pinot] ksnijjer commented on issue #8091: table creation shouldn't be allowed if table delete is happening async in background

2022-01-28 Thread GitBox
ksnijjer commented on issue #8091: URL: https://github.com/apache/pinot/issues/8091#issuecomment-1024699296 For the user issue that we saw, table information was gone from EV/IS however entries were still left(controller seemed to die/restart in the middle) in ZK>PropertyStore(Table def. a

[GitHub] [pinot] bowen-stripe commented on issue #8011: Pinot offline table refresh impacts query latency

2022-01-28 Thread GitBox
bowen-stripe commented on issue #8011: URL: https://github.com/apache/pinot/issues/8011#issuecomment-1024696420 Update: this appeared to be a (lack-of) memory issue. After scaling up the cluster by 2x, # of page swap went down significantly. Closing this for now. -- This is an automated

[GitHub] [pinot] bowen-stripe closed issue #8011: Pinot offline table refresh impacts query latency

2022-01-28 Thread GitBox
bowen-stripe closed issue #8011: URL: https://github.com/apache/pinot/issues/8011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794904539 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java ## @@ -62,31 +68,164 @@ public AggregationPlanNode(IndexSeg

[GitHub] [pinot] walterddr commented on issue #8091: table creation shouldn't be allowed if table delete is happening async in background

2022-01-28 Thread GitBox
walterddr commented on issue #8091: URL: https://github.com/apache/pinot/issues/8091#issuecomment-1024663985 sweet. thanks for referring to #7711. is it a duplicate entirely? i think we can close this one if it is -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] mcvsubbu commented on issue #8091: table creation shouldn't be allowed if table delete is happening async in background

2022-01-28 Thread GitBox
mcvsubbu commented on issue #8091: URL: https://github.com/apache/pinot/issues/8091#issuecomment-1024661280 During deletion: - Start the deletion process and wait until the table goes away from EXTRERNALVIEW During table creation: - Verify that the table does not exist in IDEAL

[GitHub] [pinot] mcvsubbu commented on issue #8091: table creation shouldn't be allowed if table delete is happening async in background

2022-01-28 Thread GitBox
mcvsubbu commented on issue #8091: URL: https://github.com/apache/pinot/issues/8091#issuecomment-1024660259 Related to Issue #7711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] walterddr opened a new issue #8092: should SegmentDeletionManager expose the 2 public APIs?

2022-01-28 Thread GitBox
walterddr opened a new issue #8092: URL: https://github.com/apache/pinot/issues/8092 Currently SegmentDeletionManager has 1. a `deleteSegments` API that allows users to delete segments from property store and from deep store. 2. a `removeSegmentsFromStore` API that allows users to on

[GitHub] [pinot] mcvsubbu commented on issue #3451: Stabilize stream consumption before routing queries to servers

2022-01-28 Thread GitBox
mcvsubbu commented on issue #3451: URL: https://github.com/apache/pinot/issues/3451#issuecomment-1024657322 @sajjad-moradi can this issue be closed now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794900915 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/query/FilteredAggregationOperator.java ## @@ -0,0 +1,116 @@ +/** + * Licensed to

[GitHub] [pinot] walterddr opened a new issue #8091: table creation shouldn't be allowed if table delete is happening async in background

2022-01-28 Thread GitBox
walterddr opened a new issue #8091: URL: https://github.com/apache/pinot/issues/8091 Currently table is deleted first and the segments were deleted async behind the scene. however if the controller died during the async deletion and got restarted. User can call the API to create an

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8078: Segment retention for table

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8078: URL: https://github.com/apache/pinot/pull/8078#issuecomment-1024492127 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8078?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[pinot] branch master updated (3f11902 -> dd73ee7)

2022-01-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 3f11902 also add schema test in fields for default values and others (#8088) add dd73ee7 add logic to instant

[GitHub] [pinot] Jackie-Jiang merged pull request #8077: add logic to instant delete segment

2022-01-28 Thread GitBox
Jackie-Jiang merged pull request #8077: URL: https://github.com/apache/pinot/pull/8077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794876398 ## File path: pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMutableFST.java ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] [pinot] amrishlal commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
amrishlal commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794846839 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/query/FilteredAggregationOperator.java ## @@ -0,0 +1,116 @@ +/** + * Licensed to th

[GitHub] [pinot] aditya-pt opened a new issue #8090: Partitioned replica group assignment fails if "numReplicaGroups": 1

2022-01-28 Thread GitBox
aditya-pt opened a new issue #8090: URL: https://github.com/apache/pinot/issues/8090 If we create replicaGroupPartitionConfig config as below with `"numReplicaGroups": 1` ``` "replicaGroupPartitionConfig": { "replicaGroupBased": true, "numInstance

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7997: URL: https://github.com/apache/pinot/pull/7997#issuecomment-1012699644 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7997: URL: https://github.com/apache/pinot/pull/7997#issuecomment-1012699644 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8077: add logic to instant delete segment

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8077: URL: https://github.com/apache/pinot/pull/8077#issuecomment-1023439234 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8077?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] richardstartin commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
richardstartin commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794771583 ## File path: pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMutableFST.java ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] atris commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
atris commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794762474 ## File path: pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMutableFST.java ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8088: also add schema test in fields for default values and others

2022-01-28 Thread GitBox
xiangfu0 commented on a change in pull request #8088: URL: https://github.com/apache/pinot/pull/8088#discussion_r794761711 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/SchemaTest.java ## @@ -213,15 +216,35 @@ public void testFetchFieldSpecForTime() {

[GitHub] [pinot] xiangfu0 commented on pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
xiangfu0 commented on pull request #7997: URL: https://github.com/apache/pinot/pull/7997#issuecomment-1024494385 > Hi @xiangfu0, do you have any updates regarding this PR? 🙂 Overall lgtm, just wanna change the enable flag name for future update, others are fine. -- This is an auto

[GitHub] [pinot] codecov-commenter commented on pull request #8078: Segment retention for table

2022-01-28 Thread GitBox
codecov-commenter commented on pull request #8078: URL: https://github.com/apache/pinot/pull/8078#issuecomment-1024492127 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8078?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] mqliang commented on a change in pull request #8083: Timeout if waiting server channel lock takes a long time

2022-01-28 Thread GitBox
mqliang commented on a change in pull request #8083: URL: https://github.com/apache/pinot/pull/8083#discussion_r794751966 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java ## @@ -139,22 +143,33 @@ private void attachSSLHandler(SocketCha

[GitHub] [pinot] xtrntr opened a new issue #8089: Truncated results when using GROUP BY on a high cardinality column

2022-01-28 Thread GitBox
xtrntr opened a new issue #8089: URL: https://github.com/apache/pinot/issues/8089 ## Description `userid` is an INT column with a cardinality of >8M, from 1 to 8,XXX,XXX TABLE has total of 3,192,209,696 rows. TABLE has 70 segments distributed over 4 servers running on Pi

[pinot] branch master updated (0fe7ef8 -> 3f11902)

2022-01-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 0fe7ef8 Remove PQL response parser in quickstart (#8081) add 3f11902 also add schema test in fields for default

[GitHub] [pinot] Jackie-Jiang merged pull request #8088: also add schema test in fields for default values and others

2022-01-28 Thread GitBox
Jackie-Jiang merged pull request #8088: URL: https://github.com/apache/pinot/pull/8088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter commented on pull request #8088: also add schema test in fields for default values and others

2022-01-28 Thread GitBox
codecov-commenter commented on pull request #8088: URL: https://github.com/apache/pinot/pull/8088#issuecomment-1024440738 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8088?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] moszutij commented on pull request #8087: Support for TIMESTAMP data type in Configuration Recommendation Engin…

2022-01-28 Thread GitBox
moszutij commented on pull request #8087: URL: https://github.com/apache/pinot/pull/8087#issuecomment-1024387199 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [pinot] walterddr commented on a change in pull request #8088: also add schema test in fields for default values and others

2022-01-28 Thread GitBox
walterddr commented on a change in pull request #8088: URL: https://github.com/apache/pinot/pull/8088#discussion_r794654162 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/SchemaTest.java ## @@ -213,15 +216,35 @@ public void testFetchFieldSpecForTime() {

[GitHub] [pinot] walterddr opened a new pull request #8088: also add schema test in fields for default values and others

2022-01-28 Thread GitBox
walterddr opened a new pull request #8088: URL: https://github.com/apache/pinot/pull/8088 Follow up on #8080. which only tested in SerDe. this explicitly add tests on different underlying data type. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pinot] mneedham commented on issue #8084: Min identified as aggregation function instead of transform function

2022-01-28 Thread GitBox
mneedham commented on issue #8084: URL: https://github.com/apache/pinot/issues/8084#issuecomment-1024342611 Got it, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8087: Support for TIMESTAMP data type in Configuration Recommendation Engin…

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8087: URL: https://github.com/apache/pinot/pull/8087#issuecomment-1024311144 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8087: Support for TIMESTAMP data type in Configuration Recommendation Engin…

2022-01-28 Thread GitBox
codecov-commenter commented on pull request #8087: URL: https://github.com/apache/pinot/pull/8087#issuecomment-1024311144 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] moszutij opened a new pull request #8087: Support for TIMESTAMP data type in Configuration Recommendation Engin…

2022-01-28 Thread GitBox
moszutij opened a new pull request #8087: URL: https://github.com/apache/pinot/pull/8087 …e (#8086) ## Description Allows the configuration recommendation engine to generate a sample segment for a schema that contains a field with a TIMESTAMP data type. The sample segment is then

[GitHub] [pinot] richardstartin commented on issue #8084: Min identified as aggregation function instead of transform function

2022-01-28 Thread GitBox
richardstartin commented on issue #8084: URL: https://github.com/apache/pinot/issues/8084#issuecomment-1024272235 > Pinot has two different `min` functions. There's the aggregation function that you mention, but there is also a scalar function defined here - https://github.com/apache/pinot

[GitHub] [pinot] mneedham commented on issue #8084: Min identified as aggregation function instead of transform function

2022-01-28 Thread GitBox
mneedham commented on issue #8084: URL: https://github.com/apache/pinot/issues/8084#issuecomment-1024261109 Pinot has two different `min` functions. There's the aggregation function that you mention, but there is also a scalar function defined here - https://github.com/apache/pinot/blob/ma

[GitHub] [pinot] moszutij opened a new issue #8086: Support for TIMESTAMP data type in Configuration Recommendation Engine

2022-01-28 Thread GitBox
moszutij opened a new issue #8086: URL: https://github.com/apache/pinot/issues/8086 When I run the configuration recommendation engine on a schema that contains a field with a TIMESTAMP data type, the following error is thrown: `{ "_code": 400, "_error": "java.lang.IllegalA

[GitHub] [pinot] richardstartin commented on a change in pull request #8083: Timeout if waiting server channel lock takes a long time

2022-01-28 Thread GitBox
richardstartin commented on a change in pull request #8083: URL: https://github.com/apache/pinot/pull/8083#discussion_r794437614 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java ## @@ -139,22 +143,33 @@ private void attachSSLHandler(So

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] richardstartin commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
richardstartin commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794381262 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/query/FilteredAggregationOperator.java ## @@ -0,0 +1,116 @@ +/** + * Licensed

[GitHub] [pinot] richardstartin commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
richardstartin commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794377855 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/nativefst/utils/RealTimeRegexpMatcher.java ## @@ -0,0 +1,156 @@

[GitHub] [pinot] richardstartin commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
richardstartin commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794375450 ## File path: pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMutableFST.java ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] atris commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
atris commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794371555 ## File path: pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMutableFST.java ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8016: URL: https://github.com/apache/pinot/pull/8016#issuecomment-1012898899 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8016?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8016: URL: https://github.com/apache/pinot/pull/8016#issuecomment-1012898899 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8016?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #8016: URL: https://github.com/apache/pinot/pull/8016#issuecomment-1012898899 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8016?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] richardstartin opened a new issue #8085: Add `least` and `greatest` functions

2022-01-28 Thread GitBox
richardstartin opened a new issue #8085: URL: https://github.com/apache/pinot/issues/8085 `least(1,2,3,4,5);` yields 1 `greatest(1,2,3,4,5);` yields 5 | foo | bar | | | --- | | 1 | 0 | | 2 | 1 | | 5 | 4 | | 6 | 7 | `least(

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
codecov-commenter edited a comment on pull request #7916: URL: https://github.com/apache/pinot/pull/7916#issuecomment-996061423 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
xiangfu0 commented on a change in pull request #7997: URL: https://github.com/apache/pinot/pull/7997#discussion_r794328610 ## File path: kubernetes/helm/pinot/templates/controller/ingress.yaml ## @@ -0,0 +1,30 @@ +{{- if .Values.controller.ingress.enabled -}} +{{- $ingressPath

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
xiangfu0 commented on a change in pull request #7997: URL: https://github.com/apache/pinot/pull/7997#discussion_r794328610 ## File path: kubernetes/helm/pinot/templates/controller/ingress.yaml ## @@ -0,0 +1,30 @@ +{{- if .Values.controller.ingress.enabled -}} +{{- $ingressPath

[GitHub] [pinot] richardstartin commented on issue #8084: Min identified as aggregation function instead of transform function

2022-01-28 Thread GitBox
richardstartin commented on issue #8084: URL: https://github.com/apache/pinot/issues/8084#issuecomment-1024031807 `min` _is_ an aggregation function in SQL. I think you're trying to use it like `least` (`max`: `greatest`) which isn't implemented in Pinot. -- This is an automated message

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
xiangfu0 commented on a change in pull request #7997: URL: https://github.com/apache/pinot/pull/7997#discussion_r794328610 ## File path: kubernetes/helm/pinot/templates/controller/ingress.yaml ## @@ -0,0 +1,30 @@ +{{- if .Values.controller.ingress.enabled -}} +{{- $ingressPath

[GitHub] [pinot] richardstartin commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
richardstartin commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794325117 ## File path: pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMutableFST.java ## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] mneedham opened a new issue #8084: Min identified as aggregation function instead of transform function

2022-01-28 Thread GitBox
mneedham opened a new issue #8084: URL: https://github.com/apache/pinot/issues/8084 When I try to use the `min` scalar function e.g. ``` select min(distance, 5) from courses limit 10 ``` It instead uses the aggregation function. i.e. it finds the minimum value acros

[GitHub] [pinot] atris commented on pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
atris commented on pull request #8016: URL: https://github.com/apache/pinot/pull/8016#issuecomment-1024023665 > I saw some unsolved comments. Please resolve them and wait for all tests pass before merging. > You might need to rebase to the latest master if the compatibility test against

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
xiangfu0 commented on a change in pull request #7997: URL: https://github.com/apache/pinot/pull/7997#discussion_r794318791 ## File path: kubernetes/helm/pinot/templates/controller/ingress.yaml ## @@ -0,0 +1,30 @@ +{{- if .Values.controller.ingress.enabled -}} +{{- $ingressPath

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7997: Add Ingress to Broker and Controller helm charts

2022-01-28 Thread GitBox
xiangfu0 commented on a change in pull request #7997: URL: https://github.com/apache/pinot/pull/7997#discussion_r794317969 ## File path: kubernetes/helm/pinot/templates/controller/ingress.yaml ## @@ -0,0 +1,30 @@ +{{- if .Values.controller.ingress.enabled -}} +{{- $ingressPath

[GitHub] [pinot] atris commented on a change in pull request #8016: Implement Real Time Mutable FST

2022-01-28 Thread GitBox
atris commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r794316102 ## File path: pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMutableFST.java ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] apucher edited a comment on issue #8041: Need Help - Realtime table | External Kafka Topic Configuration with SSL

2022-01-28 Thread GitBox
apucher edited a comment on issue #8041: URL: https://github.com/apache/pinot/issues/8041#issuecomment-1024010731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [pinot] apucher commented on issue #8041: Need Help - Realtime table | External Kafka Topic Configuration with SSL

2022-01-28 Thread GitBox
apucher commented on issue #8041: URL: https://github.com/apache/pinot/issues/8041#issuecomment-1024010731 Hi @ImAbhishekTomar - sorry for the late reply. I'm not an expert with kafka configs - one thing to try is to provide the key/truststore as an absolute `/opt/pinot/` rather than r

[GitHub] [pinot] atris commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
atris commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794305426 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/query/FilteredAggregationOperator.java ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Ap

[GitHub] [pinot] atris commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
atris commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794304693 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -441,76 +480,106 @@ public QueryContext build() {

[GitHub] [pinot] atris commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
atris commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794301294 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -119,11 +122,13 @@ private QueryContext(String tab

[GitHub] [pinot] ImAbhishekTomar commented on issue #8041: Need Help - Realtime table | External Kafka Topic Configuration with SSL

2022-01-28 Thread GitBox
ImAbhishekTomar commented on issue #8041: URL: https://github.com/apache/pinot/issues/8041#issuecomment-1024000262 need help on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pinot] atris commented on a change in pull request #7916: FILTER Clauses for Aggregates

2022-01-28 Thread GitBox
atris commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r794293449 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java ## @@ -154,4 +118,181 @@ private static boolean isFitForDictionar