walterddr opened a new issue #8092: URL: https://github.com/apache/pinot/issues/8092
Currently SegmentDeletionManager has 1. a `deleteSegments` API that allows users to delete segments from property store and from deep store. 2. a `removeSegmentsFromStore` API that allows users to only delete from deep store. This creates confusion regarding failure recovery, when the component service dies in the middle of the execution, they can either result in - using `deleteSegments`, property store could've deleted segment A, but file still exist in deep store - using `removeSegmentsFromStore`, segment A's file could've been deleted from deep store, but property store could still have segment A. Which one should we go with as failure recovery strategy? From the point that we have a retention manager that periodically checks deep store for files to delete, I think we should always first delete from property store and next delete from deep store. thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
