[GitHub] [pinot] codecov-commenter edited a comment on pull request #7950: fix grpc broker request handler not started correctly issue

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7950: URL: https://github.com/apache/pinot/pull/7950#issuecomment-999778438 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7950?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7950: fix grpc broker request handler not started correctly issue

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7950: URL: https://github.com/apache/pinot/pull/7950#issuecomment-999778438 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7950?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] walterddr commented on a change in pull request #7950: fix grpc broker request handler not started correctly issue

2021-12-22 Thread GitBox
walterddr commented on a change in pull request #7950: URL: https://github.com/apache/pinot/pull/7950#discussion_r774291763 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/GrpcBrokerClusterIntegrationTest.java ## @@ -105,7 +105,7 @@ prote

[GitHub] [pinot] walterddr closed pull request #7911: add GRPC E2E support for more reducers

2021-12-22 Thread GitBox
walterddr closed pull request #7911: URL: https://github.com/apache/pinot/pull/7911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pinot] walterddr commented on pull request #7911: add GRPC E2E support for more reducers

2021-12-22 Thread GitBox
walterddr commented on pull request #7911: URL: https://github.com/apache/pinot/pull/7911#issuecomment-112120 closing for now. @Jackie-Jiang and I discussed offline and felt like we don't really need the streaming processing in the non-selection-only situation. we will close this and c

[GitHub] [pinot] dongxiaoman commented on issue #7779: Real time tiered storage feature causing temporary offline segments

2021-12-22 Thread GitBox
dongxiaoman commented on issue #7779: URL: https://github.com/apache/pinot/issues/7779#issuecomment-62600 The replication factor is 2. At the time of this error being reported, we had enforced the rule in our Pinot Java Client to throw exception whenever there is one segment not bein

[GitHub] [pinot] dongxiaoman closed issue #7779: Real time tiered storage feature causing temporary offline segments

2021-12-22 Thread GitBox
dongxiaoman closed issue #7779: URL: https://github.com/apache/pinot/issues/7779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7893: [7338] Allow Reloading Segments with Multiple Threads

2021-12-22 Thread GitBox
Jackie-Jiang commented on a change in pull request #7893: URL: https://github.com/apache/pinot/pull/7893#discussion_r774225405 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java ## @@ -212,36 +218,56 @@ public void relo

[pinot] branch master updated: switch to latest zookeeper (#7955)

2021-12-22 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b6eeaf3 switch to latest zookeeper (#7955) b6ee

[GitHub] [pinot] xiangfu0 merged pull request #7955: Switch to zookeeper of helm 3.0x

2021-12-22 Thread GitBox
xiangfu0 merged pull request #7955: URL: https://github.com/apache/pinot/pull/7955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch master updated (652cc98 -> 2b25ede)

2021-12-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 652cc98 realtime debug logging (#7946) add 2b25ede use a single react hook for table status modal (#7952) No n

[GitHub] [pinot] Jackie-Jiang merged pull request #7952: use a single react hook for table status modal

2021-12-22 Thread GitBox
Jackie-Jiang merged pull request #7952: URL: https://github.com/apache/pinot/pull/7952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7950: fix grpc broker request handler not started correctly issue

2021-12-22 Thread GitBox
Jackie-Jiang commented on a change in pull request #7950: URL: https://github.com/apache/pinot/pull/7950#discussion_r774215580 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/GrpcBrokerClusterIntegrationTest.java ## @@ -105,7 +105,9 @@ pr

[GitHub] [pinot] dongxiaoman commented on a change in pull request #7955: Switch to zookeeper of helm 3.0x

2021-12-22 Thread GitBox
dongxiaoman commented on a change in pull request #7955: URL: https://github.com/apache/pinot/pull/7955#discussion_r774213803 ## File path: kubernetes/helm/pinot/README.md ## @@ -398,6 +398,7 @@ following configurable parameters: | `zookeeper.resources`

[GitHub] [pinot] dongxiaoman opened a new pull request #7955: Switch to zookeeper of helm 3.0x

2021-12-22 Thread GitBox
dongxiaoman opened a new pull request #7955: URL: https://github.com/apache/pinot/pull/7955 ## Description Fix the issue that the local quick-start zookeeper cannot find docker image anymore. It is because the latest zookeeper image version(tag) via Helm 2.x is deleted (my guess

[GitHub] [pinot] dang-stripe opened a new issue #7954: Clean up unused tmp segment directories

2021-12-22 Thread GitBox
dang-stripe opened a new issue #7954: URL: https://github.com/apache/pinot/issues/7954 We noticed some of our pinot servers had many `tmp` directories taking up lots of disk space. This seemed to happen after the process was interrupted or killed while trying to unpack a segment here: htt

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7918: Fix query parameter URL encoding bug and ByteArray datatype bug

2021-12-22 Thread GitBox
siddharthteotia commented on a change in pull request #7918: URL: https://github.com/apache/pinot/pull/7918#discussion_r774150730 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java ## @@ -210,14 +212,15 @@ public String getSegmen

[GitHub] [pinot] richardstartin commented on pull request #7949: unpeel group by 3 ways to enable vectorization

2021-12-22 Thread GitBox
richardstartin commented on pull request #7949: URL: https://github.com/apache/pinot/pull/7949#issuecomment-999831652 @kishoreg it's still a draft, I know that the 2D special case is integer multiples faster, but I made a mistake with the 3D case and need to reevaluate. -- This is an aut

[GitHub] [pinot] aleksdikanski edited a comment on issue #7270: Fix the issue with "pinot-pulsar" module (potentially library conflicts)

2021-12-22 Thread GitBox
aleksdikanski edited a comment on issue #7270: URL: https://github.com/apache/pinot/issues/7270#issuecomment-999822891 @KKcorps thanks I tested your changes and I don't get any errors regarding the MessageId anymore. The messages are now correctly consumed by pinot. > There was a

[GitHub] [pinot] aleksdikanski edited a comment on issue #7270: Fix the issue with "pinot-pulsar" module (potentially library conflicts)

2021-12-22 Thread GitBox
aleksdikanski edited a comment on issue #7270: URL: https://github.com/apache/pinot/issues/7270#issuecomment-999822891 @KKcorps thanks I tested your changes and I don't get any errors regarding the MessageId anymore. The messages are now correctly consumed by pinot. > There was a

[GitHub] [pinot] mapshen commented on issue #7850: Segment replicas leading to split query views

2021-12-22 Thread GitBox
mapshen commented on issue #7850: URL: https://github.com/apache/pinot/issues/7850#issuecomment-999826256 > > The consumption catch-up wait time leads to the split views described at the beginning, doesn't it? That's why we are have these conversations. > > Not really. The server doe

[GitHub] [pinot] aleksdikanski closed pull request #7917: create pulsar MessageId from toString representation

2021-12-22 Thread GitBox
aleksdikanski closed pull request #7917: URL: https://github.com/apache/pinot/pull/7917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [pinot] aleksdikanski commented on issue #7270: Fix the issue with "pinot-pulsar" module (potentially library conflicts)

2021-12-22 Thread GitBox
aleksdikanski commented on issue #7270: URL: https://github.com/apache/pinot/issues/7270#issuecomment-999822891 @KKcorps thanks I tested your changes and I don't get any errors regarding the MessageId anymore. The messages are now correctly consumed by pinot. -- This is an automated

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7953: [draft] initial broker streaming service

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7953: URL: https://github.com/apache/pinot/pull/7953#issuecomment-999808566 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7949: unpeel group by 3 ways to enable vectorization

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7949: URL: https://github.com/apache/pinot/pull/7949#issuecomment-999813160 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7949: unpeel group by 3 ways to enable vectorization

2021-12-22 Thread GitBox
codecov-commenter commented on pull request #7949: URL: https://github.com/apache/pinot/pull/7949#issuecomment-999813160 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7953: [draft] initial broker streaming service

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7953: URL: https://github.com/apache/pinot/pull/7953#issuecomment-999808566 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7953: [draft] initial broker streaming service

2021-12-22 Thread GitBox
codecov-commenter commented on pull request #7953: URL: https://github.com/apache/pinot/pull/7953#issuecomment-999808566 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] richardstartin commented on pull request #7934: Power of 2 fixed size chunks

2021-12-22 Thread GitBox
richardstartin commented on pull request #7934: URL: https://github.com/apache/pinot/pull/7934#issuecomment-999800932 What are the blockers here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pinot] richardstartin commented on pull request #7920: faster metric scans

2021-12-22 Thread GitBox
richardstartin commented on pull request #7920: URL: https://github.com/apache/pinot/pull/7920#issuecomment-999800762 This feels like a fairly low risk change for a decent improvement to me. Are there any blockers here? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pinot] richardstartin commented on pull request #7951: remove stray Nullable annotation

2021-12-22 Thread GitBox
richardstartin commented on pull request #7951: URL: https://github.com/apache/pinot/pull/7951#issuecomment-999800220 @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7951: remove stray Nullable annotation

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7951: URL: https://github.com/apache/pinot/pull/7951#issuecomment-999781009 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7951?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7952: use a single react hook for table status modal

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7952: URL: https://github.com/apache/pinot/pull/7952#issuecomment-999779761 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] sajjad-moradi commented on pull request #7927: Fix realtime ingestion when an entire batch of messages is filtered out

2021-12-22 Thread GitBox
sajjad-moradi commented on pull request #7927: URL: https://github.com/apache/pinot/pull/7927#issuecomment-999788784 @richardstartin I don't want to get to details here. My point was that one PR should focus on one thing, not more! -- This is an automated message from the Apache Git Serv

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7920: faster metric scans

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7920: URL: https://github.com/apache/pinot/pull/7920#issuecomment-996718083 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7952: use a single react hook for table status modal

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7952: URL: https://github.com/apache/pinot/pull/7952#issuecomment-999779761 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7920: faster metric scans

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7920: URL: https://github.com/apache/pinot/pull/7920#issuecomment-996718083 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7951: remove stray Nullable annotation

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7951: URL: https://github.com/apache/pinot/pull/7951#issuecomment-999781009 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7951?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7952: use a single react hook for table status modal

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7952: URL: https://github.com/apache/pinot/pull/7952#issuecomment-999779761 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7951: remove stray Nullable annotation

2021-12-22 Thread GitBox
codecov-commenter commented on pull request #7951: URL: https://github.com/apache/pinot/pull/7951#issuecomment-999781009 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7951?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7950: fix broker request handler not started correctly issue

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7950: URL: https://github.com/apache/pinot/pull/7950#issuecomment-999778438 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7950?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7952: use a single react hook for table status modal

2021-12-22 Thread GitBox
codecov-commenter commented on pull request #7952: URL: https://github.com/apache/pinot/pull/7952#issuecomment-999779761 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter commented on pull request #7950: fix broker request handler not started correctly issue

2021-12-22 Thread GitBox
codecov-commenter commented on pull request #7950: URL: https://github.com/apache/pinot/pull/7950#issuecomment-999778438 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7950?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] dongxiaoman commented on issue #7612: Pinot query ArrayIndexOutOfBounds for some multi-value column queries

2021-12-22 Thread GitBox
dongxiaoman commented on issue #7612: URL: https://github.com/apache/pinot/issues/7612#issuecomment-999774558 Forgot to close it. Happens only to one segment that is probably generated by some version of library that may have issues. -- This is an automated message from the Apache Git Se

[GitHub] [pinot] dongxiaoman closed issue #7612: Pinot query ArrayIndexOutOfBounds for some multi-value column queries

2021-12-22 Thread GitBox
dongxiaoman closed issue #7612: URL: https://github.com/apache/pinot/issues/7612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[pinot] branch master updated: realtime debug logging (#7946)

2021-12-22 Thread mayanks
This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 652cc98 realtime debug logging (#7946) 652cc98

[GitHub] [pinot] mayankshriv merged pull request #7946: realtime debug logging

2021-12-22 Thread GitBox
mayankshriv merged pull request #7946: URL: https://github.com/apache/pinot/pull/7946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pinot] branch master updated: log query exception by using correct slf4j overload (#7948)

2021-12-22 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f2eb2fd log query exception by using correct s

[GitHub] [pinot] kishoreg merged pull request #7948: log query exception by using correct slf4j overload

2021-12-22 Thread GitBox
kishoreg merged pull request #7948: URL: https://github.com/apache/pinot/pull/7948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] jadami10 opened a new pull request #7952: use a single react hook for table status modal

2021-12-22 Thread GitBox
jadami10 opened a new pull request #7952: URL: https://github.com/apache/pinot/pull/7952 ## Description Apologies for the issues here. This is hopefully the last bug here and a quirk with react hooks and keys I was not aware of. - React keys need to be unique. I'm just removing t

[GitHub] [pinot] richardstartin opened a new pull request #7951: remove stray Nullable annotation

2021-12-22 Thread GitBox
richardstartin opened a new pull request #7951: URL: https://github.com/apache/pinot/pull/7951 this field isn't nullable and creates warnings in plugins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7920: faster metric scans

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7920: URL: https://github.com/apache/pinot/pull/7920#issuecomment-996718083 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] walterddr opened a new pull request #7950: fix broker request handler not started correctly issue

2021-12-22 Thread GitBox
walterddr opened a new pull request #7950: URL: https://github.com/apache/pinot/pull/7950 broker request handler test is not started correctly with proper configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7945: Fix QuerySchedulerFactory to plug in custom scheduler

2021-12-22 Thread GitBox
mcvsubbu commented on a change in pull request #7945: URL: https://github.com/apache/pinot/pull/7945#discussion_r774049415 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QuerySchedulerFactory.java ## @@ -89,12 +96,16 @@ public static QuerySchedule

[GitHub] [pinot] richardstartin opened a new pull request #7949: unpeel group by 3 ways to enable vectorization

2021-12-22 Thread GitBox
richardstartin opened a new pull request #7949: URL: https://github.com/apache/pinot/pull/7949 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward-incompa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7948: log query exception by using correct slf4j overload

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7948: URL: https://github.com/apache/pinot/pull/7948#issuecomment-999704843 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7948?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7948: log query exception by using correct slf4j overload

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7948: URL: https://github.com/apache/pinot/pull/7948#issuecomment-999704843 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7948?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7948: log query exception by using correct slf4j overload

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7948: URL: https://github.com/apache/pinot/pull/7948#issuecomment-999704843 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7948?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7948: log query exception by using correct slf4j overload

2021-12-22 Thread GitBox
codecov-commenter commented on pull request #7948: URL: https://github.com/apache/pinot/pull/7948#issuecomment-999704843 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7948?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] richardstartin commented on a change in pull request #7946: realtime debug logging

2021-12-22 Thread GitBox
richardstartin commented on a change in pull request #7946: URL: https://github.com/apache/pinot/pull/7946#discussion_r774002113 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -458,7 +467,10 @@ private

[GitHub] [pinot] klsince commented on a change in pull request #7946: realtime debug logging

2021-12-22 Thread GitBox
klsince commented on a change in pull request #7946: URL: https://github.com/apache/pinot/pull/7946#discussion_r774001534 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -458,7 +467,10 @@ private void p

[GitHub] [pinot] richardstartin opened a new pull request #7948: log query exception by using correct slf4j overload

2021-12-22 Thread GitBox
richardstartin opened a new pull request #7948: URL: https://github.com/apache/pinot/pull/7948 This selects the wrong overload so we lose the stack trace e.g. ``` Caught exception while processing query: QueryContext{_tableName='ads_metrics_REALTIME', _selectExpressions=[listing_

[GitHub] [pinot] KKcorps commented on issue #7270: Fix the issue with "pinot-pulsar" module (potentially library conflicts)

2021-12-22 Thread GitBox
KKcorps commented on issue #7270: URL: https://github.com/apache/pinot/issues/7270#issuecomment-999570676 @aleksdikanski https://github.com/apache/pinot/pull/7947 can you try this and see if it is working on your end. It is working on my end. There was also a corrupt `\n` in your airline d

[GitHub] [pinot] KKcorps opened a new pull request #7947: Store Pulsar message id as hex string instead of .toString format

2021-12-22 Thread GitBox
KKcorps opened a new pull request #7947: URL: https://github.com/apache/pinot/pull/7947 This PR addresses the issue #7223 . The message id is not parsed correctly when data is consumed from Pulsar topic. This is because message id can have multiple string formats. The solution is to store

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7946: realtime debug logging

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7946: URL: https://github.com/apache/pinot/pull/7946#issuecomment-999541957 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7946: realtime debug logging

2021-12-22 Thread GitBox
codecov-commenter commented on pull request #7946: URL: https://github.com/apache/pinot/pull/7946#issuecomment-999541957 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] richardstartin opened a new pull request #7946: realtime debug logging

2021-12-22 Thread GitBox
richardstartin opened a new pull request #7946: URL: https://github.com/apache/pinot/pull/7946 @mayankshriv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7893: [7338] Allow Reloading Segments with Multiple Threads

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #7893: URL: https://github.com/apache/pinot/pull/7893#issuecomment-991893066 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7893?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T