mcvsubbu commented on a change in pull request #7945:
URL: https://github.com/apache/pinot/pull/7945#discussion_r774049415
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QuerySchedulerFactory.java
##########
@@ -89,12 +96,16 @@ public static QueryScheduler create(PinotConfiguration
schedulerConfig, QueryExe
@Nullable
private static QueryScheduler getQuerySchedulerByClassName(String className,
PinotConfiguration schedulerConfig,
- QueryExecutor queryExecutor) {
+ QueryExecutor queryExecutor, ServerMetrics serverMetrics,
LongAccumulator latestQueryTime) {
try {
- Constructor<?> constructor =
- Class.forName(className).getDeclaredConstructor(Configuration.class,
QueryExecutor.class);
+ Constructor<?> constructor = Class.forName(className)
+ .getDeclaredConstructor(PinotConfiguration.class,
QueryExecutor.class, ServerMetrics.class,
+ LongAccumulator.class);
constructor.setAccessible(true);
- return (QueryScheduler) constructor.newInstance(schedulerConfig,
queryExecutor);
+ QueryScheduler queryScheduler =
+ (QueryScheduler) constructor.newInstance(schedulerConfig,
queryExecutor, serverMetrics, latestQueryTime);
+ LOGGER.info("Using {} scheduler", queryScheduler.name());
Review comment:
maybe move this log statement to line 81 (and perhaps use a single log
statement at the end of the switch there?)
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QuerySchedulerFactory.java
##########
@@ -89,12 +96,16 @@ public static QueryScheduler create(PinotConfiguration
schedulerConfig, QueryExe
@Nullable
private static QueryScheduler getQuerySchedulerByClassName(String className,
PinotConfiguration schedulerConfig,
- QueryExecutor queryExecutor) {
+ QueryExecutor queryExecutor, ServerMetrics serverMetrics,
LongAccumulator latestQueryTime) {
try {
- Constructor<?> constructor =
- Class.forName(className).getDeclaredConstructor(Configuration.class,
QueryExecutor.class);
+ Constructor<?> constructor = Class.forName(className)
Review comment:
Should we not be using PluginManager for class loads?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
