codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r759890644
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/DocIdSetOperator.java
##
@@ -34,6 +37,7 @@
*/
public class DocIdSetOperator exte
amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r759887289
##
File path: pinot-core/src/main/java/org/apache/pinot/core/common/Operator.java
##
@@ -46,6 +47,12 @@
*/
String getOperatorName();
+ /** @retu
amrishlal commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r759667776
##
File path:
pinot-core/src/test/java/org/apache/pinot/queries/JsonPathQueriesTest.java
##
@@ -177,40 +206,103 @@ private void checkresult(String query,
weixiangsun commented on a change in pull request #7781:
URL: https://github.com/apache/pinot/pull/7781#discussion_r759837924
##
File path:
pinot-core/src/test/java/org/apache/pinot/queries/PostAggregationGapfillQueriesTest.java
##
@@ -0,0 +1,592 @@
+/**
+ * Licensed to the Ap
Manis99803 commented on issue #7843:
URL: https://github.com/apache/pinot/issues/7843#issuecomment-983262214
Sure @Jackie-Jiang, I will work on fix for this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 34782f5 added extraEnv, envFrom to statefulset
xiangfu0 merged pull request #7833:
URL: https://github.com/apache/pinot/pull/7833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
codecov-commenter edited a comment on pull request #7833:
URL: https://github.com/apache/pinot/pull/7833#issuecomment-983236981
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7833:
URL: https://github.com/apache/pinot/pull/7833#issuecomment-983236981
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7833:
URL: https://github.com/apache/pinot/pull/7833#issuecomment-983236981
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7833:
URL: https://github.com/apache/pinot/pull/7833#issuecomment-983236981
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter commented on pull request #7846:
URL: https://github.com/apache/pinot/pull/7846#issuecomment-983230749
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
Jackie-Jiang commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r759796029
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateEvaluatorProvider.java
##
@@ -37,47 +37,65 @@ private
Jackie-Jiang commented on issue #7843:
URL: https://github.com/apache/pinot/issues/7843#issuecomment-983203707
The analytics are correct. We should specialize the dimension table by
counting all the servers within the tenant, and ignore the replication settings
within the table config.
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from fc3de45 use uppercase format (#7845)
add 5333b6d add ability to comment out queries with cmd + / (#7841)
No ne
Jackie-Jiang merged pull request #7841:
URL: https://github.com/apache/pinot/pull/7841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
yupeng9 commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759780655
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ public G
Jackie-Jiang opened a new pull request #7846:
URL: https://github.com/apache/pinot/pull/7846
Clean up the deprecated keys and methods as planned after releasing 0.9.0.
Also remove the deprecated and unused `BackfillSegmentUtils` which accesses
the deprecated keys.
--
This is an automa
codecov-commenter edited a comment on pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#issuecomment-978182588
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759760648
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ pub
jtao15 commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r759754875
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
richardstartin commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759747251
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ p
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 9b2f15d Remove pinot-ingestion-job script (#7825)
add fc3de45 use uppercase format (#7845)
No new revisions w
xiangfu0 merged pull request #7845:
URL: https://github.com/apache/pinot/pull/7845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
apucher opened a new pull request #7845:
URL: https://github.com/apache/pinot/pull/7845
## Description
use uppercase for file format arg.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Ple
richardstartin commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759747251
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ p
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch generator-sh-fix-for-cli-parswer-changes
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 034ac6024778049f316fb884539fb06aca31899f
Author: Alexander Pucher
AuthorDate: Tue Nov
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch generator-sh-fix-for-cli-parswer-changes
in repository https://gitbox.apache.org/repos/asf/pinot.git.
at 034ac60 use uppercase format
This branch includes the following new commits:
richardstartin commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759743586
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ p
Jackie-Jiang commented on issue #7836:
URL: https://github.com/apache/pinot/issues/7836#issuecomment-983123618
The functionality can be easily added by adding a transform function. The
challenge here is to automatically consider the `min/max` as transform when it
has more than 1 arguments
yupeng9 commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759738827
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ public G
Jackie-Jiang commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759734412
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ pub
snleee commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r759733863
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
snleee commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r759729786
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from eff570b make openjdk image name configurable (#7832)
add 9b2f15d Remove pinot-ingestion-job script (#7825)
No
Jackie-Jiang merged pull request #7825:
URL: https://github.com/apache/pinot/pull/7825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
Jackie-Jiang commented on a change in pull request #7781:
URL: https://github.com/apache/pinot/pull/7781#discussion_r759714618
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java
##
@@ -201,6 +202,14 @@ public int getOffset() {
codecov-commenter commented on pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#issuecomment-983082519
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7844?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
yupeng9 commented on a change in pull request #7844:
URL: https://github.com/apache/pinot/pull/7844#discussion_r759711050
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -186,27 +182,32 @@ public G
Jackie-Jiang opened a new pull request #7844:
URL: https://github.com/apache/pinot/pull/7844
When updating the upsert metadata, if the update (invalidate an old record,
and validate a new record) applies to the same segment, make the update atomic
to reduce the temporary inconsistency.
-
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from d172737 Add getPredicate() to PredicateEvaluator (#7840)
add eff570b make openjdk image name configurable (#78
xiangfu0 merged pull request #7832:
URL: https://github.com/apache/pinot/pull/7832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
codecov-commenter edited a comment on pull request #7832:
URL: https://github.com/apache/pinot/pull/7832#issuecomment-979041676
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7832?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch arm64-docker-image
in repository https://gitbox.apache.org/repos/asf/pinot.git.
discard 6b2e7e8 make openjdk image name configurable
add eec4e67 make openjdk image name configurable
Thi
codecov-commenter edited a comment on pull request #7830:
URL: https://github.com/apache/pinot/pull/7830#issuecomment-979136818
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7830?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#issuecomment-974570171
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7804?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7838:
URL: https://github.com/apache/pinot/pull/7838#issuecomment-982162356
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#issuecomment-974570171
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7804?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#issuecomment-974570171
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7804?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7838:
URL: https://github.com/apache/pinot/pull/7838#issuecomment-982162356
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from dfb7fee Make split commit the default commit protocol (#7780)
add d172737 Add getPredicate() to PredicateEvalua
Jackie-Jiang merged pull request #7840:
URL: https://github.com/apache/pinot/pull/7840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
Jackie-Jiang commented on a change in pull request #7840:
URL: https://github.com/apache/pinot/pull/7840#discussion_r759565703
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/BasePredicateEvaluator.java
##
@@ -18,7 +18,25 @@
*/
package
codecov-commenter edited a comment on pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#issuecomment-982180134
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#issuecomment-982180134
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r759519302
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/PushDownTransformFunction.java
##
@@ -0,0 +1,124 @@
+/**
+
richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r759518927
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/TransformBlock.java
##
@@ -78,4 +79,54 @@ public BlockDocIdValueSet get
richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r759517406
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java
##
@@ -100,6 +101,19 @@ public void fetchIntValues(String colum
klsince commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r759502515
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java
##
@@ -100,6 +101,19 @@ public void fetchIntValues(String column, int[
Manis99803 opened a new issue #7843:
URL: https://github.com/apache/pinot/issues/7843
Should the Dimension table honor replication at all or not (for quota),
because looks like it don't seem to apply it.
For example, say if I am having a pinot cluster with 4 servers, on creating
a d
atris commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982820667
@weixiangsun I am not sure I understand, but yes, the ability to use an
index (Startree, inverted) to solve a specific sub predicate
--
This is an automated message from the Apache Git
atris commented on issue #7831:
URL: https://github.com/apache/pinot/issues/7831#issuecomment-982802907
> Thanks @atris for creating this PEP request. The overall design doc looks
good to me. +1 on the feature implementation.
Thank you for taking a look and reviewing!
--
This is a
Eywek commented on issue #7842:
URL: https://github.com/apache/pinot/issues/7842#issuecomment-982655500
> how slow is "very slow"?
~600-800ms for 21 documents (vs 22-40ms without this filter)
> Is there a natural way for you to filter the JSON documents before
applying the
richardstartin commented on issue #7842:
URL: https://github.com/apache/pinot/issues/7842#issuecomment-982651511
Hi @Eywek how slow is "very slow"?
Is there a natural way for you to filter the JSON documents before applying
the `JSONEXTRACTSCALAR` and `REGEXP_LIKE` functions? Withou
Eywek opened a new issue #7842:
URL: https://github.com/apache/pinot/issues/7842
Hello,
I was wondering if it was planned to add the LIKE operator to JSON_MATCH ?
I’m currently using
```sql
REGEXP_LIKE(JSONEXTRACTSCALAR("labels", '$.demande_intention', 'STRING'),
'terminal')
codecov-commenter edited a comment on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-977259274
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7820?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-977259274
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7820?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982559015
> Some methods added to projectionBlock seem to be specific to
projectionBlock and is deviating from the block concept of chaining any blocks
together i.e. the caller of th
richardstartin commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982539768
@kishoreg please see the updated Javadoc which provides more colour.
@siddharthteotia you expressed some interest in this PR, would you mind
taking a look please?
-
richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r759178462
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##
@@ -120,6 +121,17 @@ public int getNumDocs() {
retur
codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7830:
URL: https://github.com/apache/pinot/pull/7830#issuecomment-979136818
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7830?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
amrishlal edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-982387933
> What do you think about merging `getExplainPlanName` into
`toExplainString`?'
Yes, I don't see any issues with this. Will make the change.
--
This is a
amrishlal commented on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-982387933
> What do you think about merging `getExplainPlanName` into
`toExplainString`?'
Yes, I don't see any issues with this. Will make the change.
--
This is an automated
77 matches
Mail list logo
