snleee commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r759729786
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java
##########
@@ -439,6 +439,18 @@ private boolean validate(TableConfig tableConfig, String
taskType) {
return true;
}
+ /**
+ * Get the max valid merge bucket end time for the segment, LONG.MIN_VALUE
if the segment is not ready to merge
+ */
+ private long getMaxValidBucketEndTimeMsForSegment(SegmentZKMetadata
segmentZKMetadata, long bucketMs, long bufferMs) {
+ if (segmentZKMetadata.getStartTimeMs() / bucketMs * bucketMs + bucketMs >
System.currentTimeMillis() - bufferMs) {
Review comment:
I see. In that case, let's add the comment that our task scheduler uses
`startTime` based window computation when deciding a segment is valid for merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
