[GitHub] [pinot] codecov-commenter edited a comment on pull request #7800: Simplify the API of ThreadTimer

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7800: URL: https://github.com/apache/pinot/pull/7800#issuecomment-973826945 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7800?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7800: Simplify the API of ThreadTimer

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7800: URL: https://github.com/apache/pinot/pull/7800#issuecomment-973826945 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7800?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7800: Simplify the API of ThreadTimer

2021-11-18 Thread GitBox
codecov-commenter commented on pull request #7800: URL: https://github.com/apache/pinot/pull/7800#issuecomment-973826945 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7800?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] mqliang opened a new pull request #7800: Simplify the API of ThreadTimer

2021-11-18 Thread GitBox
mqliang opened a new pull request #7800: URL: https://github.com/apache/pinot/pull/7800 ## Description This PR simplifies the API of ThreadTimer, no functionality change. The idea comes from https://github.com/apache/pinot/pull/7540, so all kudos goes @Jackie-Jiang ## Up

[GitHub] [pinot] chenboat commented on pull request #7780: Make split-commit the default segment commit protocol

2021-11-18 Thread GitBox
chenboat commented on pull request #7780: URL: https://github.com/apache/pinot/pull/7780#issuecomment-973659282 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [pinot] walterddr commented on issue #7786: StringColumnPreIndexStatsCollector doesnt work for datetime

2021-11-18 Thread GitBox
walterddr commented on issue #7786: URL: https://github.com/apache/pinot/issues/7786#issuecomment-973656952 > E.g. date time is stored as `STRING` but ordered as time value, the following query will fail because it will still filter with string order: `SELECT * FROM myTable WHERE timeCol <

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7798: Fixing Pinot Admin system exit logic

2021-11-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #7798: URL: https://github.com/apache/pinot/pull/7798#discussion_r752805143 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java ## @@ -138,7 +138,7 @@ description = "Print the ve

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752781729 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtil.java ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752779601 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java ## @@ -59,6 +59,7 @@ * Factor

[GitHub] [pinot] snleee merged pull request #7796: Add getRevertReplaceSegmentRequest method in FileUploadDownloadClient

2021-11-18 Thread GitBox
snleee merged pull request #7796: URL: https://github.com/apache/pinot/pull/7796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[pinot] branch master updated (8d87ced -> ab01ac3)

2021-11-18 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 8d87ced adding JAVA_OPTS env var in docker image (#7799) add ab01ac3 Add getRevertReplaceSegmentRequest method i

[GitHub] [pinot] mayankshriv commented on a change in pull request #7798: Fixing Pinot Admin system exit logic

2021-11-18 Thread GitBox
mayankshriv commented on a change in pull request #7798: URL: https://github.com/apache/pinot/pull/7798#discussion_r752788317 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java ## @@ -190,13 +190,9 @@ public static void main(String[] a

[GitHub] [pinot] codecov-commenter commented on pull request #7798: Fixing Pinot Admin system exit logic

2021-11-18 Thread GitBox
codecov-commenter commented on pull request #7798: URL: https://github.com/apache/pinot/pull/7798#issuecomment-973601502 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[pinot] branch master updated: adding JAVA_OPTS env var in docker image (#7799)

2021-11-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8d87ced adding JAVA_OPTS env var in docker imag

[GitHub] [pinot] xiangfu0 merged pull request #7799: adding JAVA_OPTS env var in docker image

2021-11-18 Thread GitBox
xiangfu0 merged pull request #7799: URL: https://github.com/apache/pinot/pull/7799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] xiangfu0 opened a new pull request #7799: adding JAVA_OPTS env var in docker image

2021-11-18 Thread GitBox
xiangfu0 opened a new pull request #7799: URL: https://github.com/apache/pinot/pull/7799 ## Description To avoid long running pinot process exit from docker image. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Min

[GitHub] [pinot] xiangfu0 opened a new pull request #7798: Fixing Pinot Admin system exit logic

2021-11-18 Thread GitBox
xiangfu0 opened a new pull request #7798: URL: https://github.com/apache/pinot/pull/7798 ## Description Pinot admin should only exit when status is not 0 and the flag `pinot.admin.system.exit` is set to true. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assu

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7797: use `LZ4` as default compression mode

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7797: URL: https://github.com/apache/pinot/pull/7797#issuecomment-973479443 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7797?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7797: use `LZ4` as default compression mode

2021-11-18 Thread GitBox
codecov-commenter commented on pull request #7797: URL: https://github.com/apache/pinot/pull/7797#issuecomment-973479443 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7797?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[pinot] branch fixing_docker_image_env_var created (now 3089e6d)

2021-11-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_docker_image_env_var in repository https://gitbox.apache.org/repos/asf/pinot.git. at 3089e6d adding JAVA_OPTS env var in docker image This branch includes the following new commit

[pinot] 01/01: adding JAVA_OPTS env var in docker image

2021-11-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_docker_image_env_var in repository https://gitbox.apache.org/repos/asf/pinot.git commit 3089e6d8398ca820186a2ab9234eb48db674e368 Author: Xiang Fu AuthorDate: Thu Nov 18 15:31:19 2021 -080

[GitHub] [pinot] richardstartin commented on pull request #7797: use `LZ4_LENGTH_PREFIXED` as default compression mode

2021-11-18 Thread GitBox
richardstartin commented on pull request #7797: URL: https://github.com/apache/pinot/pull/7797#issuecomment-973411524 > I have some concern on changing the default to L4Z_LENGTH_PREFIXED because it is recently added and can potentially cause problem if segment creator gets the new version

[GitHub] [pinot] jtao15 commented on pull request #7796: Add getRevertReplaceSegmentRequest method in FileUploadDownloadClient

2021-11-18 Thread GitBox
jtao15 commented on pull request #7796: URL: https://github.com/apache/pinot/pull/7796#issuecomment-973395000 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [pinot] richardstartin opened a new pull request #7797: use `LZ4_LENGTH_PREFIXED` as default compression mode

2021-11-18 Thread GitBox
richardstartin opened a new pull request #7797: URL: https://github.com/apache/pinot/pull/7797 * adds a simple benchmark to compare compression modes (and chunk format v3 vs v4) * defaults to `LZ4_WITH_LENGTH` everywhere, except when constructing readers for v1 chunks where `SNAPPY` was

[GitHub] [pinot] jackjlli opened a new pull request #7796: Add getRevertReplaceSegmentRequest method in FileUploadDownloadClient

2021-11-18 Thread GitBox
jackjlli opened a new pull request #7796: URL: https://github.com/apache/pinot/pull/7796 ## Description This PR: * adds `getRevertReplaceSegmentRequest` method in `FileUploadDownloadClient`. * makes `StartReplaceSegmentsRequest` as the required field in `startReplaceSegments` A

[pinot] 01/01: Add getRevertReplaceSegmentRequest method in FileUploadDownloadClient

2021-11-18 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-revertReplaceSegments-in-FileUploadDownloadClient in repository https://gitbox.apache.org/repos/asf/pinot.git commit 4475d9f9d27cd0b693de600fa9552194d0f693f0 Author: Jack Li(Analytics Engineeri

[pinot] branch add-revertReplaceSegments-in-FileUploadDownloadClient created (now 4475d9f)

2021-11-18 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-revertReplaceSegments-in-FileUploadDownloadClient in repository https://gitbox.apache.org/repos/asf/pinot.git. at 4475d9f Add getRevertReplaceSegmentRequest method in FileUploadDownloa

[GitHub] [pinot] richardstartin opened a new issue #7795: Change default raw index compression format to `LZ4`

2021-11-18 Thread GitBox
richardstartin opened a new issue #7795: URL: https://github.com/apache/pinot/issues/7795 LZ4 decompression is consistently faster than Snappy and produces smaller file sizes. These results are taken from a benchmark which consists of raw string sentences composed words from Wikipedia:

[GitHub] [pinot] mcvsubbu commented on pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
mcvsubbu commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-973309329 that may be fine in principle, but it does seem like a hack. I think the current version api returns a map of library names and their versions. "branch" and "commit" will stand o

[GitHub] [pinot] Jackie-Jiang commented on pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
Jackie-Jiang commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-973306572 @mcvsubbu @richardstartin Since it almost follows the same way as getting the component versions, does it make sense to simply add 2 entries `branch` and `commit` into the ve

[GitHub] [pinot] richardstartin closed pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
richardstartin closed pull request #7782: URL: https://github.com/apache/pinot/pull/7782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pinot] richardstartin commented on pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
richardstartin commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-973305106 @mcvsubbu that makes sense, and I agree, proliferated APIs are hard to maintain and look messy. I will revisit this at a later date. -- This is an automated message from

[GitHub] [pinot] mcvsubbu commented on pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
mcvsubbu commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-973302722 > > I was thinking to provide a single api that has version and commit info in it, rather than two different apis. We can deprecate/remove the version api eventually. It can be a

[GitHub] [pinot] mneedham commented on a change in pull request #7792: Nicer error message if you have a typo in your schema file

2021-11-18 Thread GitBox
mneedham commented on a change in pull request #7792: URL: https://github.com/apache/pinot/pull/7792#discussion_r752648384 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/SchemaTest.java ## @@ -253,11 +254,27 @@ public void testSchemaBuilderAddTime() {

[GitHub] [pinot] mneedham commented on pull request #7792: Nicer error message if you have a typo in your schema file

2021-11-18 Thread GitBox
mneedham commented on pull request #7792: URL: https://github.com/apache/pinot/pull/7792#issuecomment-973296557 @Jackie-Jiang How should we indicate to the user which field spec has an error if they don't specify the name property? -- This is an automated message from the Apache Git Ser

[GitHub] [pinot] richardstartin commented on pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
richardstartin commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-973296523 > I was thinking to provide a single api that has version and commit info in it, rather than two different apis. We can deprecate/remove the version api eventually. It can

[GitHub] [pinot] Jackie-Jiang commented on issue #7786: StringColumnPreIndexStatsCollector doesnt work for datetime

2021-11-18 Thread GitBox
Jackie-Jiang commented on issue #7786: URL: https://github.com/apache/pinot/issues/7786#issuecomment-973293869 E.g. date time is stored as `STRING` but ordered as time value, the following query will fail because it will still filter with string order: `SELECT * FROM myTable WHERE timeCo

[pinot] branch master updated (7c695e9 -> b809043)

2021-11-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 7c695e9 fix obfuscator not capturing secretkey and keytab (#7794) add b809043 peel off special case for 1 dimen

[GitHub] [pinot] Jackie-Jiang merged pull request #7777: peel off special case for 1 dimensional groupby

2021-11-18 Thread GitBox
Jackie-Jiang merged pull request #: URL: https://github.com/apache/pinot/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7792: Nicer error message if you have a typo in your schema file

2021-11-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #7792: URL: https://github.com/apache/pinot/pull/7792#discussion_r752639890 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -213,6 +213,10 @@ public void addField(FieldSpec fieldSpec) {

[GitHub] [pinot] mcvsubbu commented on pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
mcvsubbu commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-973289605 > > Why not extend the /version URI to provide this information as opposed to introducing a new endpoint? I am also fine with /v2/version if it is not possible to make it backwar

[pinot-site] branch dev updated (1c8a8a5 -> 618d794)

2021-11-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/pinot-site.git. from 1c8a8a5 Merge pull request #60 from apache/adding_0.9.0_release add 0a8c04f Update download link new 61

[GitHub] [pinot-site] xiangfu0 merged pull request #61: Update download links

2021-11-18 Thread GitBox
xiangfu0 merged pull request #61: URL: https://github.com/apache/pinot-site/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[pinot-site] 01/01: Merge pull request #61 from apache/adding_0.9.0_release

2021-11-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/pinot-site.git commit 618d794996989132f353663d74665f2f83557310 Merge: 1c8a8a5 0a8c04f Author: Xiang Fu AuthorDate: Thu Nov 18 13:23:05 2021

[pinot-site] branch adding_0.9.0_release created (now 0a8c04f)

2021-11-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_0.9.0_release in repository https://gitbox.apache.org/repos/asf/pinot-site.git. at 0a8c04f Update download link No new revisions were added by this update. --

[pinot] branch master updated: fix obfuscator not capturing secretkey and keytab (#7794)

2021-11-18 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7c695e9 fix obfuscator not capturing secretkey

[GitHub] [pinot] apucher merged pull request #7794: fix obfuscator not capturing secretkey and keytab

2021-11-18 Thread GitBox
apucher merged pull request #7794: URL: https://github.com/apache/pinot/pull/7794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated: Split thread cpu time into three metrics (#7724)

2021-11-18 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9662399 Split thread cpu time into three met

[GitHub] [pinot] siddharthteotia merged pull request #7724: Split thread cpu time into three metrics

2021-11-18 Thread GitBox
siddharthteotia merged pull request #7724: URL: https://github.com/apache/pinot/pull/7724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7784: Fixes for various JDBC issues

2021-11-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #7784: URL: https://github.com/apache/pinot/pull/7784#discussion_r752601442 ## File path: pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/base/AbstractBaseResultSet.java ## @@ -229,7 +229,7 @@ public int

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7784: Fixes for various JDBC issues

2021-11-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #7784: URL: https://github.com/apache/pinot/pull/7784#discussion_r752600952 ## File path: pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotStatement.java ## @@ -34,7 +34,7 @@ private ResultSetGroup

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7794: fix obfuscator not capturing secretkey and keytab

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7794: URL: https://github.com/apache/pinot/pull/7794#issuecomment-973040243 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7794?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7794: fix obfuscator not capturing secretkey and keytab

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7794: URL: https://github.com/apache/pinot/pull/7794#issuecomment-973040243 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7794?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] walterddr commented on a change in pull request #7794: fix obfuscator not capturing secretkey and keytab

2021-11-18 Thread GitBox
walterddr commented on a change in pull request #7794: URL: https://github.com/apache/pinot/pull/7794#discussion_r752521688 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/Obfuscator.java ## @@ -93,7 +94,8 @@ public Obfuscator(String maskedValue, List patterns)

[GitHub] [pinot] apucher commented on a change in pull request #7794: fix obfuscator not capturing secretkey and keytab

2021-11-18 Thread GitBox
apucher commented on a change in pull request #7794: URL: https://github.com/apache/pinot/pull/7794#discussion_r752520983 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/Obfuscator.java ## @@ -93,7 +94,8 @@ public Obfuscator(String maskedValue, List patterns)

[GitHub] [pinot] weixiangsun commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
weixiangsun commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752507535 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/BaseQueriesTest.java ## @@ -223,8 +223,11 @@ private BrokerResponseNative getBrokerRes

[GitHub] [pinot] Jackie-Jiang commented on issue #7791: Only download required files from segment for metadata push

2021-11-18 Thread GitBox
Jackie-Jiang commented on issue #7791: URL: https://github.com/apache/pinot/issues/7791#issuecomment-973130363 Oh I see the problem you referred to. There are 2 versions of metadata push, one also push the segment metadata to the controller so that controller doesn't need to download the s

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7784: Fixes for various JDBC issues

2021-11-18 Thread GitBox
codecov-commenter edited a comment on pull request #7784: URL: https://github.com/apache/pinot/pull/7784#issuecomment-971813042 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] weixiangsun commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
weixiangsun commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752495742 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapFillGroupByDataTableReducer.java ## @@ -0,0 +1,706 @@ +/** + * Licensed to

[GitHub] [pinot] weixiangsun commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
weixiangsun commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752485910 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java ## @@ -198,6 +202,18 @@ public s

[GitHub] [pinot] kbastani commented on a change in pull request #7784: Fixes for various JDBC issues

2021-11-18 Thread GitBox
kbastani commented on a change in pull request #7784: URL: https://github.com/apache/pinot/pull/7784#discussion_r752474098 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java ## @@ -65,14 +65,17 @@ public J

[GitHub] [pinot] kbastani commented on a change in pull request #7784: Fixes for various JDBC issues

2021-11-18 Thread GitBox
kbastani commented on a change in pull request #7784: URL: https://github.com/apache/pinot/pull/7784#discussion_r752473689 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java ## @@ -167,7 +170,7 @@ public b

[GitHub] [pinot] kbastani commented on a change in pull request #7784: Fixes for various JDBC issues

2021-11-18 Thread GitBox
kbastani commented on a change in pull request #7784: URL: https://github.com/apache/pinot/pull/7784#discussion_r752466282 ## File path: pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotStatement.java ## @@ -34,7 +34,7 @@ private ResultSetGroup _re

[GitHub] [pinot] weixiangsun commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
weixiangsun commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752464866 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -339,6 +339,43 @@ public static DataTabl

[GitHub] [pinot] weixiangsun commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
weixiangsun commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752443884 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/BaseQueriesTest.java ## @@ -223,8 +223,11 @@ private BrokerResponseNative getBrokerRes

[GitHub] [pinot] weixiangsun commented on a change in pull request #7781: Add Post-Aggregation Gapfilling functionality.

2021-11-18 Thread GitBox
weixiangsun commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r752438692 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java ## @@ -59,6 +59,10 @@ * Factor

[GitHub] [pinot] kbastani commented on a change in pull request #7784: Fixes for various JDBC issues

2021-11-18 Thread GitBox
kbastani commented on a change in pull request #7784: URL: https://github.com/apache/pinot/pull/7784#discussion_r752430906 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java ## @@ -209,7 +222,7 @@ public boolean isDone() {

[GitHub] [pinot] walterddr closed pull request #7695: Add pinot-query-spi

2021-11-18 Thread GitBox
walterddr closed pull request #7695: URL: https://github.com/apache/pinot/pull/7695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pinot] walterddr closed pull request #7692: refactor DataSchema to pinot-spi

2021-11-18 Thread GitBox
walterddr closed pull request #7692: URL: https://github.com/apache/pinot/pull/7692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pinot] codecov-commenter commented on pull request #7794: fix obfuscator not capturing secretkey and keytab

2021-11-18 Thread GitBox
codecov-commenter commented on pull request #7794: URL: https://github.com/apache/pinot/pull/7794#issuecomment-973040243 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7794?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] walterddr edited a comment on issue #7786: StringColumnPreIndexStatsCollector doesnt work for datetime

2021-11-18 Thread GitBox
walterddr edited a comment on issue #7786: URL: https://github.com/apache/pinot/issues/7786#issuecomment-972995918 that's definitely one solution but IMO it will make user experience bad. either we enhance our documentation and error messaging; or we should automatically populate a shadow

[GitHub] [pinot] walterddr commented on issue #7786: StringColumnPreIndexStatsCollector doesnt work for datetime

2021-11-18 Thread GitBox
walterddr commented on issue #7786: URL: https://github.com/apache/pinot/issues/7786#issuecomment-972995918 that's definitely one solution but IMO it will make user experience bad. either we enhance our documentation and error messaging; or we should automatically populate a shadow timeCol

[GitHub] [pinot] richardstartin closed pull request #7793: avoid converting bitmaps to sets for the sake of merging in distinct count

2021-11-18 Thread GitBox
richardstartin closed pull request #7793: URL: https://github.com/apache/pinot/pull/7793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pinot] richardstartin opened a new pull request #7793: avoid converting bitmaps to sets for the sake of merging in distinct count

2021-11-18 Thread GitBox
richardstartin opened a new pull request #7793: URL: https://github.com/apache/pinot/pull/7793 ## Description This makes very large distinct counts of dictionarised columns more efficient. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Contr

[GitHub] [pinot] richardstartin commented on a change in pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
richardstartin commented on a change in pull request #7782: URL: https://github.com/apache/pinot/pull/7782#discussion_r752185085 ## File path: pinot-common/src/main/java/org/apache/pinot/common/Utils.java ## @@ -145,4 +149,36 @@ public static void logVersions() { return

[GitHub] [pinot] mneedham closed issue #7790: [Docs] Chaining transformations

2021-11-18 Thread GitBox
mneedham closed issue #7790: URL: https://github.com/apache/pinot/issues/7790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [pinot] mneedham commented on issue #7790: [Docs] Chaining transformations

2021-11-18 Thread GitBox
mneedham commented on issue #7790: URL: https://github.com/apache/pinot/issues/7790#issuecomment-972765111 Have updated the docs here - https://docs.pinot.apache.org/developers/advanced/ingestion-level-transformations#chaining-transformations. Thanks to Jonathan for the example! -- This

[GitHub] [pinot] richardstartin commented on pull request #7777: peel off special case for 1 dimensional groupby

2021-11-18 Thread GitBox
richardstartin commented on pull request #: URL: https://github.com/apache/pinot/pull/#issuecomment-972761090 @Jackie-Jiang addressed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] mneedham commented on a change in pull request #7792: Nicer error message if you have a typo in your schema file

2021-11-18 Thread GitBox
mneedham commented on a change in pull request #7792: URL: https://github.com/apache/pinot/pull/7792#discussion_r752122323 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/SchemaTest.java ## @@ -253,6 +253,16 @@ public void testSchemaBuilderAddTime() {

[GitHub] [pinot] richardstartin commented on a change in pull request #7792: Nicer error message if you have a typo in your schema file

2021-11-18 Thread GitBox
richardstartin commented on a change in pull request #7792: URL: https://github.com/apache/pinot/pull/7792#discussion_r752116845 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/SchemaTest.java ## @@ -253,6 +253,16 @@ public void testSchemaBuilderAddTime()

[GitHub] [pinot] richardstartin commented on pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
richardstartin commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-972744488 > Why not extend the /version URI to provide this information as opposed to introducing a new endpoint? I am also fine with /v2/version if it is not possible to make it bac

[GitHub] [pinot] richardstartin commented on a change in pull request #7782: expose API with git branch and commit info

2021-11-18 Thread GitBox
richardstartin commented on a change in pull request #7782: URL: https://github.com/apache/pinot/pull/7782#discussion_r752113345 ## File path: pinot-common/src/main/java/org/apache/pinot/common/Utils.java ## @@ -145,4 +149,36 @@ public static void logVersions() { return

[GitHub] [pinot] mneedham opened a new pull request #7792: Nicer error message if you have a typo in your schema file

2021-11-18 Thread GitBox
mneedham opened a new pull request #7792: URL: https://github.com/apache/pinot/pull/7792 I had a typo in my schema file where instead of `dataType` I had `type`: ``` { "dimensionFieldSpecs": [ { "name": "booleanDimension", "type": "BOOLEAN", "

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7724: Split thread cpu time into three metrics

2021-11-18 Thread GitBox
siddharthteotia commented on a change in pull request #7724: URL: https://github.com/apache/pinot/pull/7724#discussion_r752010167 ## File path: pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java ## @@ -143,17 +133,91 @@ String toJsonString() Lis