mcvsubbu commented on pull request #7782: URL: https://github.com/apache/pinot/pull/7782#issuecomment-973302722
> > I was thinking to provide a single api that has version and commit info in it, rather than two different apis. We can deprecate/remove the version api eventually. It can be a v2/version for example (or version/v2, whichever way we are versioning -- not sure). > > Isn’t someone likely to be using the current API somewhere? I don’t like making backward incompatible changes. What is your concern with the approach taken, precisely? > > The motivation for this addition is to be able to figure out which version of Pinot is running when benchmarking it, but I can do that other ways, so if the addition of this API is contentious, discussing it much further might outweigh the benefits. My concern is api proliferation. If for whatever reason we want more info, then we will introduce a new api next time. Instead, if we introduce an expandable api now. Say, we return a json object with elements: version, git-commit, last-commit, etc. We can then add new json elements as needed and don't need to introduce newer API. We can deprecate the version api and remove it in a couple of releases. The more apis we have, the more we need to worry about keeping things compatible forever (as we are doing now). Don't you agree? I don't mean to block your progress. I think it is a useful API to have. Just introduce it as the new "version" api, and deprecate the old one, is all I am asking for. If you have a strong disagreement, then this is not worth debating about. But I don't want this to be held as a template for adding more apis each time we want something new. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
