[GitHub] [pinot] jtao15 commented on a change in pull request #7761: Fix merge delay metric when there is empty bucket

2021-11-12 Thread GitBox
jtao15 commented on a change in pull request #7761: URL: https://github.com/apache/pinot/pull/7761#discussion_r748694797 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja

svn commit: r50903 - /dev/pinot/apache-pinot-0.9.0-rc0/

2021-11-12 Thread xiangfu
Author: xiangfu Date: Sat Nov 13 05:15:58 2021 New Revision: 50903 Log: Update apache-pinot-0.9.0-rc0 Added: dev/pinot/apache-pinot-0.9.0-rc0/ dev/pinot/apache-pinot-0.9.0-rc0/apache-pinot-0.9.0-bin.tar.gz (with props) dev/pinot/apache-pinot-0.9.0-rc0/apache-pinot-0.9.0-bin.tar.gz.

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7765: Add timeColumn, timeUnit and totalDocs to the json segment metadata

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7765: URL: https://github.com/apache/pinot/pull/7765#issuecomment-967762933 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7765: Add timeColumn, timeUnit and totalDocs to the json segment metadata

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7765: URL: https://github.com/apache/pinot/pull/7765#issuecomment-967762933 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7765: Add timeColumn, timeUnit and totalDocs to the json segment metadata

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7765: URL: https://github.com/apache/pinot/pull/7765#issuecomment-967762933 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] xiangfu0 closed issue #7749: Error message for invalid table config

2021-11-12 Thread GitBox
xiangfu0 closed issue #7749: URL: https://github.com/apache/pinot/issues/7749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [pinot] codecov-commenter commented on pull request #7765: Add timeColumn, timeUnit and totalDocs to the json segment metadata

2021-11-12 Thread GitBox
codecov-commenter commented on pull request #7765: URL: https://github.com/apache/pinot/pull/7765#issuecomment-967762933 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] Jackie-Jiang opened a new pull request #7765: Add timeColumn and timeUnit to the json segment metadata

2021-11-12 Thread GitBox
Jackie-Jiang opened a new pull request #7765: URL: https://github.com/apache/pinot/pull/7765 Add the missing `timeColumn` and `timeUnit` info to the json segment metadata -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pinot] Jackie-Jiang merged pull request #7760: Add getName() to PartitionFunction interface

2021-11-12 Thread GitBox
Jackie-Jiang merged pull request #7760: URL: https://github.com/apache/pinot/pull/7760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang merged pull request #7764: Add link to the ZeroInWord algorithm.

2021-11-12 Thread GitBox
Jackie-Jiang merged pull request #7764: URL: https://github.com/apache/pinot/pull/7764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch master updated: Add link to the ZeroInWord algorithm. (#7764)

2021-11-12 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4a540ed Add link to the ZeroInWord algorithm. (#

[pinot] branch master updated: Add getName() to PartitionFunction interface (#7760)

2021-11-12 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 362f3e1 Add getName() to PartitionFunction inter

[GitHub] [pinot] mayankshriv opened a new pull request #7764: Add link to the ZeroInWord algorithm.

2021-11-12 Thread GitBox
mayankshriv opened a new pull request #7764: URL: https://github.com/apache/pinot/pull/7764 ## Description Added link to the ZeroInWord Algorithm used in `FixedByteValueReaderWriter.getUnpaddedString()`. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assum

[GitHub] [pinot] jasperjiaguo closed pull request #7763: [WIP] resolve dependency convergence issue with netty-tcnative-boringssl-static

2021-11-12 Thread GitBox
jasperjiaguo closed pull request #7763: URL: https://github.com/apache/pinot/pull/7763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7761: Fix merge delay metric when there is empty bucket

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7761: URL: https://github.com/apache/pinot/pull/7761#issuecomment-967748008 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7761: Fix merge delay metric when there is empty bucket

2021-11-12 Thread GitBox
codecov-commenter commented on pull request #7761: URL: https://github.com/apache/pinot/pull/7761#issuecomment-967748008 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7760: Add getName() to PartitionFunction interface

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7760: URL: https://github.com/apache/pinot/pull/7760#issuecomment-967740539 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7760?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] jasperjiaguo opened a new pull request #7763: [WIP] resolve dependency convergence issue with netty-tcnative-boringssl-static

2021-11-12 Thread GitBox
jasperjiaguo opened a new pull request #7763: URL: https://github.com/apache/pinot/pull/7763 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) No Does this PR fix a zero-downtime upgr

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7760: Add getName() to PartitionFunction interface

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7760: URL: https://github.com/apache/pinot/pull/7760#issuecomment-967740539 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7760?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] jasperjiaguo closed pull request #7762: Set tcnative version to 2.0.35.Final to resolve dependency convergence issue

2021-11-12 Thread GitBox
jasperjiaguo closed pull request #7762: URL: https://github.com/apache/pinot/pull/7762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] icefury71 commented on issue #5598: Spark-Pinot connector to read and write data from/to Pinot directly

2021-11-12 Thread GitBox
icefury71 commented on issue #5598: URL: https://github.com/apache/pinot/issues/5598#issuecomment-967740658 @mangrrua I see that the read side was done. Should we keep this ticket open to ensure the Spark writer to Pinot is also tracked ? Btw, is that something you're already working on ?

[GitHub] [pinot] codecov-commenter commented on pull request #7760: Add getName() to PartitionFunction interface

2021-11-12 Thread GitBox
codecov-commenter commented on pull request #7760: URL: https://github.com/apache/pinot/pull/7760#issuecomment-967740539 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7760?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] jasperjiaguo opened a new pull request #7762: Set tcnative version to 2.0.35.Final to resolve dependency convergence issue

2021-11-12 Thread GitBox
jasperjiaguo opened a new pull request #7762: URL: https://github.com/apache/pinot/pull/7762 …e issue ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) No Does this PR fix a zero-d

[GitHub] [pinot] snleee opened a new pull request #7761: Fix merge delay metric when there is empty bucket

2021-11-12 Thread GitBox
snleee opened a new pull request #7761: URL: https://github.com/apache/pinot/pull/7761 when we have the empty buckets (no more data push for the table). However, we still have some edge cases not covered. We found the issue where the table has some empty buckets and new fresh data

[GitHub] [pinot] Jackie-Jiang opened a new pull request #7760: Add getName() to PartitionFunction interface

2021-11-12 Thread GitBox
Jackie-Jiang opened a new pull request #7760: URL: https://github.com/apache/pinot/pull/7760 Add `getName()` to `PartitionFunction` interface, and replace the current usage of `toString()` `getName()` is required in order to serialize the name of the `PartitionFunction` in json -- Th

[pinot] branch master updated: Support Native FST As An Index Subtype for FST Indices (#7729)

2021-11-12 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 781f5cd Support Native FST As An Index Subtype f

[GitHub] [pinot] Jackie-Jiang merged pull request #7729: Support Native FST As An Index Subtype for FST Indices

2021-11-12 Thread GitBox
Jackie-Jiang merged pull request #7729: URL: https://github.com/apache/pinot/pull/7729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] jasperjiaguo closed pull request #7759: Bump-up azure-storage-file-datalake version

2021-11-12 Thread GitBox
jasperjiaguo closed pull request #7759: URL: https://github.com/apache/pinot/pull/7759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] jasperjiaguo opened a new pull request #7759: Bump-up azure-storage-file-datalake version

2021-11-12 Thread GitBox
jasperjiaguo opened a new pull request #7759: URL: https://github.com/apache/pinot/pull/7759 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) No Does this PR fix a zero-downtime upgrade

[GitHub] [pinot] jackjlli merged pull request #7739: Support default null value in data preprocessing job

2021-11-12 Thread GitBox
jackjlli merged pull request #7739: URL: https://github.com/apache/pinot/pull/7739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch master updated: Support default null value in data preprocessing job (#7739)

2021-11-12 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 068549c Support default null value in data preproc

[GitHub] [pinot] mcvsubbu closed issue #7741: Realtime consumer loses data when new partitions are detected in stream

2021-11-12 Thread GitBox
mcvsubbu closed issue #7741: URL: https://github.com/apache/pinot/issues/7741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[pinot] branch master updated: Use oldest offset on newly detected partitions (#7756)

2021-11-12 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 561b8a3 Use oldest offset on newly detected pa

[GitHub] [pinot] mcvsubbu merged pull request #7756: Use oldest offset on newly detected partitions

2021-11-12 Thread GitBox
mcvsubbu merged pull request #7756: URL: https://github.com/apache/pinot/pull/7756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] jackjlli commented on a change in pull request #7739: Support default null value in data preprocessing job

2021-11-12 Thread GitBox
jackjlli commented on a change in pull request #7739: URL: https://github.com/apache/pinot/pull/7739#discussion_r748630974 ## File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/AvroDataPreprocessingMapper.java ##

[GitHub] [pinot] snleee commented on a change in pull request #7739: Support default null value in data preprocessing job

2021-11-12 Thread GitBox
snleee commented on a change in pull request #7739: URL: https://github.com/apache/pinot/pull/7739#discussion_r748628416 ## File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/AvroDataPreprocessingMapper.java

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7739: Support default null value in data preprocessing job

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7739: URL: https://github.com/apache/pinot/pull/7739#issuecomment-965722902 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7739?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7739: Support default null value in data preprocessing job

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7739: URL: https://github.com/apache/pinot/pull/7739#issuecomment-965722902 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7739?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] Jackie-Jiang commented on issue #7758: Problems to use transform functions and ingest dateTime columns with RFC3339 format

2021-11-12 Thread GitBox
Jackie-Jiang commented on issue #7758: URL: https://github.com/apache/pinot/issues/7758#issuecomment-967703411 The value you provided are of format `-MM-dd'T'HH:mm:ss.SSSZ`. Notice there is no single quotes around `Z`. In the `dateTimeFieldSpecs`, the format should be `1:MILLISE

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7739: Support default null value in data preprocessing job

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7739: URL: https://github.com/apache/pinot/pull/7739#issuecomment-965722902 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7739?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7729: Support Native FST As An Index Subtype for FST Indices

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7729: URL: https://github.com/apache/pinot/pull/7729#issuecomment-964065900 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7729?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[pinot] branch support-default-null-value-in-preprocessing updated (08fbc20 -> 5c8f4f3)

2021-11-12 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch support-default-null-value-in-preprocessing in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 08fbc20 Support default null value in data preprocessing job add 5c8f4f3 Sup

[pinot] branch master updated: Fix controller error response field names (#7757)

2021-11-12 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b313a67 Fix controller error response field name

[GitHub] [pinot] Jackie-Jiang merged pull request #7757: Fix controller error response field names

2021-11-12 Thread GitBox
Jackie-Jiang merged pull request #7757: URL: https://github.com/apache/pinot/pull/7757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on pull request #7743: Always use SMALLEST offset criteria for new detected partitions

2021-11-12 Thread GitBox
Jackie-Jiang commented on pull request #7743: URL: https://github.com/apache/pinot/pull/7743#issuecomment-967575096 Close this one in favor of #7756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] Jackie-Jiang closed pull request #7743: Always use SMALLEST offset criteria for new detected partitions

2021-11-12 Thread GitBox
Jackie-Jiang closed pull request #7743: URL: https://github.com/apache/pinot/pull/7743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7756: Use oldest offset on newly detected partitions

2021-11-12 Thread GitBox
Jackie-Jiang commented on a change in pull request #7756: URL: https://github.com/apache/pinot/pull/7756#discussion_r748590526 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1232,18 +1232,

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7756: Use oldest offset on newly detected partitions

2021-11-12 Thread GitBox
mcvsubbu commented on a change in pull request #7756: URL: https://github.com/apache/pinot/pull/7756#discussion_r748460120 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1232,18 +1232,25 @

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7756: Use oldest offset on newly detected partitions

2021-11-12 Thread GitBox
mcvsubbu commented on a change in pull request #7756: URL: https://github.com/apache/pinot/pull/7756#discussion_r748460120 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1232,18 +1232,25 @

[GitHub] [pinot] richardstartin closed pull request #7702: add SPI for complex columns

2021-11-12 Thread GitBox
richardstartin closed pull request #7702: URL: https://github.com/apache/pinot/pull/7702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pinot] dianaarnos opened a new issue #7758: Problems to use transform functions and ingest dateTime columns with RFC3339 format

2021-11-12 Thread GitBox
dianaarnos opened a new issue #7758: URL: https://github.com/apache/pinot/issues/7758 Hi there, ### What am I trying to do? (in case I'm taking the wrong approach here and someone can point me to a better solution) I need to select all docs by month and year. Curren

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7757: Fix controller error response field names

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7757: URL: https://github.com/apache/pinot/pull/7757#issuecomment-967209074 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7757: Fix controller error response field names

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7757: URL: https://github.com/apache/pinot/pull/7757#issuecomment-967209074 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7757: Fix controller error response field names

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7757: URL: https://github.com/apache/pinot/pull/7757#issuecomment-967209074 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7757: Return {code: '', error: ''} instead of {_code: '', _error: ''} when …

2021-11-12 Thread GitBox
codecov-commenter edited a comment on pull request #7757: URL: https://github.com/apache/pinot/pull/7757#issuecomment-967209074 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7757: Return {code: '', error: ''} instead of {_code: '', _error: ''} when …

2021-11-12 Thread GitBox
codecov-commenter commented on pull request #7757: URL: https://github.com/apache/pinot/pull/7757#issuecomment-967209074 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] mneedham opened a new pull request #7757: Return {code: '', error: ''} instead of {_code: '', _error: ''} when …

2021-11-12 Thread GitBox
mneedham opened a new pull request #7757: URL: https://github.com/apache/pinot/pull/7757 …we have errors ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as *