Jackie-Jiang commented on a change in pull request #7756:
URL: https://github.com/apache/pinot/pull/7756#discussion_r748590526
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -1232,18 +1232,25 @@ private LLCSegmentName
getNextLLCSegmentName(LLCSegmentName lastLLCSegmentName,
*/
private String setupNewPartitionGroup(TableConfig tableConfig,
PartitionLevelStreamConfig streamConfig,
PartitionGroupMetadata partitionGroupMetadata, long creationTimeMs,
InstancePartitions instancePartitions,
- int numPartitionGroups, int numReplicas, List<PartitionGroupMetadata>
partitionGroupMetadataList) {
+ int numPartitionGroups, int numReplicas, List<PartitionGroupMetadata>
partitionGroupMetadataList,
+ boolean isLiveTable) {
String realtimeTableName = tableConfig.getTableName();
int partitionGroupId = partitionGroupMetadata.getPartitionGroupId();
- String startOffset = partitionGroupMetadata.getStartOffset().toString();
+ StreamPartitionMsgOffset startOffset;
+ if (isLiveTable) {
+ startOffset = getPartitionGroupSmallestOffset(streamConfig,
partitionGroupId);
Review comment:
Fair enough. Let's go with this approach and probably restructure the
code in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
