codecov-commenter edited a comment on pull request #7485:
URL: https://github.com/apache/pinot/pull/7485#issuecomment-926975597
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7485?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7482:
URL: https://github.com/apache/pinot/pull/7482#issuecomment-926322674
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7485:
URL: https://github.com/apache/pinot/pull/7485#issuecomment-926975597
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7485?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7482:
URL: https://github.com/apache/pinot/pull/7482#issuecomment-926322674
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7485:
URL: https://github.com/apache/pinot/pull/7485#issuecomment-926975597
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7485?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7482:
URL: https://github.com/apache/pinot/pull/7482#issuecomment-926322674
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7485:
URL: https://github.com/apache/pinot/pull/7485#issuecomment-926975597
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7485?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
Jackie-Jiang commented on a change in pull request #7485:
URL: https://github.com/apache/pinot/pull/7485#discussion_r715954242
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/function/InbuiltFunctionEvaluatorTest.java
##
@@ -120,10 +128,27 @@ public void test
codecov-commenter edited a comment on pull request #7482:
URL: https://github.com/apache/pinot/pull/7482#issuecomment-926322674
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from cd7cf77 do not allow qualification of member variables with this
(#7484)
add d99eb3c bit-sliced range index fo
Jackie-Jiang merged pull request #7454:
URL: https://github.com/apache/pinot/pull/7454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7481:
URL: https://github.com/apache/pinot/pull/7481#discussion_r715951030
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenera
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
walterddr opened a new pull request #7485:
URL: https://github.com/apache/pinot/pull/7485
Currently if there's a double quoted PQL syntax ingestion transform such as
```
"ingestionConfig": {
"transformConfigs": [
{
"columnName": "created_at_timestamp",
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7482:
URL: https://github.com/apache/pinot/pull/7482#issuecomment-926322674
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7482:
URL: https://github.com/apache/pinot/pull/7482#issuecomment-926322674
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
kkrugler commented on issue #6364:
URL: https://github.com/apache/pinot/issues/6364#issuecomment-926936620
You could also remove a number of log4j entries from the dependency
management section of the top-level `pom.xml`, as once you have a dependency on
`log4j-slf4j-impl`, that pulls in `
kkrugler commented on issue #6364:
URL: https://github.com/apache/pinot/issues/6364#issuecomment-926936385
And the following components (maybe others?) would need to add non-test
dependencies on `log4j-slf4j-impl`:
- broker
- controller
- server
- tools
--
This is an
kkrugler commented on issue #6364:
URL: https://github.com/apache/pinot/issues/6364#issuecomment-926935890
In addition to `pinot-spi`, there's also `pinot-common` that has a non-test
dependency on log4j.
--
This is an automated message from the Apache Git Service.
To respond to the m
snleee commented on a change in pull request #7481:
URL: https://github.com/apache/pinot/pull/7481#discussion_r71579
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
kkrugler commented on issue #7393:
URL: https://github.com/apache/pinot/issues/7393#issuecomment-926923172
I'm going to close this issue, as PR #7400 resolves the specific problem
mentioned here.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
kkrugler closed issue #7393:
URL: https://github.com/apache/pinot/issues/7393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
mapshen commented on pull request #6840:
URL: https://github.com/apache/pinot/pull/6840#issuecomment-926898018
@npawar it would be great if we can have an example value and a model in the
Swagger page for this API, similar to what we have for the
`/tables/validateTableAndSchema` API.
--
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 8a05ad8 fix segemnt uploader property in auth quickstart (#7479)
add cd7cf77 do not allow qualification of memb
Jackie-Jiang merged pull request #7484:
URL: https://github.com/apache/pinot/pull/7484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7474:
URL: https://github.com/apache/pinot/pull/7474#issuecomment-925970171
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7474:
URL: https://github.com/apache/pinot/pull/7474#issuecomment-925970171
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8a05ad8 fix segemnt uploader property in auth q
apucher merged pull request #7479:
URL: https://github.com/apache/pinot/pull/7479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f67666a define and enforce static import code s
mayankshriv merged pull request #7483:
URL: https://github.com/apache/pinot/pull/7483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
richardstartin commented on pull request #7484:
URL: https://github.com/apache/pinot/pull/7484#issuecomment-926746697
flaky test
>
MetadataAndDictionaryAggregationPlanClusterIntegrationTest.setUp:67->ClusterTest.uploadSegments:356
--
This is an automated message from the Apache Gi
richardstartin edited a comment on issue #7476:
URL: https://github.com/apache/pinot/issues/7476#issuecomment-926717352
Thanks for the information. This is quite a complex issue. What that stack
trace means is that some call to `Unsafe.get` or `Unsafe.put` led to a SIGBUS
error, which was
richardstartin edited a comment on issue #7476:
URL: https://github.com/apache/pinot/issues/7476#issuecomment-926717352
Thanks for the information. This is quite a complex issue. What that stack
trace means is that some call to `Unsafe.get` or `Unsafe.put` led to a SIGBUS
error, which was
richardstartin commented on issue #7476:
URL: https://github.com/apache/pinot/issues/7476#issuecomment-926717352
Thanks for the information. This is quite a complex issue. What that stack
trace means is that some call to `Unsafe.get` or `Unsafe.put` led to a SIGBUS
error, which was caught
codecov-commenter edited a comment on pull request #7483:
URL: https://github.com/apache/pinot/pull/7483#issuecomment-926672972
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7483:
URL: https://github.com/apache/pinot/pull/7483#issuecomment-926672972
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7483:
URL: https://github.com/apache/pinot/pull/7483#issuecomment-926672972
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7483:
URL: https://github.com/apache/pinot/pull/7483#issuecomment-926672972
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
kishoreg commented on pull request #7484:
URL: https://github.com/apache/pinot/pull/7484#issuecomment-926664352
Thank you so much for taking care of these things.
This will allow us to focus on reviewing code logic vs formatting and style
--
This is an automated message from the A
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715644357
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java
##
@@ -0,0 +
richardstartin opened a new pull request #7484:
URL: https://github.com/apache/pinot/pull/7484
## Description
Code like `this.foo = foo` is common elsewhere in the Java ecosystem, but
pinot prefixes member variables with an underscore. Style violations like
`this._foo = foo` frequently
richardstartin opened a new pull request #7483:
URL: https://github.com/apache/pinot/pull/7483
## Description
Not using static imports under `src/main` frequently in code review, yet
often the same static imports are present elsewhere in the codebase. This PR
aims to standardise this so
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715457907
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/FPOrdering.java
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Ap
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-926451534
@Jackie-Jiang I have addressed your comments here:
https://github.com/apache/pinot/pull/7454/commits/2e6c4307ceb3412cdfecdd5a71a7e6c04117261c
but have squashed the commits
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715398329
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java
##
@@ -0,0 +
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715398014
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
##
@@ -0,0 +1,12
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715397527
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java
##
@@ -0,0 +
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715396938
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/FPOrdering.java
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Ap
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715396655
##
File path:
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/FPOrderingTest.java
##
@@ -0,0 +1,133 @@
+/**
+ * Licensed to t
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715396214
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/FPOrdering.java
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Ap
mqliang commented on a change in pull request #7397:
URL: https://github.com/apache/pinot/pull/7397#discussion_r715382060
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -487,6 +491,11 @@ private BrokerRespons
snleee commented on a change in pull request #7481:
URL: https://github.com/apache/pinot/pull/7481#discussion_r715356933
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
mqliang commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715378578
##
File path:
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/creator/BitSlicedIndexCreatorTest.java
##
@@ -0,0 +1,487 @@
+/
suddendust edited a comment on issue #7476:
URL: https://github.com/apache/pinot/issues/7476#issuecomment-926405315
@richardstartin here're the env details:
1. Pinot Version: 0.7.1.
2. JVM Version: 1.8.
3. Instance Type: m5.4xlarge
4. OS Image: Ubuntu 18.04.5 LTS, Operating Syste
suddendust commented on issue #7476:
URL: https://github.com/apache/pinot/issues/7476#issuecomment-926405315
@richardstartin here's the env details:
1. Pinot Version: 0.7.1.
2. JVM Version: 1.8.
3. Instance Type: m5.4xlarge
4. OS Image: Ubuntu 18.04.5 LTS, Operating System: linux
73 matches
Mail list logo
