richardstartin opened a new pull request #7483: URL: https://github.com/apache/pinot/pull/7483
## Description Not using static imports under `src/main` frequently in code review, yet often the same static imports are present elsewhere in the codebase. This PR aims to standardise this so time is not wasted enforcing this in code review, and so enforcement is consistent. This PR: * uses the `AvoidStaticImport` rule * suppresses the rule for `src/test` * excludes certain classes wherever the class is already statically imported somewhere and code would be much more verbose (e.g. some JDK utilities, `Precoditions`, pinot constant classes, `DataType`) * Makes some code changes to avoid adding excludes to the rule. Merging this PR should * mean that it is agreed when static imports are OK to use in Pinot and when they are not. * prevent discussion of formatting during code review. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
