snleee commented on a change in pull request #7470:
URL: https://github.com/apache/pinot/pull/7470#discussion_r714487620
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
##
@@ -164,7 +164,8 @@ private void
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fcae6e0 hotfix for #7459 (#7471)
fcae6e0 is des
apucher merged pull request #7471:
URL: https://github.com/apache/pinot/pull/7471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
codecov-commenter edited a comment on pull request #7470:
URL: https://github.com/apache/pinot/pull/7470#issuecomment-925455921
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7470:
URL: https://github.com/apache/pinot/pull/7470#issuecomment-925455921
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7471:
URL: https://github.com/apache/pinot/pull/7471#issuecomment-925450378
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7468:
URL: https://github.com/apache/pinot/pull/7468#issuecomment-925343469
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7471:
URL: https://github.com/apache/pinot/pull/7471#issuecomment-925450378
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7468:
URL: https://github.com/apache/pinot/pull/7468#issuecomment-925343469
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
walterddr commented on pull request #7469:
URL: https://github.com/apache/pinot/pull/7469#issuecomment-925446068
> We need to add the `license:check` as well lol
this is a dummy PR triggered just so CI can break. I will address this
separately. thanks for bringing it up
--
This is
walterddr closed pull request #7469:
URL: https://github.com/apache/pinot/pull/7469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
codecov-commenter edited a comment on pull request #7468:
URL: https://github.com/apache/pinot/pull/7468#issuecomment-925343469
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
jtao15 commented on a change in pull request #7427:
URL: https://github.com/apache/pinot/pull/7427#discussion_r714412469
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java
##
@@ -156,7 +167,10 @@ private void processExistingSegm
jtao15 commented on a change in pull request #7427:
URL: https://github.com/apache/pinot/pull/7427#discussion_r714412303
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java
##
@@ -118,10 +127,12 @@ private void processExistingSeg
jtao15 commented on a change in pull request #7427:
URL: https://github.com/apache/pinot/pull/7427#discussion_r714412074
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java
##
@@ -58,18 +58,25 @@ public ZKOperator(PinotHelixResou
walterddr opened a new pull request #7471:
URL: https://github.com/apache/pinot/pull/7471
hotfix for #7459.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
jtao15 commented on a change in pull request #7427:
URL: https://github.com/apache/pinot/pull/7427#discussion_r714411453
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##
@@ -387,15 +391,15
jtao15 commented on a change in pull request #7427:
URL: https://github.com/apache/pinot/pull/7427#discussion_r714411373
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##
@@ -298,10 +298,14
Jackie-Jiang commented on pull request #7469:
URL: https://github.com/apache/pinot/pull/7469#issuecomment-925432533
We need to add the `license:check` as well lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 34d987d add a linter checker (#7466)
34d987d is
Jackie-Jiang merged pull request #7466:
URL: https://github.com/apache/pinot/pull/7466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch fix-missing-rate-limiter
in repository https://gitbox.apache.org/repos/asf/pinot.git.
omit 1414ebd Fix missing rate limiter if brokerResourceEV becomes null due
to ZK connection
add 479e
jackjlli opened a new pull request #7470:
URL: https://github.com/apache/pinot/pull/7470
## Description
This PR fixes missing rate limiter if brokerResourceEV becomes null due to
the ZK connection issue.
When brokerResourceEV is null due to ZK connection issue, we shouldn't
consider
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch fix-missing-rate-limiter
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 1414ebd8175f6b2fac5439d5505be9e29aea619a
Author: Jack Li(Analytics Engineering)
AuthorDate: Wed Sep 22 17
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch fix-missing-rate-limiter
in repository https://gitbox.apache.org/repos/asf/pinot.git.
at 1414ebd Fix missing rate limiter if brokerResourceEV becomes null due
to ZK connection
This branch
codecov-commenter edited a comment on pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#issuecomment-925300551
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#issuecomment-925300551
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7468:
URL: https://github.com/apache/pinot/pull/7468#issuecomment-925343469
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#issuecomment-925300551
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on pull request #7468:
URL: https://github.com/apache/pinot/pull/7468#issuecomment-925332637
Flaky test?
```
Error: Failures:
8701
Error:
NotEqualsTransformFunctionTest>BinaryOperatorTransformFunctionTest.testBinaryOperatorTransformFunction:77-
richardstartin edited a comment on pull request #7468:
URL: https://github.com/apache/pinot/pull/7468#issuecomment-925311763
Just in case the `String` change is contentious, this will definitely not
cause a performance regression:
```java
@State(Scope.Benchmark)
public class St
richardstartin commented on pull request #7468:
URL: https://github.com/apache/pinot/pull/7468#issuecomment-925311763
Just in case the `String` change is contentious, this will not definitely
not cause a performance regression:
```java
@State(Scope.Benchmark)
public class Strin
codecov-commenter edited a comment on pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#issuecomment-925300551
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
walterddr commented on a change in pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#discussion_r714287603
##
File path: .github/workflows/pinot_tests.yml
##
@@ -38,6 +38,19 @@ on:
- "**.md"
jobs:
+ linter-test:
+runs-on: ubuntu-latest
+name:
walterddr commented on a change in pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#discussion_r714287456
##
File path: .github/workflows/scripts/.pinot_linter.sh
##
@@ -0,0 +1,35 @@
+#!/bin/bash -x
+#
+# Licensed to the Apache Software Foundation (ASF) under
walterddr commented on a change in pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#discussion_r714287377
##
File path: .github/workflows/scripts/.pinot_linter.sh
##
@@ -0,0 +1,35 @@
+#!/bin/bash -x
+#
+# Licensed to the Apache Software Foundation (ASF) under
richardstartin opened a new pull request #7468:
URL: https://github.com/apache/pinot/pull/7468
## Description
The vast majority if not all of these will be benign, but this change set
prevents emptiness checks from becoming bottlenecks if collection
implementation is changed. Applies si
codecov-commenter commented on pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#issuecomment-925300551
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 72d05a7 fix auth token injection in
SegmentGen
apucher merged pull request #7464:
URL: https://github.com/apache/pinot/pull/7464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
Jackie-Jiang commented on a change in pull request #7466:
URL: https://github.com/apache/pinot/pull/7466#discussion_r714277767
##
File path: .github/workflows/pinot_tests.yml
##
@@ -38,6 +38,19 @@ on:
- "**.md"
jobs:
+ linter-test:
+runs-on: ubuntu-latest
+na
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 5b15f08 add SingleSpaceSeparator rule and fix recent violations
(#7467)
add c22886a add causes to stack trace
Jackie-Jiang merged pull request #7460:
URL: https://github.com/apache/pinot/pull/7460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
Jackie-Jiang closed issue #7453:
URL: https://github.com/apache/pinot/issues/7453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 4972110 Unify CombineOperator multi-threading logic (#7450)
add 5b15f08 add SingleSpaceSeparator rule and fix
codecov-commenter edited a comment on pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#issuecomment-925249280
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
kishoreg merged pull request #7467:
URL: https://github.com/apache/pinot/pull/7467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
richardstartin opened a new pull request #7467:
URL: https://github.com/apache/pinot/pull/7467
## Description
I recently committed changes with double white spaces by mistake. This
removes them and adds a checkstyle rule to prevent it from happening again.
## Upgrade Notes
Does thi
walterddr opened a new pull request #7466:
URL: https://github.com/apache/pinot/pull/7466
Create a linter-test.
This would help CI to fail-fast when checkstyle/linter/spotless/rat is
broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
codecov-commenter edited a comment on pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#issuecomment-925249280
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#issuecomment-925249280
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter commented on pull request #7464:
URL: https://github.com/apache/pinot/pull/7464#issuecomment-925247285
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7464?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#discussion_r714213516
##
File path: pinot-segment-local/pom.xml
##
@@ -156,5 +156,25 @@
test-jar
test
+
Review comment:
Shall we revert these
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang opened a new issue #7465:
URL: https://github.com/apache/pinot/issues/7465
Querying Pinot doc link:
https://docs.pinot.apache.org/users/user-guide-query/querying-pinot
Some pinot quirks not documented yet:
- Group-by has default `LIMIT` of 10
- Group-by query trims
apucher opened a new pull request #7464:
URL: https://github.com/apache/pinot/pull/7464
## Description
Fixes a missing auth token injection from taskConfigs to job spec in
`SegmentGenerationAndPushTaskExecutor`.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (A
codecov-commenter edited a comment on pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#issuecomment-917372847
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch fix-segment-gen-push-auth-token
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 65dd5767d6fcc80d3720d964021747cda01acb3b
Author: Alexander Pucher
AuthorDate: Wed Sep 22 11:23:
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch fix-segment-gen-push-auth-token
in repository https://gitbox.apache.org/repos/asf/pinot.git.
at 65dd576 fix auth token injection in
SegmentGenerationAndPushTaskExecutor
This branch incl
xiangfu0 commented on issue #7461:
URL: https://github.com/apache/pinot/issues/7461#issuecomment-925171218
Make sense, we should quotes those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
hristo-stripe opened a new issue #7463:
URL: https://github.com/apache/pinot/issues/7463
We've tried running `select distinctcount(field) from table` which times out
with the default timeout.
However, running
`select distinctcount(field) from table_REALTIME`
and
`select dist
Jackie-Jiang commented on issue #7461:
URL: https://github.com/apache/pinot/issues/7461#issuecomment-925154122
@xiangfu0 ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
atris commented on a change in pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#discussion_r714144026
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/nativefst/ConstantArcSizeFST.java
##
@@ -0,0 +1,159 @@
+/**
+ * Licensed
GSharayu opened a new issue #7462:
URL: https://github.com/apache/pinot/issues/7462
This issue is follow up of Issue(#6972): Implement
PassThroughTransformOperator to optimize select queries.
If the user runs simple SELECT queries without involving any
transformations, Pinot can he
walterddr commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r714069330
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -144,17 +153,29 @@ public static ProcessingException
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r714070879
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
##
@@ -0,0 +1,17
walterddr commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r714070904
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -144,17 +153,29 @@ public static ProcessingException
walterddr commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r714069330
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -144,17 +153,29 @@ public static ProcessingException
walterddr commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r714069330
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -144,17 +153,29 @@ public static ProcessingException
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r714065912
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java
##
@@ -0,0 +
richardstartin commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r714019372
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -144,17 +153,29 @@ public static ProcessingExce
JKL98ISR opened a new issue #7461:
URL: https://github.com/apache/pinot/issues/7461
I have a field called date in my database so I need to use double quotes to
not get a parse error.
When I use double quotes in the Pinot console UI it runs the query normally.
In Presto it seems like t
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on issue #7437:
URL: https://github.com/apache/pinot/issues/7437#issuecomment-924715637
I think it's important to discuss data distribution when considering bucket
assignment by value. The Achilles heel of bucketing by value is skewed
distributions, which might be
77 matches
Mail list logo
