[pinot] 01/01: Fix missing rate limiter if brokerResourceEV becomes null due to ZK connection

[jlli]

This is an automated email from the ASF dual-hosted git repository.

jlli pushed a commit to branch fix-missing-rate-limiter
in repository https://gitbox.apache.org/repos/asf/pinot.git

commit 1414ebd8175f6b2fac5439d5505be9e29aea619a
Author: Jack Li(Analytics Engineering) <j...@jlli-mn1.linkedin.biz>
AuthorDate: Wed Sep 22 17:02:16 2021 -0700

    Fix missing rate limiter if brokerResourceEV becomes null due to ZK 
connection
---
 .../broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
 
b/pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
index 216f827..a13f4d1 100644
--- 
a/pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
+++ 
b/pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
@@ -164,7 +164,8 @@ public class HelixExternalViewBasedQueryQuotaManager 
implements ClusterChangeHan
 
     if (brokerResource == null) {
       LOGGER.warn("Failed to init qps quota for table {}. No broker resource 
connected!", tableNameWithType);
-      buildEmptyOrResetRateLimiterInQueryQuotaEntity(tableNameWithType);
+      // It could be possible that brokerResourceEV due to ZK connection issue.
+      // In this case, the rate limiter should not be reset. Simply exit the 
method would be sufficient.
       return;
     }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org