codecov-commenter edited a comment on pull request #7225:
URL: https://github.com/apache/pinot/pull/7225#issuecomment-44533
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7225?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7225:
URL: https://github.com/apache/pinot/pull/7225#issuecomment-44533
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7225?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
suddendust commented on issue #7187:
URL: https://github.com/apache/pinot/issues/7187#issuecomment-33059
That will be a good starting step for sure. However, can we also have an
optional config that the user can set explicitly if the header delimiter is
different than the CSV delimiter
snleee opened a new pull request #7225:
URL: https://github.com/apache/pinot/pull/7225
Updated LICENCE-binary, NOTICE-binary.
Added extra license files under `/licenses-binary`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
codecov-commenter edited a comment on pull request #7178:
URL: https://github.com/apache/pinot/pull/7178#issuecomment-882751873
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7178:
URL: https://github.com/apache/pinot/pull/7178#issuecomment-882751873
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
kkrugler edited a comment on pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#issuecomment-888686908
Hi @Jackie-Jiang - a few things about this WIP...
1. The inputFilePath that I'm getting passed inside the
`SegmentGeneratorConfig`, which is passed to `SegmentIndexC
kkrugler edited a comment on pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#issuecomment-888686908
Hi @Jackie-Jiang - a few things about this WIP...
1. The inputFilePath that I'm getting passed inside the
`SegmentGeneratorConfig`, which is passed to `SegmentIndexC
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5af6078 Fix the shaded issue with Apache Pulsar (
snleee merged pull request #7223:
URL: https://github.com/apache/pinot/pull/7223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
codecov-commenter edited a comment on pull request #7223:
URL: https://github.com/apache/pinot/pull/7223#issuecomment-888733361
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
jtao15 commented on a change in pull request #7178:
URL: https://github.com/apache/pinot/pull/7178#discussion_r678762208
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskGenerator.j
jtao15 commented on a change in pull request #7178:
URL: https://github.com/apache/pinot/pull/7178#discussion_r678761759
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskGenerator.j
codecov-commenter commented on pull request #7223:
URL: https://github.com/apache/pinot/pull/7223#issuecomment-888733361
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7224:
URL: https://github.com/apache/pinot/pull/7224#issuecomment-888711169
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7224:
URL: https://github.com/apache/pinot/pull/7224#issuecomment-888711169
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#issuecomment-888708262
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7222?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#issuecomment-888708262
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7222?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
Jackie-Jiang commented on a change in pull request #7224:
URL: https://github.com/apache/pinot/pull/7224#discussion_r678726827
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##
@@ -201,27 +201,27 @@ public String toString(Object value
klsince commented on pull request #7224:
URL: https://github.com/apache/pinot/pull/7224#issuecomment-888690584
Came into this issue while using jsonPathArray() during ingestion to extract
the `id` field from `labels` JSONArray into a Pinot MV column. The output array
from jsonPathArray() h
klsince opened a new pull request #7224:
URL: https://github.com/apache/pinot/pull/7224
During ingestion, the array to put in MV column can contain mixing types.
This fix would allow mixing numeric types in an array to be put in a numeric MV
column.
## Description
## Upgrade
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a change to branch release-0.8.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git.
discard 798190a Fix the shaded issue with Apache Pulsar
new fa7d7f3 Fix the shaded issue with Apache Pulsar
T
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch release-0.8.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit fa7d7f3fbff73300f0f38aad37491bfefad6aacc
Author: Seunghyun Lee
AuthorDate: Wed Jul 28 16:18:35 2021 -0700
F
kkrugler commented on pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#issuecomment-888686908
Hi @Jackie-Jiang - a few things about this WIP...
1. The inputFilePath that I'm getting passed inside the
`SegmentGeneratorConfig`, which is passed to `SegmentIndexCreation
snleee opened a new pull request #7223:
URL: https://github.com/apache/pinot/pull/7223
As mentioned in #7221, Apache Pulsar plugin did not create the
shaded jar. This PR addresses it. Moreover, we also fix the
javadoc lint issue when building the apache release.
--
This is an automa
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from c2c887a allow to extract values from array of objects with
jsonPathArray (#7208)
add 069bae0 Bump up the "grpc-
snleee merged pull request #7220:
URL: https://github.com/apache/pinot/pull/7220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch release-0.8.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-0.8.0-rc by this push:
new 798190a Fix the shaded issue
kkrugler opened a new pull request #7222:
URL: https://github.com/apache/pinot/pull/7222
## Description
First cut at resolving #7090, to support generating segment names based on
the input file path and a specified pattern/template.
## Upgrade Notes
Does this PR prevent a zero down
snleee opened a new issue #7221:
URL: https://github.com/apache/pinot/issues/7221
Currently, Apache Pulsar plugin doesn't create the shaded jar.
```
~/workspace/pinot/pinot-plugins/pinot-stream-ingestion/pinot-pulsar/target
release-0.8.0-rc*
❯ ll
-rw-r--r-- 1 snlee staff
mayankshriv commented on issue #7187:
URL: https://github.com/apache/pinot/issues/7187#issuecomment-888576408
I think the code and user point-of-view are contradicting here. It is very
natural for users to provide a comma separated header string. May be we should
gracefully error out right
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c2c887a allow to extract values from array of ob
Jackie-Jiang merged pull request #7208:
URL: https://github.com/apache/pinot/pull/7208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
codecov-commenter edited a comment on pull request #7220:
URL: https://github.com/apache/pinot/pull/7220#issuecomment-888549770
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7220?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7220:
URL: https://github.com/apache/pinot/pull/7220#issuecomment-888549770
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7220?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7208:
URL: https://github.com/apache/pinot/pull/7208#issuecomment-887128823
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7208:
URL: https://github.com/apache/pinot/pull/7208#issuecomment-887128823
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
suddendust commented on issue #7187:
URL: https://github.com/apache/pinot/issues/7187#issuecomment-888514315
@mayankshriv let me know what you think of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
suddendust edited a comment on issue #7212:
URL: https://github.com/apache/pinot/issues/7212#issuecomment-888014290
@Jackie-Jiang I can pick this up if it's not urgent (I will need to read
the theory behind these).
--
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch release-0.8.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-0.8.0-rc by this push:
new ca99cfe Bump up the "grpc-pro
snleee opened a new pull request #7220:
URL: https://github.com/apache/pinot/pull/7220
gprc-protobuf-lite:1.18.0 pulls the
"org.checkerframework:checker-compat-qual"
library which is based on GPL v2. GPL v2 is one of category X licenses that
are not allowed to include in Apache releas
jackjlli commented on a change in pull request #7210:
URL: https://github.com/apache/pinot/pull/7210#discussion_r678507134
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -498,6 +517,36 @@ private BrokerRespon
yupeng9 commented on pull request #7200:
URL: https://github.com/apache/pinot/pull/7200#issuecomment-888469546
@Jackie-Jiang makes sense. updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov-commenter commented on pull request #7219:
URL: https://github.com/apache/pinot/pull/7219#issuecomment-888427732
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7219?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
wuwenw opened a new pull request #7219:
URL: https://github.com/apache/pinot/pull/7219
## Description
Group-by issue: If there are too many groups, then it takes up too much
memory and the garbage collection process becomes a major performance
bottleneck.
Current Approach: When t
MrNeocore commented on issue #7090:
URL: https://github.com/apache/pinot/issues/7090#issuecomment-888197579
@kkrugler I see, thanks for the clarification !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
atris opened a new issue #7218:
URL: https://github.com/apache/pinot/issues/7218
Our FTS capabilities are pretty limited right now -- REGEXP_MATCH does a
primitive regex match and TEXT_MATCHES is simply a wrapper around basic Lucene
level searching (does not expose fuzzy queries or the opt
atris opened a new issue #7217:
URL: https://github.com/apache/pinot/issues/7217
When creating text indices, we use Lucene's stored fields to store the DocID
field inside the index. This is inefficient due stored fields' representation
within Lucene.
A more efficient way would be us
atris opened a new issue #7216:
URL: https://github.com/apache/pinot/issues/7216
During text index creation, we pass in a hard coded list of stop words which
limits the vocabulary that we can use to filter words before indexing.
We should use Lucene's StopFilter and read the list of
atris opened a new issue #7215:
URL: https://github.com/apache/pinot/issues/7215
We force merge all segments of a single Lucene index to a single segment for
text indices today, thus potentially creating a single large segment and
restricting the possibility of searching multiple segments
atris closed issue #7194:
URL: https://github.com/apache/pinot/issues/7194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pin
atris commented on issue #7190:
URL: https://github.com/apache/pinot/issues/7190#issuecomment-888119012
Why do we not use Lucene's geo functions to achieve some of these (such as
contains)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
atris commented on issue #7194:
URL: https://github.com/apache/pinot/issues/7194#issuecomment-888118482
This has been resolved with the new CompositePredicateEvaluator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
53 matches
Mail list logo
