codecov-commenter edited a comment on pull request #7057:
URL: https://github.com/apache/incubator-pinot/pull/7057#issuecomment-861107598
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #7057:
URL: https://github.com/apache/incubator-pinot/pull/7057#issuecomment-861107598
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter commented on pull request #7057:
URL: https://github.com/apache/incubator-pinot/pull/7057#issuecomment-861107598
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
Jackie-Jiang opened a new pull request #7057:
URL: https://github.com/apache/incubator-pinot/pull/7057
- Fix realtime-table with raw JSON data type index
- Enhance `JsonExtractScalarTransformFunction`:
- Handle exception when reading json path
- Reuse value buffer
- In json q
codecov-commenter edited a comment on pull request #6998:
URL: https://github.com/apache/incubator-pinot/pull/6998#issuecomment-852478013
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6998?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #6998:
URL: https://github.com/apache/incubator-pinot/pull/6998#issuecomment-852478013
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6998?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 4fe7153 Make Pinot JDK 11 Compilable (#6424)
add 7081683 Upgrade t-digest to latest release (#7029)
mayankshriv merged pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this ser
codecov-commenter edited a comment on pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#issuecomment-823815012
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#issuecomment-823815012
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
Jackie-Jiang commented on a change in pull request #7052:
URL: https://github.com/apache/incubator-pinot/pull/7052#discussion_r651297625
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
##
@@ -213,6 +213,8 @@
public static final St
siddharthteotia commented on pull request #7056:
URL: https://github.com/apache/incubator-pinot/pull/7056#issuecomment-861018781
> > @siddharthteotia BTW, the PR change the metadata file layout, so will
bring incompatibility. Let's discuss that.
>
> Hmm, this is a read-only api, righ
liuchang0520 commented on a change in pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r651292908
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -1214
liuchang0520 commented on a change in pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r651292577
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -1214
liuchang0520 commented on a change in pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r651291490
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -1214
liuchang0520 commented on a change in pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r651289057
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java
##
@@ -67,6 +67,22
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4fe7153 Make Pinot JDK 11 Compilable
xiangfu0 merged pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
xiangfu0 commented on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-860979673
Discussed with @mcvsubbu @siddharthteotia @jackjlli offline, we will keep
the JDK 8 support longer for LinkedIn to test and validate their deployment and
data ingestion
walterddr edited a comment on issue #6939:
URL:
https://github.com/apache/incubator-pinot/issues/6939#issuecomment-860721175
this sounds like a cool feature. I would like to try implementing it. To
clarify a few details.
- this feature only applies on the admin query layer?
- is t
snleee closed issue #6785:
URL: https://github.com/apache/incubator-pinot/issues/6785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
snleee commented on issue #6785:
URL:
https://github.com/apache/incubator-pinot/issues/6785#issuecomment-860910369
Closing the ticket since it's addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
codecov-commenter commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860858846
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
Jackie-Jiang commented on a change in pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#discussion_r651130777
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/TableConfigUtilsTest.java
##
@@ -1098,4 +1105,46 @@ public void testValida
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860848772
Cool.
The change here is a new artifact in maven central so your manual restart
was just the thing.
On Mon, Jun 14, 2021 at 9:42 AM Mayank Shriva
mayankshriv commented on pull request #7056:
URL: https://github.com/apache/incubator-pinot/pull/7056#issuecomment-860841240
I also recommend the following:
1. We should add other info like the index/dictionary size.
2. Any zk metadata (seems as though you may have already added it).
mayankshriv commented on pull request #7056:
URL: https://github.com/apache/incubator-pinot/pull/7056#issuecomment-860830239
> @siddharthteotia BTW, the PR change the metadata file layout, so will
bring incompatibility. Let's discuss that.
Hmm, this is a read-only api, right? If so,
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860829270
@tdunning, I have relaunched the tests. Typically an update in your branch
will relaunch them.
--
This is an automated message from the Apache Git Service.
To
mayankshriv removed a comment on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860828570
Ted, I have re-launched the tests. Typically an update of your branch will
relaunch it as well.
--
This is an automated message from the Apache Git Service
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860828570
Ted, I have re-launched the tests. Typically an update of your branch will
relaunch it as well.
--
This is an automated message from the Apache Git Service.
To res
Jackie-Jiang commented on a change in pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#discussion_r651107004
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##
@@ -60,128 +64,
mcvsubbu commented on pull request #7046:
URL: https://github.com/apache/incubator-pinot/pull/7046#issuecomment-860827020
Please add conversion to use `FieldConfig` instead of individual
configurations as well.
Also, we need to mark this for release notes (I assume we will deprecate the
shailesh-accuknox commented on issue #4705:
URL:
https://github.com/apache/incubator-pinot/issues/4705#issuecomment-860751538
What will be the -format for GCS??
Getting errors like:
Failed to generate Pinot segment for file
java.lang.IllegalStateException: Invalid segment start
walterddr commented on issue #6939:
URL:
https://github.com/apache/incubator-pinot/issues/6939#issuecomment-860721175
this sounds like a cool feature. I would like to try implementing it. To
clarify a few details.
- this feature only applies on the admin query layer?
- is there a
mayankshriv merged pull request #47:
URL: https://github.com/apache/incubator-pinot-site/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
troywinter opened a new pull request #7054:
URL: https://github.com/apache/incubator-pinot/pull/7054
Skip the number format exception in SumFunction:
When SumFunction failed convert a column from string value to double, it
will just throw exception to user. For column with double or int,
codecov-commenter commented on pull request #7054:
URL: https://github.com/apache/incubator-pinot/pull/7054#issuecomment-860049455
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
ChethanUK opened a new pull request #47:
URL: https://github.com/apache/incubator-pinot-site/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
troywinter closed pull request #7054:
URL: https://github.com/apache/incubator-pinot/pull/7054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this serv
mqliang opened a new pull request #7056:
URL: https://github.com/apache/incubator-pinot/pull/7056
## Description
This PR:
* change the server API
`@Path("/tables/{tableName}/segments/{segmentName}/metadata")` return all
columns's metadata by default (if user does not provide
tdunning edited a comment on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860384640
OK. The artifacts on maven central are now complete and correct. No changes
to existing artifacts were needed so Pinot can continue with the t-digest
version 3.3
Jackie-Jiang commented on issue #7055:
URL:
https://github.com/apache/incubator-pinot/issues/7055#issuecomment-860312480
We have removed ThirdEye from Pinot repo in preparation for Apache Incubator
graduation. @xiangfu0 Do we have a separate repo for ThirdEye alone?
--
This is an automa
mqliang commented on pull request #7056:
URL: https://github.com/apache/incubator-pinot/pull/7056#issuecomment-860430480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
siddharthteotia merged pull request #7053:
URL: https://github.com/apache/incubator-pinot/pull/7053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
xiangfu0 commented on issue #7055:
URL:
https://github.com/apache/incubator-pinot/issues/7055#issuecomment-860324925
Thirdeye is moved to
https://github.com/project-thirdeye/thirdeye
On Sun, Jun 13, 2021 at 18:36 Xiaotian (Jackie) Jiang <
***@***.***> wrote:
> We have re
codecov-commenter edited a comment on pull request #6998:
URL: https://github.com/apache/incubator-pinot/pull/6998#issuecomment-852478013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860384640
OK. The artifacts on maven central are now complete and correct.
The demo program at `https://github.com/tdunning/t-digest-example` builds on
a clean machine whic
codecov-commenter edited a comment on pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#issuecomment-853568285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
mqliang edited a comment on pull request #7056:
URL: https://github.com/apache/incubator-pinot/pull/7056#issuecomment-860436747
@siddharthteotia BTW, the PR change the metadata file layout, so will bring
incompatibility. Let's discuss that.
--
This is an automated message from the Apache
ChethanUK commented on pull request #47:
URL:
https://github.com/apache/incubator-pinot-site/pull/47#issuecomment-860067810
🔍 Inspect:
https://vercel.com/chethanuk/incubator-pinot-site/2kqa3BKnrJyV52d9rPSa59CUq2aT
✅ Preview: https://incubator-pinot-site-git-f-who-uses-chethanuk.vercel.a
codecov-commenter edited a comment on pull request #7026:
URL: https://github.com/apache/incubator-pinot/pull/7026#issuecomment-855347878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
theauheral opened a new issue #7055:
URL: https://github.com/apache/incubator-pinot/issues/7055
Is ThirdEye not supported anymore by Pinot? I do not see it in the repo
anymore and the docker image has the following errors when I launch it.
'''logs
Starting H2 database server
codecov-commenter edited a comment on pull request #7037:
URL: https://github.com/apache/incubator-pinot/pull/7037#issuecomment-858092963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
chenboat commented on a change in pull request #7037:
URL: https://github.com/apache/incubator-pinot/pull/7037#discussion_r650306425
##
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/filesystem/PinotFSTest.java
##
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Soft
mayankshriv opened a new pull request #7050:
URL: https://github.com/apache/incubator-pinot/pull/7050
## Description
- Rename test to match the method name being tested.
- Added TODO to cleanup values from deprecated configs after conversion.
## Upgrade Notes
Does this PR pr
KKcorps commented on a change in pull request #7021:
URL: https://github.com/apache/incubator-pinot/pull/7021#discussion_r650258937
##
File path:
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/StreamJSONMessageDecoder.java
##
yupeng9 opened a new issue #7051:
URL: https://github.com/apache/incubator-pinot/issues/7051
The column of string type of a default length, and value beyond the
threshold will be truncated. This creates issue for JSON field (i.e. with JSON
index on), as the JSON parsing will fail. We shall
codecov-commenter commented on pull request #7053:
URL: https://github.com/apache/incubator-pinot/pull/7053#issuecomment-859937981
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7053?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
Jackie-Jiang commented on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-859772614
> > LGTM. My only concern is how do we ensure the tests can pass in java 8?
We still want to keep java 8 supported
>
> We want to keep java 8 support, so we k
snleee edited a comment on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-859864776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sajjad-moradi commented on a change in pull request #7053:
URL: https://github.com/apache/incubator-pinot/pull/7053#discussion_r650294975
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/AggregateMetricsRule.java
##
@@ -68,6 +78,1
codecov-commenter commented on pull request #7052:
URL: https://github.com/apache/incubator-pinot/pull/7052#issuecomment-859828970
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
Jackie-Jiang commented on issue #7051:
URL:
https://github.com/apache/incubator-pinot/issues/7051#issuecomment-859779615
You may set the json field as data type `JSON` (introduced in #6878) and the
value won't be truncated
--
This is an automated message from the Apache Git Service.
To
xiangfu0 commented on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-859766573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Fo
chenboat commented on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-859897233
> FYI: @yupeng9 @chenboat do you guys have any thoughts?
we are in the process of releasing 0.7 now. if java 11 is used from 0.8
onward, we will do some test on o
wuwenw opened a new pull request #7052:
URL: https://github.com/apache/incubator-pinot/pull/7052
## Description
This PR adds query options for groupBy in-segment trim. Two options are
added: segmentMinTrimSize and segmentEnableTrim.
If segmentMinTrimSize is set to be positive
yupeng9 commented on issue #7051:
URL:
https://github.com/apache/incubator-pinot/issues/7051#issuecomment-859792390
Good to know that. A `JSON` type is useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Jackie-Jiang commented on a change in pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#discussion_r650224746
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/TableConfigUtilsTest.java
##
@@ -984,17 +989,19 @@ public void testValidat
snleee commented on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-859864776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
siddharthteotia commented on a change in pull request #7053:
URL: https://github.com/apache/incubator-pinot/pull/7053#discussion_r650280778
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/AggregateMetricsRule.java
##
@@ -68,6 +78
GSharayu commented on a change in pull request #7047:
URL: https://github.com/apache/incubator-pinot/pull/7047#discussion_r649632684
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/RequestStatistics.java
##
@@ -220,6 +222,10 @@ public long getOfflineThread
codecov-commenter edited a comment on pull request #7049:
URL: https://github.com/apache/incubator-pinot/pull/7049#issuecomment-859723695
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
codecov-commenter edited a comment on pull request #7053:
URL: https://github.com/apache/incubator-pinot/pull/7053#issuecomment-859937981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
mayankshriv commented on a change in pull request #7046:
URL: https://github.com/apache/incubator-pinot/pull/7046#discussion_r649639860
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java
##
@@ -212,4 +215,54 @@ public static ZNR
Jackie-Jiang merged pull request #7049:
URL: https://github.com/apache/incubator-pinot/pull/7049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
amrishlal commented on a change in pull request #6998:
URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r650319742
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java
##
@@ -0,0 +1,201 @@
+/*
codecov-commenter commented on pull request #7047:
URL: https://github.com/apache/incubator-pinot/pull/7047#issuecomment-859214445
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7047?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
siddharthteotia merged pull request #7047:
URL: https://github.com/apache/incubator-pinot/pull/7047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
cbalci commented on pull request #7037:
URL: https://github.com/apache/incubator-pinot/pull/7037#issuecomment-859750944
@Jackie-Jiang @chenboat @elonazoulay ptal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Jackie-Jiang merged pull request #7050:
URL: https://github.com/apache/incubator-pinot/pull/7050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
sajjad-moradi opened a new pull request #7053:
URL: https://github.com/apache/incubator-pinot/pull/7053
## Description
Currently AggregateMetric rule looks at selection columns and all of them
have to be metric and inside a SUM function. It misses the fact that for
group-by queries, gr
deemoliu commented on a change in pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#discussion_r650307998
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/merger/PartialUpsertMergerFactory.java
##
@@ -0,0 +1,41 @@
yupeng9 commented on a change in pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#discussion_r650204656
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java
##
@@ -0,0 +1,138 @@
+/**
+ * Lic
cbalci commented on a change in pull request #7037:
URL: https://github.com/apache/incubator-pinot/pull/7037#discussion_r650310610
##
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/filesystem/PinotFSTest.java
##
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Softwa
pedro93 opened a new issue #7048:
URL: https://github.com/apache/incubator-pinot/issues/7048
Hello,
When creating a table whose name does not match exactly the name of an
existing schema the UI will not provide auto-complete functionality regarding
which fields we can use. The worka
codecov-commenter edited a comment on pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#issuecomment-853568285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
xiangfu0 edited a comment on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-859903310
> > FYI: @yupeng9 @chenboat do you guys have any thoughts?
>
> we are in the process of releasing 0.7 now. if java 11 is used from 0.8
onward, we will do s
npawar opened a new pull request #7049:
URL: https://github.com/apache/incubator-pinot/pull/7049
Reverts apache/incubator-pinot#7042. As per discussion with @Jackie-Jiang
this is not needed for the particular case I was trying to solve (query timeout
can be set via broker conf)
--
This
mayankshriv merged pull request #7046:
URL: https://github.com/apache/incubator-pinot/pull/7046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this ser
codecov-commenter commented on pull request #7049:
URL: https://github.com/apache/incubator-pinot/pull/7049#issuecomment-859723695
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
Jackie-Jiang commented on a change in pull request #7046:
URL: https://github.com/apache/incubator-pinot/pull/7046#discussion_r649624131
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java
##
@@ -212,4 +215,54 @@ public static ZN
mayankshriv opened a new pull request #7046:
URL: https://github.com/apache/incubator-pinot/pull/7046
## Description
Since we are moving towards `IngestionConfig` for ingestion related
configurations, we need a utility to auto-convert the older `TableConfigs`
where some of these ingesti
mayankshriv merged pull request #7041:
URL: https://github.com/apache/incubator-pinot/pull/7041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this ser
codecov-commenter commented on pull request #7046:
URL: https://github.com/apache/incubator-pinot/pull/7046#issuecomment-859186381
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen
mcvsubbu commented on pull request #7041:
URL: https://github.com/apache/incubator-pinot/pull/7041#issuecomment-859152832
> LGTM. @mcvsubbu I believe LinkedIn limits the parallelism of the segment
commit, can you please take a look? Also do you have suggestion on the default
value?
siddharthteotia commented on a change in pull request #7047:
URL: https://github.com/apache/incubator-pinot/pull/7047#discussion_r649629237
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -232,6 +232,7 @@ public BrokerRe
GSharayu opened a new pull request #7047:
URL: https://github.com/apache/incubator-pinot/pull/7047
This PR adds numRowsResultSet to RequestStatistics. As we already have
ResultTable object computed, there is no extra overhead
--
This is an automated message from the Apache Git Service.
codecov-commenter edited a comment on pull request #7046:
URL: https://github.com/apache/incubator-pinot/pull/7046#issuecomment-859186381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
98 matches
Mail list logo
