[incubator-pinot] branch upgrade_zk_version updated (ab35518 -> 1e6e49a)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_zk_version in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard ab35518 Upgrade zookeeper version to 3.5.8 add 162d0e6 [TE]frontend - Upgrade from ember

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

fx19880617 commented on a change in pull request #6558: URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r574296423 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -154,18 +156,24 @@ public synchronized static Zook

[incubator-pinot] branch upgrade_zk_version updated (d1c9029 -> ab35518)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_zk_version in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit d1c9029 Upgrade zookeeper version to 3.5.8 add ab35518 Upgrade zookeeper version to 3.5.

[GitHub] [incubator-pinot] dependabot[bot] closed pull request #4818: Bump jackson.version from 2.9.8 to 2.10.1

dependabot[bot] closed pull request #4818: URL: https://github.com/apache/incubator-pinot/pull/4818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] dependabot[bot] commented on pull request #4818: Bump jackson.version from 2.9.8 to 2.10.1

dependabot[bot] commented on pull request #4818: URL: https://github.com/apache/incubator-pinot/pull/4818#issuecomment-777248676 Looks like these dependencies are up-to-date now, so this is no longer needed. This is an autom

[incubator-pinot] branch master updated (e4503a3 -> 503d0fe)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e4503a3 Support S3 with server side encryption mode aws:kms (#6565) add 503d0fe Update ADLSGen2PinotFS

[GitHub] [incubator-pinot] jackjlli merged pull request #6531: Update ADLSGen2PinotFS auth; Introduce unit tests

jackjlli merged pull request #6531: URL: https://github.com/apache/incubator-pinot/pull/6531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] jackjlli commented on pull request #6531: Update ADLSGen2PinotFS auth; Introduce unit tests

jackjlli commented on pull request #6531: URL: https://github.com/apache/incubator-pinot/pull/6531#issuecomment-777232076 Thanks for taking this up! I'm merging this PR now. This is an automated message from the Apache Git Se

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6466: Handle creation of segments with 0 rows

codecov-io edited a comment on pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#issuecomment-765818572 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6466?src=pr&el=h1) Report > Merging [#6466](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6419: Compatibility test: streamOp

mcvsubbu commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r574240057 ## File path: compatibility-verifier/compCheck.sh ## @@ -72,29 +72,31 @@ function checkoutAndBuild() { popd || exit 1 } -# Given a componen

[GitHub] [incubator-pinot] npawar commented on pull request #6466: Handle creation of segments with 0 rows

npawar commented on pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#issuecomment-777190471 > Discussed offline and seems allowing empty index segment is easier to manage. We may also consider adding an EmptyIndexSegment and EmptyDataSource for this special case

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

Jackie-Jiang commented on a change in pull request #6558: URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r574225196 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -154,18 +156,24 @@ public synchronized static Zo

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6570: Implement execute method of prepared statement class in JDBC

fx19880617 commented on a change in pull request #6570: URL: https://github.com/apache/incubator-pinot/pull/6570#discussion_r574220383 ## File path: pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotPreparedStatement.java ## @@ -154,6 +154,37 @@ public

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6570: Implement execute method of prepared statement class in JDBC

fx19880617 commented on a change in pull request #6570: URL: https://github.com/apache/incubator-pinot/pull/6570#discussion_r574219867 ## File path: pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotPreparedStatement.java ## @@ -154,6 +154,37 @@ public

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6570: Implement execute method of prepared statement class in JDBC

fx19880617 commented on a change in pull request #6570: URL: https://github.com/apache/incubator-pinot/pull/6570#discussion_r574219789 ## File path: pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotPreparedStatement.java ## @@ -154,6 +154,37 @@ public

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6541: - Adding new validation for Json, TEXT indexing

icefury71 commented on a change in pull request #6541: URL: https://github.com/apache/incubator-pinot/pull/6541#discussion_r574179684 ## File path: pinot-core/src/test/java/org/apache/pinot/core/util/TableConfigUtilsTest.java ## @@ -870,6 +916,69 @@ public void testValidateInd

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6541: - Adding new validation for Json, TEXT indexing

icefury71 commented on a change in pull request #6541: URL: https://github.com/apache/incubator-pinot/pull/6541#discussion_r574179544 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java ## @@ -474,11 +478,48 @@ private static void validateIn

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6466: Handle creation of segments with 0 rows

npawar commented on a change in pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#discussion_r574162371 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/EmptySegmentPruner.java ## @@ -0,0 +1,130 @@ +/** + * Licen

[GitHub] [incubator-pinot] rkanumul commented on a change in pull request #6531: Update ADLSGen2PinotFS auth; Introduce unit tests

rkanumul commented on a change in pull request #6531: URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r574149794 ## File path: pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java ## @@ -106,24 +11

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6531: Update ADLSGen2PinotFS auth; Introduce unit tests

snleee commented on a change in pull request #6531: URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r574148874 ## File path: pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java ## @@ -106,24 +118,

[incubator-pinot] branch master updated (779422f -> e4503a3)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 779422f [TE] update date format when send to Jira API (#6563) add e4503a3 Support S3 with server sid

[GitHub] [incubator-pinot] fx19880617 merged pull request #6565: Support S3PinotFS with server side encryption mode 'aws:kms'

fx19880617 merged pull request #6565: URL: https://github.com/apache/incubator-pinot/pull/6565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-pinot] fx19880617 closed issue #6564: feature: add support for S3 server-side encryption

fx19880617 closed issue #6564: URL: https://github.com/apache/incubator-pinot/issues/6564 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6541: - Adding new validation for Json, TEXT indexing

mayankshriv commented on a change in pull request #6541: URL: https://github.com/apache/incubator-pinot/pull/6541#discussion_r574093157 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java ## @@ -474,11 +478,48 @@ private static void validate

[incubator-pinot] branch upgrade_zk_version updated (ea0d605 -> d1c9029)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_zk_version in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard ea0d605 Upgrade zookeeper version add d1c9029 Upgrade zookeeper version to 3.5.8 This u

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

fx19880617 commented on a change in pull request #6558: URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r574086569 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -154,18 +156,23 @@ public synchronized static Zook

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

Jackie-Jiang commented on a change in pull request #6558: URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r574085474 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -154,18 +156,23 @@ public synchronized static Zo

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6565: Support S3PinotFS with server side encryption mode 'aws:kms'

fx19880617 commented on a change in pull request #6565: URL: https://github.com/apache/incubator-pinot/pull/6565#discussion_r574084007 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java ## @@ -526,36 +538,56 @

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6466: Handle creation of segments with 0 rows

Jackie-Jiang commented on pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#issuecomment-777040075 > > Mostly good. > > Another way to handle the server size empty segments is to not load them. In `ImmutableSegmentLoader`, return `null` if the segment is empty.

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

fx19880617 commented on a change in pull request #6558: URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r574078438 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -154,18 +156,23 @@ public synchronized static Zook

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

fx19880617 commented on a change in pull request #6558: URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r57400 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -51,17 +52,18 @@ private ZookeeperInstance(PublicZ

[incubator-pinot] branch master updated (a6196ba -> 779422f)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from a6196ba Adding metrics for minion tasks status (#6549) add 779422f [TE] update date format when send t

[GitHub] [incubator-pinot] jihaozh merged pull request #6563: [TE] update the format to DateTime when sending a date to the Jira API

jihaozh merged pull request #6563: URL: https://github.com/apache/incubator-pinot/pull/6563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

Jackie-Jiang commented on a change in pull request #6558: URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r574051198 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -51,17 +52,18 @@ private ZookeeperInstance(Publi

[GitHub] [incubator-pinot] zhangloo333 commented on a change in pull request #6568: Fix eslint error components fist 18

zhangloo333 commented on a change in pull request #6568: URL: https://github.com/apache/incubator-pinot/pull/6568#discussion_r574014889 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-custom-baseline/component.js ## @@ -26,10 +22,11 @@ export default Com

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6567: Enable segment upload to a realtime table

yupeng9 commented on a change in pull request #6567: URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r574013285 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java ## @@ -61,12 +61,15 @@ public void completeSe

[GitHub] [incubator-pinot] chenboat commented on pull request #6567: Enable segment upload to a realtime table

chenboat commented on pull request #6567: URL: https://github.com/apache/incubator-pinot/pull/6567#issuecomment-776953396 > How do we manage the stream offset if we upload a segment to the realtime table? Also, how about the segment name format? > We need to have an integration test to e

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6466: Handle creation of segments with 0 rows

mcvsubbu commented on pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#issuecomment-776930773 I still think an easier way is to just complete the empty segment without building it It will work for the realtime path, where this is needed. -

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6567: Enable segment upload to a realtime table

chenboat commented on a change in pull request #6567: URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r573984359 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -245

[GitHub] [incubator-pinot] npawar commented on pull request #6466: Handle creation of segments with 0 rows

npawar commented on pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#issuecomment-776927857 > Mostly good. > > Another way to handle the server size empty segments is to not load them. In `ImmutableSegmentLoader`, return `null` if the segment is empty. The

[GitHub] [incubator-pinot] tejasajmera commented on a change in pull request #6568: Fix eslint error components fist 18

tejasajmera commented on a change in pull request #6568: URL: https://github.com/apache/incubator-pinot/pull/6568#discussion_r573969478 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-custom-baseline/component.js ## @@ -26,10 +22,11 @@ export default Com

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6466: Handle creation of segments with 0 rows

npawar commented on a change in pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#discussion_r573976548 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/immutable/ImmutableSegmentLoader.java ## @@ -105,32 +105,34 @@ public st

[GitHub] [incubator-pinot] gracewalkuski commented on issue #6557: add execute() to JDBC PinotPreparedStatement

gracewalkuski commented on issue #6557: URL: https://github.com/apache/incubator-pinot/issues/6557#issuecomment-776839609 Yes that does work! Thanks so much! This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-pinot] gracewalkuski commented on issue #6557: add execute() to JDBC PinotPreparedStatement

gracewalkuski commented on issue #6557: URL: https://github.com/apache/incubator-pinot/issues/6557#issuecomment-776830039 Thanks @KKcorps ! I'll test it locally and let you know. This is an automated message from the Apache

[GitHub] [incubator-pinot] codecov-io commented on pull request #6570: implement execute method of prepared statement class in JDBC

codecov-io commented on pull request #6570: URL: https://github.com/apache/incubator-pinot/pull/6570#issuecomment-776657251 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6570?src=pr&el=h1) Report > Merging [#6570](https://codecov.io/gh/apache/incubator-pinot/pull/6570?s

[GitHub] [incubator-pinot] KKcorps commented on issue #6557: add execute() to JDBC PinotPreparedStatement

KKcorps commented on issue #6557: URL: https://github.com/apache/incubator-pinot/issues/6557#issuecomment-776625382 @gracewalkuski can you check if the code in the PR is what you are looking for or something more is needed.

[GitHub] [incubator-pinot] KKcorps commented on pull request #6570: implement execute method of prepared statement class in JDBC

KKcorps commented on pull request #6570: URL: https://github.com/apache/incubator-pinot/pull/6570#issuecomment-776624798 @fx19880617 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] KKcorps opened a new pull request #6570: implement execute method of prepared statement class in JDBC

KKcorps opened a new pull request #6570: URL: https://github.com/apache/incubator-pinot/pull/6570 This PR addresses issue #6557 . This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-pinot] KKcorps commented on issue #6557: add execute() to JDBC PinotPreparedStatement

KKcorps commented on issue #6557: URL: https://github.com/apache/incubator-pinot/issues/6557#issuecomment-776618450 Taking it up. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6565: Support S3PinotFS with server side encryption mode 'aws:kms'

KKcorps commented on a change in pull request #6565: URL: https://github.com/apache/incubator-pinot/pull/6565#discussion_r573621982 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java ## @@ -526,36 +538,56 @@ p

[GitHub] [incubator-pinot] rkanumul commented on a change in pull request #6531: Update ADLSGen2PinotFS auth; Introduce unit tests

rkanumul commented on a change in pull request #6531: URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573550197 ## File path: pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java ## @@ -106,24 +11