npawar commented on pull request #6466: URL: https://github.com/apache/incubator-pinot/pull/6466#issuecomment-777190471
> Discussed offline and seems allowing empty index segment is easier to manage. We may also consider adding an EmptyIndexSegment and EmptyDataSource for this special case. Please fix the tests before merging. Added the EmptyIndexSegment and EmptyDataSource. It does look cleaner, but I also feel it added a lot of code which only returns nulls. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
