[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6346: Introduce DimensionTableDataManager

2020-12-10 Thread GitBox
codecov-io edited a comment on pull request #6346: URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1) Report > Merging [#6346](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
codecov-io edited a comment on pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#issuecomment-725034051 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6255?src=pr&el=h1) Report > Merging [#6255](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io commented on pull request #6346: Introduce DimensionTableDataManager

2020-12-10 Thread GitBox
codecov-io commented on pull request #6346: URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1) Report > Merging [#6346](https://codecov.io/gh/apache/incubator-pinot/pull/6346?s

[GitHub] [incubator-pinot] cbalci opened a new pull request #6346: Introduce DimensionTableDataManager

2020-12-10 Thread GitBox
cbalci opened a new pull request #6346: URL: https://github.com/apache/incubator-pinot/pull/6346 ## Description Adding `DimensionTableDataManager` for managing data access for 'Dimension Tables'. It will be used by the upcoming `LookupTransformUDF` as outlined in [Lookup UDF Join In Pi

[incubator-pinot] branch json-indexing updated (bd6b9cc -> 36c9685)

2020-12-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch json-indexing in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard bd6b9cc adding support querying based on array index discard 2a4b98f adding example data for json

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6340: Adding Pinot minion segment generation and push task.

2020-12-10 Thread GitBox
mayankshriv commented on a change in pull request #6340: URL: https://github.com/apache/incubator-pinot/pull/6340#discussion_r540644259 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/SegmentGenerationAndPushTaskGenerator.java #

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6332: Simplify batch config and corresponding utils

2020-12-10 Thread GitBox
fx19880617 commented on a change in pull request #6332: URL: https://github.com/apache/incubator-pinot/pull/6332#discussion_r540641603 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFSFactory.java ## @@ -38,8 +38,8 @@ private PinotFSFactory() {

[GitHub] [incubator-pinot] fx19880617 commented on pull request #6332: Simplify batch config and corresponding utils

2020-12-10 Thread GitBox
fx19880617 commented on pull request #6332: URL: https://github.com/apache/incubator-pinot/pull/6332#issuecomment-742922054 > Are there any backward incompatibility implications? This config section is newly added after the 0.6.0 release, and we are still changing it. -

[incubator-pinot] branch master updated (64d1054 -> 75f9fd3)

2020-12-10 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 64d1054 Adding offline dim table creation and assignment (#6286) add 75f9fd3 Add a Controller endpo

[GitHub] [incubator-pinot] mcvsubbu merged pull request #6331: Add a Controller endpoint to return table creation time

2020-12-10 Thread GitBox
mcvsubbu merged pull request #6331: URL: https://github.com/apache/incubator-pinot/pull/6331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6332: Simplify batch config and corresponding utils

2020-12-10 Thread GitBox
mayankshriv commented on a change in pull request #6332: URL: https://github.com/apache/incubator-pinot/pull/6332#discussion_r540587662 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFSFactory.java ## @@ -38,8 +38,8 @@ private PinotFSFactory() {

[GitHub] [incubator-pinot] JoeFuentes-WebDev opened a new pull request #6345: [TE]frontend - THIRDEYE-3772 - create a new 'composite-anomalies' com…

2020-12-10 Thread GitBox
JoeFuentes-WebDev opened a new pull request #6345: URL: https://github.com/apache/incubator-pinot/pull/6345 …ponent plus very simple unit integration test ## Description Add a description of your PR here. A good description should include pointers to an issue or design document,

[GitHub] [incubator-pinot] JohnTortugo commented on pull request #6287: Parallelize segment index init and building

2020-12-10 Thread GitBox
JohnTortugo commented on pull request #6287: URL: https://github.com/apache/incubator-pinot/pull/6287#issuecomment-742821590 Hi @mayankshriv @mcvsubbu - after your reviews (and talking privately on Slack) I understand that segment creation execution time isn't a pain point; memory consumpt

[incubator-pinot] branch master updated: Adding offline dim table creation and assignment (#6286)

2020-12-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 64d1054 Adding offline dim table creat

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6286: Adding offline dimension table creation and segment assignment

2020-12-10 Thread GitBox
Jackie-Jiang merged pull request #6286: URL: https://github.com/apache/incubator-pinot/pull/6286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6286: Adding offline dimension table creation and segment assignment

2020-12-10 Thread GitBox
Jackie-Jiang commented on a change in pull request #6286: URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r540467147 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineDimTableSegmentAssignment.java ###

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6331: Add a Controller endpoint to return table creation time

2020-12-10 Thread GitBox
codecov-io edited a comment on pull request #6331: URL: https://github.com/apache/incubator-pinot/pull/6331#issuecomment-740341902 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6331?src=pr&el=h1) Report > Merging [#6331](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6331: Add a Controller endpoint to return table creation time

2020-12-10 Thread GitBox
codecov-io edited a comment on pull request #6331: URL: https://github.com/apache/incubator-pinot/pull/6331#issuecomment-740341902 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6331?src=pr&el=h1) Report > Merging [#6331](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6331: Add a Controller endpoint to return table creation time

2020-12-10 Thread GitBox
sajjad-moradi commented on a change in pull request #6331: URL: https://github.com/apache/incubator-pinot/pull/6331#discussion_r540421954 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2573,6 +2577,13 @

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6331: Add a Controller endpoint to return table creation time

2020-12-10 Thread GitBox
sajjad-moradi commented on a change in pull request #6331: URL: https://github.com/apache/incubator-pinot/pull/6331#discussion_r540421954 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2573,6 +2577,13 @

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6344: Implement ConsumerV2 interfaces along with Kinesis Integrations

2020-12-10 Thread GitBox
mcvsubbu commented on a change in pull request #6344: URL: https://github.com/apache/incubator-pinot/pull/6344#discussion_r540406760 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/v2/Checkpoint.java ## @@ -0,0 +1,6 @@ +package org.apache.pinot.spi.stream.v2;

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
siddharthteotia commented on pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#issuecomment-742706805 @icefury71 , Approved this. We can make the existing Tuner (RecommenderDriver) extend the Tuner interface, implement init(), apply() and register. I highly sugge

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
icefury71 commented on a change in pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#discussion_r540390423 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/tuner/RealTimeAutoIndexTuner.java ## @@ -0,0 +1,42 @@ +/** + * Licensed

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
icefury71 commented on a change in pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#discussion_r540389880 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/tuner/RealTimeAutoIndexTuner.java ## @@ -0,0 +1,42 @@ +/** + * Licensed

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6331: Add a Controller endpoint to return table creation time

2020-12-10 Thread GitBox
mcvsubbu commented on a change in pull request #6331: URL: https://github.com/apache/incubator-pinot/pull/6331#discussion_r540372776 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2573,6 +2577,13 @@ pri

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
siddharthteotia commented on a change in pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#discussion_r540372773 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/tuner/RealTimeAutoIndexTuner.java ## @@ -0,0 +1,42 @@ +/** + * Li

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6331: Add a Controller endpoint to return table creation time

2020-12-10 Thread GitBox
mcvsubbu commented on a change in pull request #6331: URL: https://github.com/apache/incubator-pinot/pull/6331#discussion_r540366317 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2573,6 +2577,13 @@ pri

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
icefury71 commented on a change in pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#discussion_r540364906 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/tuner/NoOpTableTableConfigTuner.java ## @@ -0,0 +1,38 @@ +/** + * Licen

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
siddharthteotia commented on a change in pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#discussion_r540356993 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/tuner/NoOpTableTableConfigTuner.java ## @@ -0,0 +1,38 @@ +/** + *

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6255: Creating a pluggable interface for Table config tuner

2020-12-10 Thread GitBox
siddharthteotia commented on a change in pull request #6255: URL: https://github.com/apache/incubator-pinot/pull/6255#discussion_r540356691 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/tuner/NoOpTableTableConfigTuner.java ## @@ -0,0 +1,38 @@ +/** + *

[GitHub] [incubator-pinot] jackjlli merged pull request #6329: Fix table cache logic in pinot-broker

2020-12-10 Thread GitBox
jackjlli merged pull request #6329: URL: https://github.com/apache/incubator-pinot/pull/6329 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (7c0e22d -> 4ba7204)

2020-12-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 7c0e22d Update .travis.yml (#6342) add 4ba7204 Fix table cache in pinot-broker (#6329) No new revision

[GitHub] [incubator-pinot] KKcorps opened a new pull request #6344: Implement ConsumerV2 interfaces along with Kinesis Integrations

2020-12-10 Thread GitBox
KKcorps opened a new pull request #6344: URL: https://github.com/apache/incubator-pinot/pull/6344 This PR is WIP. The plan is to create a new consumer interface that can support consumers other than Kafka. This i

[incubator-pinot] branch kinesis_integration created (now 7c0e22d)

2020-12-10 Thread kharekartik
This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a change to branch kinesis_integration in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 7c0e22d Update .travis.yml (#6342) No new revisions were added by this update. ---